Re: [patch V2 25/29] lockup_detector: Implement init time detection of perf

2017-09-13 Thread Ingo Molnar
* Thomas Gleixner wrote: > On Wed, 13 Sep 2017, Don Zickus wrote: > > > +/* Return 0, if a NMI watchdog is available. Error code otherwise */ > > > +int __weak __init void watchdog_nmi_probe(void) > > > > ^^^ compile error, can't have 'int' and 'void'. Removing 'void'

Re: [patch V2 25/29] lockup_detector: Implement init time detection of perf

2017-09-13 Thread Ingo Molnar
* Thomas Gleixner wrote: > On Wed, 13 Sep 2017, Don Zickus wrote: > > > +/* Return 0, if a NMI watchdog is available. Error code otherwise */ > > > +int __weak __init void watchdog_nmi_probe(void) > > > > ^^^ compile error, can't have 'int' and 'void'. Removing 'void' fixes it. > > Yes, I

Re: [patch V2 25/29] lockup_detector: Implement init time detection of perf

2017-09-13 Thread Thomas Gleixner
On Wed, 13 Sep 2017, Don Zickus wrote: > > +/* Return 0, if a NMI watchdog is available. Error code otherwise */ > > +int __weak __init void watchdog_nmi_probe(void) > > ^^^ compile error, can't have 'int' and 'void'. Removing 'void' fixes it. Yes, I know. I feel stupid because I'm 100% sure

Re: [patch V2 25/29] lockup_detector: Implement init time detection of perf

2017-09-13 Thread Thomas Gleixner
On Wed, 13 Sep 2017, Don Zickus wrote: > > +/* Return 0, if a NMI watchdog is available. Error code otherwise */ > > +int __weak __init void watchdog_nmi_probe(void) > > ^^^ compile error, can't have 'int' and 'void'. Removing 'void' fixes it. Yes, I know. I feel stupid because I'm 100% sure

Re: [patch V2 25/29] lockup_detector: Implement init time detection of perf

2017-09-13 Thread Don Zickus
On Tue, Sep 12, 2017 at 09:37:19PM +0200, Thomas Gleixner wrote: > Use the init time detection of the perf NMI watchdog to determine whether > the perf NMI watchdog is functional. If not disable it permanentely. It > won't come back magically at runtime. > > Signed-off-by: Thomas Gleixner

Re: [patch V2 25/29] lockup_detector: Implement init time detection of perf

2017-09-13 Thread Don Zickus
On Tue, Sep 12, 2017 at 09:37:19PM +0200, Thomas Gleixner wrote: > Use the init time detection of the perf NMI watchdog to determine whether > the perf NMI watchdog is functional. If not disable it permanentely. It > won't come back magically at runtime. > > Signed-off-by: Thomas Gleixner > Cc:

[patch V2 25/29] lockup_detector: Implement init time detection of perf

2017-09-12 Thread Thomas Gleixner
Use the init time detection of the perf NMI watchdog to determine whether the perf NMI watchdog is functional. If not disable it permanentely. It won't come back magically at runtime. Signed-off-by: Thomas Gleixner Cc: Don Zickus Cc: Chris Metcalf

[patch V2 25/29] lockup_detector: Implement init time detection of perf

2017-09-12 Thread Thomas Gleixner
Use the init time detection of the perf NMI watchdog to determine whether the perf NMI watchdog is functional. If not disable it permanentely. It won't come back magically at runtime. Signed-off-by: Thomas Gleixner Cc: Don Zickus Cc: Chris Metcalf Cc: Peter Zijlstra Cc: Sebastian Siewior Cc: