Re: [v3.10.y][v3.11.y][v3.12.y][v3.13.y][v3.14.y][PATCH 1/1][V2] ALSA: usb-audio: Prevent printk ratelimiting from spamming kernel log while DEBUG not defined

2014-07-07 Thread Greg KH
On Sat, Jun 21, 2014 at 12:48:27PM -0700, Greg KH wrote: > On Sat, Jun 21, 2014 at 01:05:53PM +0100, Ben Hutchings wrote: > > On Fri, 2014-06-20 at 14:21 -0400, Joseph Salisbury wrote: > > [...] > > > I looked at this some more. It seems like my v2 backport may be the > > > most suitable for the

Re: [v3.10.y][v3.11.y][v3.12.y][v3.13.y][v3.14.y][PATCH 1/1][V2] ALSA: usb-audio: Prevent printk ratelimiting from spamming kernel log while DEBUG not defined

2014-07-07 Thread Greg KH
On Sat, Jun 21, 2014 at 12:48:27PM -0700, Greg KH wrote: On Sat, Jun 21, 2014 at 01:05:53PM +0100, Ben Hutchings wrote: On Fri, 2014-06-20 at 14:21 -0400, Joseph Salisbury wrote: [...] I looked at this some more. It seems like my v2 backport may be the most suitable for the releases

Re: [v3.10.y][v3.11.y][v3.12.y][v3.13.y][v3.14.y][PATCH 1/1][V2] ALSA: usb-audio: Prevent printk ratelimiting from spamming kernel log while DEBUG not defined

2014-06-21 Thread Greg KH
On Sat, Jun 21, 2014 at 01:05:53PM +0100, Ben Hutchings wrote: > On Fri, 2014-06-20 at 14:21 -0400, Joseph Salisbury wrote: > [...] > > I looked at this some more. It seems like my v2 backport may be the > > most suitable for the releases mentioned in the subject line, but I'd > > like to get

Re: [v3.10.y][v3.11.y][v3.12.y][v3.13.y][v3.14.y][PATCH 1/1][V2] ALSA: usb-audio: Prevent printk ratelimiting from spamming kernel log while DEBUG not defined

2014-06-21 Thread Ben Hutchings
On Fri, 2014-06-20 at 14:21 -0400, Joseph Salisbury wrote: [...] > I looked at this some more. It seems like my v2 backport may be the > most suitable for the releases mentioned in the subject line, but I'd > like to get additional feedback. > > The lines added by commit a5065eb just get

Re: [v3.10.y][v3.11.y][v3.12.y][v3.13.y][v3.14.y][PATCH 1/1][V2] ALSA: usb-audio: Prevent printk ratelimiting from spamming kernel log while DEBUG not defined

2014-06-21 Thread Ben Hutchings
On Fri, 2014-06-20 at 14:21 -0400, Joseph Salisbury wrote: [...] I looked at this some more. It seems like my v2 backport may be the most suitable for the releases mentioned in the subject line, but I'd like to get additional feedback. The lines added by commit a5065eb just get removed by

Re: [v3.10.y][v3.11.y][v3.12.y][v3.13.y][v3.14.y][PATCH 1/1][V2] ALSA: usb-audio: Prevent printk ratelimiting from spamming kernel log while DEBUG not defined

2014-06-21 Thread Greg KH
On Sat, Jun 21, 2014 at 01:05:53PM +0100, Ben Hutchings wrote: On Fri, 2014-06-20 at 14:21 -0400, Joseph Salisbury wrote: [...] I looked at this some more. It seems like my v2 backport may be the most suitable for the releases mentioned in the subject line, but I'd like to get additional

Re: [v3.10.y][v3.11.y][v3.12.y][v3.13.y][v3.14.y][PATCH 1/1][V2] ALSA: usb-audio: Prevent printk ratelimiting from spamming kernel log while DEBUG not defined

2014-06-20 Thread Joseph Salisbury
On 06/20/2014 11:21 AM, Joseph Salisbury wrote: > On 06/18/2014 09:52 PM, Ben Hutchings wrote: >> On Wed, 2014-06-18 at 14:32 -0400, Joseph Salisbury wrote: >>> From: Sander Eikelenboom >>> >>> BugLink: http://bugs.launchpad.net/bugs/1319457 >>> >>> This (widely used) construction: >>> >>>

Re: Re: [v3.10.y][v3.11.y][v3.12.y][v3.13.y][v3.14.y][PATCH 1/1][V2] ALSA: usb-audio: Prevent printk ratelimiting from spamming kernel log while DEBUG not defined

2014-06-20 Thread Joseph Salisbury
On 06/18/2014 09:52 PM, Ben Hutchings wrote: > On Wed, 2014-06-18 at 14:32 -0400, Joseph Salisbury wrote: >> From: Sander Eikelenboom >> >> BugLink: http://bugs.launchpad.net/bugs/1319457 >> >> This (widely used) construction: >> >> if(printk_ratelimit()) >> dev_dbg() >> >> Causes the

Re: Re: [v3.10.y][v3.11.y][v3.12.y][v3.13.y][v3.14.y][PATCH 1/1][V2] ALSA: usb-audio: Prevent printk ratelimiting from spamming kernel log while DEBUG not defined

2014-06-20 Thread Joseph Salisbury
On 06/18/2014 09:52 PM, Ben Hutchings wrote: On Wed, 2014-06-18 at 14:32 -0400, Joseph Salisbury wrote: From: Sander Eikelenboom li...@eikelenboom.it BugLink: http://bugs.launchpad.net/bugs/1319457 This (widely used) construction: if(printk_ratelimit()) dev_dbg() Causes the

Re: [v3.10.y][v3.11.y][v3.12.y][v3.13.y][v3.14.y][PATCH 1/1][V2] ALSA: usb-audio: Prevent printk ratelimiting from spamming kernel log while DEBUG not defined

2014-06-20 Thread Joseph Salisbury
On 06/20/2014 11:21 AM, Joseph Salisbury wrote: On 06/18/2014 09:52 PM, Ben Hutchings wrote: On Wed, 2014-06-18 at 14:32 -0400, Joseph Salisbury wrote: From: Sander Eikelenboom li...@eikelenboom.it BugLink: http://bugs.launchpad.net/bugs/1319457 This (widely used) construction:

Re: [v3.10.y][v3.11.y][v3.12.y][v3.13.y][v3.14.y][PATCH 1/1][V2] ALSA: usb-audio: Prevent printk ratelimiting from spamming kernel log while DEBUG not defined

2014-06-18 Thread Ben Hutchings
On Wed, 2014-06-18 at 14:32 -0400, Joseph Salisbury wrote: > From: Sander Eikelenboom > > BugLink: http://bugs.launchpad.net/bugs/1319457 > > This (widely used) construction: > > if(printk_ratelimit()) > dev_dbg() > > Causes the ratelimiting to spam the kernel log with the "callbacks

[v3.10.y][v3.11.y][v3.12.y][v3.13.y][v3.14.y][PATCH 1/1][V2] ALSA: usb-audio: Prevent printk ratelimiting from spamming kernel log while DEBUG not defined

2014-06-18 Thread Joseph Salisbury
From: Sander Eikelenboom BugLink: http://bugs.launchpad.net/bugs/1319457 This (widely used) construction: if(printk_ratelimit()) dev_dbg() Causes the ratelimiting to spam the kernel log with the "callbacks suppressed" message below, even while the dev_dbg it is supposed to rate limit

[v3.10.y][v3.11.y][v3.12.y][v3.13.y][v3.14.y][PATCH 1/1][V2] ALSA: usb-audio: Prevent printk ratelimiting from spamming kernel log while DEBUG not defined

2014-06-18 Thread Joseph Salisbury
From: Sander Eikelenboom li...@eikelenboom.it BugLink: http://bugs.launchpad.net/bugs/1319457 This (widely used) construction: if(printk_ratelimit()) dev_dbg() Causes the ratelimiting to spam the kernel log with the callbacks suppressed message below, even while the dev_dbg it is

Re: [v3.10.y][v3.11.y][v3.12.y][v3.13.y][v3.14.y][PATCH 1/1][V2] ALSA: usb-audio: Prevent printk ratelimiting from spamming kernel log while DEBUG not defined

2014-06-18 Thread Ben Hutchings
On Wed, 2014-06-18 at 14:32 -0400, Joseph Salisbury wrote: From: Sander Eikelenboom li...@eikelenboom.it BugLink: http://bugs.launchpad.net/bugs/1319457 This (widely used) construction: if(printk_ratelimit()) dev_dbg() Causes the ratelimiting to spam the kernel log with the