Re: [v8,5/7] PCI: mediatek-gen3: Add MSI support

2021-03-11 Thread Jianjun Wang
On Thu, 2021-03-11 at 08:19 +, Marc Zyngier wrote: > On 2021-03-11 00:05, Pali Rohár wrote: > > On Wednesday 24 February 2021 14:11:30 Jianjun Wang wrote: > >> +static int mtk_msi_bottom_domain_alloc(struct irq_domain *domain, > >> + unsigned int virq, unsigned

Re: [v8,5/7] PCI: mediatek-gen3: Add MSI support

2021-03-11 Thread Jianjun Wang
On Wed, 2021-03-10 at 09:41 +, Marc Zyngier wrote: > On Wed, 10 Mar 2021 06:48:49 +, > Jianjun Wang wrote: > > > > +static struct irq_chip mtk_msi_irq_chip = { > > > > + .name = "MSI", > > > > + .irq_enable = mtk_pcie_irq_unmask, > > > > + .irq_disable =

Re: [v8,5/7] PCI: mediatek-gen3: Add MSI support

2021-03-11 Thread Marc Zyngier
On 2021-03-11 00:05, Pali Rohár wrote: On Wednesday 24 February 2021 14:11:30 Jianjun Wang wrote: +static int mtk_msi_bottom_domain_alloc(struct irq_domain *domain, + unsigned int virq, unsigned int nr_irqs, + void *arg)

Re: [v8,5/7] PCI: mediatek-gen3: Add MSI support

2021-03-10 Thread Pali Rohár
On Wednesday 24 February 2021 14:11:30 Jianjun Wang wrote: > +static int mtk_msi_bottom_domain_alloc(struct irq_domain *domain, > +unsigned int virq, unsigned int nr_irqs, > +void *arg) > +{ > + struct mtk_pcie_port *port

Re: [v8,5/7] PCI: mediatek-gen3: Add MSI support

2021-03-09 Thread Jianjun Wang
Hi Marc, Thanks for your review. On Tue, 2021-03-09 at 11:23 +, Marc Zyngier wrote: > On Wed, 24 Feb 2021 06:11:30 +, > Jianjun Wang wrote: > > > > Add MSI support for MediaTek Gen3 PCIe controller. > > > > This PCIe controller supports up to 256 MSI vectors, the MSI hardware > >

Re: [v8,5/7] PCI: mediatek-gen3: Add MSI support

2021-03-09 Thread Marc Zyngier
On Wed, 24 Feb 2021 06:11:30 +, Jianjun Wang wrote: > > Add MSI support for MediaTek Gen3 PCIe controller. > > This PCIe controller supports up to 256 MSI vectors, the MSI hardware > block diagram is as follows: > > +-+ > | GIC | >

Re: [v8,5/7] PCI: mediatek-gen3: Add MSI support

2021-02-24 Thread Jianjun Wang
Hi Krzysztof, Thanks for your review, I will fix it at next version. On Wed, 2021-02-24 at 15:31 +0100, Krzysztof Wilczyński wrote: > Hi Jianjun, > > [...] > > +static struct irq_chip mtk_msi_irq_chip = { > > + .name = "MSI", > > + .irq_enable = mtk_pcie_irq_unmask, > > + .irq_disable =

Re: [v8,5/7] PCI: mediatek-gen3: Add MSI support

2021-02-24 Thread Krzysztof Wilczyński
Hi Jianjun, [...] > +static struct irq_chip mtk_msi_irq_chip = { > + .name = "MSI", > + .irq_enable = mtk_pcie_irq_unmask, > + .irq_disable = mtk_pcie_irq_mask, > + .irq_ack = irq_chip_ack_parent, > + .irq_mask = mtk_pcie_irq_mask, > + .irq_unmask = mtk_pcie_irq_unmask, >

[v8,5/7] PCI: mediatek-gen3: Add MSI support

2021-02-23 Thread Jianjun Wang
Add MSI support for MediaTek Gen3 PCIe controller. This PCIe controller supports up to 256 MSI vectors, the MSI hardware block diagram is as follows: +-+ | GIC | +-+ ^ |