Re: 4.10-rc3, firmware loading via user space helper crashes if firmware not present

2017-01-13 Thread Jakub Kicinski
On Fri, 13 Jan 2017 13:32:58 -0800, Jakub Kicinski wrote: > If one requests a FW which does not exist in the FS and the user space > helper is used then fw_load_abort() will be called twice which leads to > NULL-deref. > > It will be called once in firmware_loading_store() (handling the -1 >

Re: 4.10-rc3, firmware loading via user space helper crashes if firmware not present

2017-01-13 Thread Jakub Kicinski
On Fri, 13 Jan 2017 13:32:58 -0800, Jakub Kicinski wrote: > If one requests a FW which does not exist in the FS and the user space > helper is used then fw_load_abort() will be called twice which leads to > NULL-deref. > > It will be called once in firmware_loading_store() (handling the -1 >

4.10-rc3, firmware loading via user space helper crashes if firmware not present

2017-01-13 Thread Jakub Kicinski
Hi! If one requests a FW which does not exist in the FS and the user space helper is used then fw_load_abort() will be called twice which leads to NULL-deref. It will be called once in firmware_loading_store() (handling the -1 case) and then again in _request_firmware_load() because return value

4.10-rc3, firmware loading via user space helper crashes if firmware not present

2017-01-13 Thread Jakub Kicinski
Hi! If one requests a FW which does not exist in the FS and the user space helper is used then fw_load_abort() will be called twice which leads to NULL-deref. It will be called once in firmware_loading_store() (handling the -1 case) and then again in _request_firmware_load() because return value