Re: Inverted mount options completely broken (iversion,relatime)

2020-07-29 Thread David Howells
David Howells wrote: > > So my question is, what do we do here? > > Hmmm... As the code stands, MS_RDONLY, MS_SYNCHRONOUS, MS_MANDLOCK, > MS_I_VERSION and MS_LAZYTIME should all be masked off before the new flags are > set if called from mount(2) rather than fsconfig(2). > > do_remount()

Re: Inverted mount options completely broken (iversion,relatime)

2020-07-29 Thread David Howells
Josef Bacik wrote: > So my question is, what do we do here? Hmmm... As the code stands, MS_RDONLY, MS_SYNCHRONOUS, MS_MANDLOCK, MS_I_VERSION and MS_LAZYTIME should all be masked off before the new flags are set if called from mount(2) rather than fsconfig(2). do_remount() gives MS_RMT_MASK to

Re: Inverted mount options completely broken (iversion,relatime)

2020-07-29 Thread Josef Bacik
On 7/29/20 2:41 PM, Eric Sandeen wrote: On 7/29/20 11:32 AM, Josef Bacik wrote: Hello, Eric reported a problem to me where we were clearing SB_I_VERSION on remount of a btrfs file system.  After digging through I discovered it's because we expect the proper flags that we want to be passed in

Re: Inverted mount options completely broken (iversion,relatime)

2020-07-29 Thread Eric Sandeen
On 7/29/20 11:32 AM, Josef Bacik wrote: > Hello, > > Eric reported a problem to me where we were clearing SB_I_VERSION on remount > of a btrfs file system.  After digging through I discovered it's because we > expect the proper flags that we want to be passed in via the mount() syscall, > and

Inverted mount options completely broken (iversion,relatime)

2020-07-29 Thread Josef Bacik
Hello, Eric reported a problem to me where we were clearing SB_I_VERSION on remount of a btrfs file system. After digging through I discovered it's because we expect the proper flags that we want to be passed in via the mount() syscall, and because we didn't have "iversion" in our