Re: Make checkpatch.pl's quiet option not print the summary on no errors

2008-01-17 Thread Andy Whitcroft
On Wed, Jan 16, 2008 at 12:06:46PM +0100, Ingo Molnar wrote: > > btw, just found a checkpatch.pl buglet, it gets confused on zero-sized > files: > > $ echo -n > /tmp/1.c > $ scripts/checkpatch.pl --file /tmp/1.c > ERROR: Does not appear to be a unified-diff format patch > > total: 1

Re: Make checkpatch.pl's quiet option not print the summary on no errors

2008-01-17 Thread Andy Whitcroft
On Wed, Jan 16, 2008 at 12:06:46PM +0100, Ingo Molnar wrote: btw, just found a checkpatch.pl buglet, it gets confused on zero-sized files: $ echo -n /tmp/1.c $ scripts/checkpatch.pl --file /tmp/1.c ERROR: Does not appear to be a unified-diff format patch total: 1 errors, 0

Re: Make checkpatch.pl's quiet option not print the summary on no errors

2008-01-16 Thread Ingo Molnar
btw, just found a checkpatch.pl buglet, it gets confused on zero-sized files: $ echo -n > /tmp/1.c $ scripts/checkpatch.pl --file /tmp/1.c ERROR: Does not appear to be a unified-diff format patch total: 1 errors, 0 warnings, 0 lines checked Your patch has style problems, please review.

Re: Make checkpatch.pl's quiet option not print the summary on no errors

2008-01-15 Thread Ingo Molnar
* Andy Whitcroft <[EMAIL PROTECTED]> wrote: > On Thu, Jan 03, 2008 at 01:54:42AM +0100, Arjan van de Ven wrote: > > Subject: Make checkpatch.pl's quiet option not print the summary on no > > errors > > From: Arjan van de Ven <[EMAIL PROTECTED]> > > CC: [EMAIL PROTECTED] > > > > Right now, in

Re: Make checkpatch.pl's quiet option not print the summary on no errors

2008-01-15 Thread Andy Whitcroft
On Thu, Jan 03, 2008 at 01:54:42AM +0100, Arjan van de Ven wrote: > Subject: Make checkpatch.pl's quiet option not print the summary on no > errors > From: Arjan van de Ven <[EMAIL PROTECTED]> > CC: [EMAIL PROTECTED] > > Right now, in quiet mode, checkpatch.pl still prints a summary line even >

Re: Make checkpatch.pl's quiet option not print the summary on no errors

2008-01-15 Thread Andy Whitcroft
On Thu, Jan 03, 2008 at 01:54:42AM +0100, Arjan van de Ven wrote: Subject: Make checkpatch.pl's quiet option not print the summary on no errors From: Arjan van de Ven [EMAIL PROTECTED] CC: [EMAIL PROTECTED] Right now, in quiet mode, checkpatch.pl still prints a summary line even if the

Re: Make checkpatch.pl's quiet option not print the summary on no errors

2008-01-15 Thread Ingo Molnar
* Andy Whitcroft [EMAIL PROTECTED] wrote: On Thu, Jan 03, 2008 at 01:54:42AM +0100, Arjan van de Ven wrote: Subject: Make checkpatch.pl's quiet option not print the summary on no errors From: Arjan van de Ven [EMAIL PROTECTED] CC: [EMAIL PROTECTED] Right now, in quiet mode,

Re: Make checkpatch.pl's quiet option not print the summary on no errors

2008-01-03 Thread Andy Whitcroft
On Thu, Jan 03, 2008 at 01:54:42AM +0100, Arjan van de Ven wrote: > Subject: Make checkpatch.pl's quiet option not print the summary on no > errors > From: Arjan van de Ven <[EMAIL PROTECTED]> > CC: [EMAIL PROTECTED] > > Right now, in quiet mode, checkpatch.pl still prints a summary line even >

Re: Make checkpatch.pl's quiet option not print the summary on no errors

2008-01-03 Thread Andy Whitcroft
On Thu, Jan 03, 2008 at 01:54:42AM +0100, Arjan van de Ven wrote: Subject: Make checkpatch.pl's quiet option not print the summary on no errors From: Arjan van de Ven [EMAIL PROTECTED] CC: [EMAIL PROTECTED] Right now, in quiet mode, checkpatch.pl still prints a summary line even if the

Make checkpatch.pl's quiet option not print the summary on no errors

2008-01-02 Thread Arjan van de Ven
Subject: Make checkpatch.pl's quiet option not print the summary on no errors From: Arjan van de Ven <[EMAIL PROTECTED]> CC: [EMAIL PROTECTED] Right now, in quiet mode, checkpatch.pl still prints a summary line even if the patch is 100% clean. IMO, "quiet mode" should mean "no output if clean",

Make checkpatch.pl's quiet option not print the summary on no errors

2008-01-02 Thread Arjan van de Ven
Subject: Make checkpatch.pl's quiet option not print the summary on no errors From: Arjan van de Ven [EMAIL PROTECTED] CC: [EMAIL PROTECTED] Right now, in quiet mode, checkpatch.pl still prints a summary line even if the patch is 100% clean. IMO, quiet mode should mean no output if clean, the