Re: PATCH: more esssolo1 cleanups

2001-05-22 Thread Jeff Garzik
Looks ok. General comment: the code to search through the list of PCI devices and drivers to find the one associated with our minor should be in a separate function, if that code appears more than once. esssolo_find_minor or somesuch... -- Jeff Garzik | "Are you the police?" Building

PATCH: more esssolo1 cleanups

2001-05-22 Thread Marcus Meissner
Hi, I did some more cleanups: - changed PM to 2.4 pci module style - removed global list of devices, now using pci device data. I tried to add a pci_set_power_state(dev,3) in _remove, but this apparently has no effect (amplifier stays switched on), so I did not submit this part. Tested on IBM

PATCH: more esssolo1 cleanups

2001-05-22 Thread Marcus Meissner
Hi, I did some more cleanups: - changed PM to 2.4 pci module style - removed global list of devices, now using pci device data. I tried to add a pci_set_power_state(dev,3) in _remove, but this apparently has no effect (amplifier stays switched on), so I did not submit this part. Tested on IBM

Re: PATCH: more esssolo1 cleanups

2001-05-22 Thread Jeff Garzik
Looks ok. General comment: the code to search through the list of PCI devices and drivers to find the one associated with our minor should be in a separate function, if that code appears more than once. esssolo_find_minor or somesuch... -- Jeff Garzik | Are you the police? Building 1024