RE: [PATCH] char: ppdev: check if ioctl argument is present and valid

2020-10-24 Thread David Laight
From: Arnd Bergmann > Sent: 24 October 2020 20:21 > To: harshal chaudhari > Cc: David Laight ; Greg KH > ; Sudip Mukherjee > ; linux-kernel > Subject: Re: [PATCH] char: ppdev: check if ioctl argument is present and valid > > On Sat, Oct 24, 2020 at 5:54 PM harshal chaudhari > wrote: > > On

Re: [PATCH] char: ppdev: check if ioctl argument is present and valid

2020-10-24 Thread harshal chaudhari
On Sun, Oct 25, 2020 at 12:51 AM Arnd Bergmann wrote: > > On Sat, Oct 24, 2020 at 5:54 PM harshal chaudhari > wrote: > > On Tue, Oct 13, 2020 at 4:42 PM David Laight > > wrote: > > > So I am a little bit confused about this check whether it's required or not > > Please could you point me in

Re: [PATCH] char: ppdev: check if ioctl argument is present and valid

2020-10-24 Thread Arnd Bergmann
On Sat, Oct 24, 2020 at 5:54 PM harshal chaudhari wrote: > On Tue, Oct 13, 2020 at 4:42 PM David Laight wrote: > So I am a little bit confused about this check whether it's required or not > Please could you point me in the right direction? > > In any case, thanks for your help ... > > Here is

RE: [PATCH] char: ppdev: check if ioctl argument is present and valid

2020-10-13 Thread David Laight
From: harshal chaudhari > Sent: 13 October 2020 10:01 > > On Sat, Oct 10, 2020 at 2:41 PM Sudip Mukherjee > wrote: > > > > On Sat, Oct 10, 2020 at 1:08 AM Sudip Mukherjee > > wrote: > > > > > > On Fri, Oct 9, 2020 at 5:57 AM Greg KH wrote: > > > > > > > > On Thu, Oct 08, 2020 at 11:57:13PM

Re: [PATCH] char: ppdev: check if ioctl argument is present and valid

2020-10-13 Thread Greg KH
On Tue, Oct 13, 2020 at 02:31:21PM +0530, harshal chaudhari wrote: > On Sat, Oct 10, 2020 at 2:41 PM Sudip Mukherjee > wrote: > > > > On Sat, Oct 10, 2020 at 1:08 AM Sudip Mukherjee > > wrote: > > > > > > On Fri, Oct 9, 2020 at 5:57 AM Greg KH wrote: > > > > > > > > On Thu, Oct 08, 2020 at

Re: [PATCH] char: ppdev: check if ioctl argument is present and valid

2020-10-13 Thread harshal chaudhari
On Sat, Oct 10, 2020 at 2:41 PM Sudip Mukherjee wrote: > > On Sat, Oct 10, 2020 at 1:08 AM Sudip Mukherjee > wrote: > > > > On Fri, Oct 9, 2020 at 5:57 AM Greg KH wrote: > > > > > > On Thu, Oct 08, 2020 at 11:57:13PM +0530, Harshal Chaudhari wrote: > > > > Checking the argument passed to the

Re: [PATCH] char: ppdev: check if ioctl argument is present and valid

2020-10-10 Thread Sudip Mukherjee
On Sat, Oct 10, 2020 at 1:08 AM Sudip Mukherjee wrote: > > On Fri, Oct 9, 2020 at 5:57 AM Greg KH wrote: > > > > On Thu, Oct 08, 2020 at 11:57:13PM +0530, Harshal Chaudhari wrote: > > > Checking the argument passed to the ioctl is valid > > > or not. if not then return -EINVAL. > > > > Along the

Re: [PATCH] char: ppdev: check if ioctl argument is present and valid

2020-10-09 Thread Sudip Mukherjee
On Fri, Oct 9, 2020 at 5:57 AM Greg KH wrote: > > On Thu, Oct 08, 2020 at 11:57:13PM +0530, Harshal Chaudhari wrote: > > Checking the argument passed to the ioctl is valid > > or not. if not then return -EINVAL. > > Along the the comments that Arnd made, this is not the correct value to > be

Re: [PATCH] char: ppdev: check if ioctl argument is present and valid

2020-10-08 Thread Greg KH
On Thu, Oct 08, 2020 at 11:57:13PM +0530, Harshal Chaudhari wrote: > Checking the argument passed to the ioctl is valid > or not. if not then return -EINVAL. Along the the comments that Arnd made, this is not the correct value to be returning from an ioctl when you don't pass in the correct

Re: [PATCH] char: ppdev: check if ioctl argument is present and valid

2020-10-08 Thread Arnd Bergmann
On Thu, Oct 8, 2020 at 8:27 PM Harshal Chaudhari wrote: > > Checking the argument passed to the ioctl is valid > or not. if not then return -EINVAL. > > Signed-off-by: Harshal Chaudhari > --- > drivers/char/ppdev.c | 12 +++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff