RE: [PATCH] drm/amd/powerplay: mark symbols static where possible

2016-10-25 Thread Deucher, Alexander
ric; > Yang, Young; Huang, Ray; Dan Carpenter; Cui, Flora; Nils Wallménius; Liu, > Monk; Wang, Ken; Min, Frank; dri-devel; Linux Kernel Mailing List; > xie.bao...@zte.com.cn; han@zte.com.cn; tang.qiang...@zte.com.cn > Subject: Re: [PATCH] drm/amd/powerplay: mark symbols static where >

RE: [PATCH] drm/amd/powerplay: mark symbols static where possible

2016-10-25 Thread Deucher, Alexander
ric; > Yang, Young; Huang, Ray; Dan Carpenter; Cui, Flora; Nils Wallménius; Liu, > Monk; Wang, Ken; Min, Frank; dri-devel; Linux Kernel Mailing List; > xie.bao...@zte.com.cn; han@zte.com.cn; tang.qiang...@zte.com.cn > Subject: Re: [PATCH] drm/amd/powerplay: mark symbols static where >

Re: [PATCH] drm/amd/powerplay: mark symbols static where possible

2016-10-25 Thread Arnd Bergmann
On Tuesday, October 25, 2016 10:31:21 AM CEST Baoyou Xie wrote: > On 25 October 2016 at 04:51, Arnd Bergmann wrote: > > On Saturday, October 22, 2016 4:56:22 PM CEST Baoyou Xie wrote: > > The function has no callers, so the easiest way would be to remove it > > entirely, but it's

Re: [PATCH] drm/amd/powerplay: mark symbols static where possible

2016-10-25 Thread Arnd Bergmann
On Tuesday, October 25, 2016 10:31:21 AM CEST Baoyou Xie wrote: > On 25 October 2016 at 04:51, Arnd Bergmann wrote: > > On Saturday, October 22, 2016 4:56:22 PM CEST Baoyou Xie wrote: > > The function has no callers, so the easiest way would be to remove it > > entirely, but it's possible that

Re: [PATCH] drm/amd/powerplay: mark symbols static where possible

2016-10-25 Thread Daniel Vetter
On Tue, Oct 25, 2016 at 09:09:01AM +0200, Christian König wrote: > Am 25.10.2016 um 08:41 schrieb Daniel Vetter: > > On Mon, Oct 24, 2016 at 10:41:16PM +0200, Arnd Bergmann wrote: > > > On Monday, October 24, 2016 8:07:16 PM CEST Deucher, Alexander wrote: > > > > > > > In fact, these functions are

Re: [PATCH] drm/amd/powerplay: mark symbols static where possible

2016-10-25 Thread Daniel Vetter
On Tue, Oct 25, 2016 at 09:09:01AM +0200, Christian König wrote: > Am 25.10.2016 um 08:41 schrieb Daniel Vetter: > > On Mon, Oct 24, 2016 at 10:41:16PM +0200, Arnd Bergmann wrote: > > > On Monday, October 24, 2016 8:07:16 PM CEST Deucher, Alexander wrote: > > > > > > > In fact, these functions are

Re: [PATCH] drm/amd/powerplay: mark symbols static where possible

2016-10-25 Thread Christian König
Am 25.10.2016 um 08:41 schrieb Daniel Vetter: On Mon, Oct 24, 2016 at 10:41:16PM +0200, Arnd Bergmann wrote: On Monday, October 24, 2016 8:07:16 PM CEST Deucher, Alexander wrote: In fact, these functions are only used in the file in which they are declared and don't need a declaration, but can

Re: [PATCH] drm/amd/powerplay: mark symbols static where possible

2016-10-25 Thread Christian König
Am 25.10.2016 um 08:41 schrieb Daniel Vetter: On Mon, Oct 24, 2016 at 10:41:16PM +0200, Arnd Bergmann wrote: On Monday, October 24, 2016 8:07:16 PM CEST Deucher, Alexander wrote: In fact, these functions are only used in the file in which they are declared and don't need a declaration, but can

Re: [PATCH] drm/amd/powerplay: mark symbols static where possible

2016-10-25 Thread Daniel Vetter
On Mon, Oct 24, 2016 at 10:41:16PM +0200, Arnd Bergmann wrote: > On Monday, October 24, 2016 8:07:16 PM CEST Deucher, Alexander wrote: > > > > > In fact, these functions are only used in the file in which they are > > > > > declared and don't need a declaration, but can be made static. > > > > >

Re: [PATCH] drm/amd/powerplay: mark symbols static where possible

2016-10-25 Thread Daniel Vetter
On Mon, Oct 24, 2016 at 10:41:16PM +0200, Arnd Bergmann wrote: > On Monday, October 24, 2016 8:07:16 PM CEST Deucher, Alexander wrote: > > > > > In fact, these functions are only used in the file in which they are > > > > > declared and don't need a declaration, but can be made static. > > > > >

Re: [PATCH] drm/amd/powerplay: mark symbols static where possible

2016-10-24 Thread Arnd Bergmann
On Saturday, October 22, 2016 4:56:22 PM CEST Baoyou Xie wrote: > @@ -1341,7 +1341,7 @@ int smu7_disable_dpm_tasks(struct pp_hwmgr *hwmgr) > return result; > } > > -int smu7_reset_asic_tasks(struct pp_hwmgr *hwmgr) > +static int smu7_reset_asic_tasks(struct pp_hwmgr *hwmgr) > { > >

Re: [PATCH] drm/amd/powerplay: mark symbols static where possible

2016-10-24 Thread Arnd Bergmann
On Saturday, October 22, 2016 4:56:22 PM CEST Baoyou Xie wrote: > @@ -1341,7 +1341,7 @@ int smu7_disable_dpm_tasks(struct pp_hwmgr *hwmgr) > return result; > } > > -int smu7_reset_asic_tasks(struct pp_hwmgr *hwmgr) > +static int smu7_reset_asic_tasks(struct pp_hwmgr *hwmgr) > { > >

Re: [PATCH] drm/amd/powerplay: mark symbols static where possible

2016-10-24 Thread Arnd Bergmann
On Monday, October 24, 2016 8:07:16 PM CEST Deucher, Alexander wrote: > > > > In fact, these functions are only used in the file in which they are > > > > declared and don't need a declaration, but can be made static. > > > > So this patch marks these functions with 'static'. > > > > > > > >

Re: [PATCH] drm/amd/powerplay: mark symbols static where possible

2016-10-24 Thread Arnd Bergmann
On Monday, October 24, 2016 8:07:16 PM CEST Deucher, Alexander wrote: > > > > In fact, these functions are only used in the file in which they are > > > > declared and don't need a declaration, but can be made static. > > > > So this patch marks these functions with 'static'. > > > > > > > >

RE: [PATCH] drm/amd/powerplay: mark symbols static where possible

2016-10-24 Thread Deucher, Alexander
Yang, > Eric; Yang, Young; Huang, Ray; Dan Carpenter; Cui, Flora; Nils Wallménius; > Liu, > Monk; Wang, Ken; Min, Frank; tang.qiang...@zte.com.cn; > xie.bao...@zte.com.cn; LKML; Maling list - DRI developers; > han@zte.com.cn > Subject: Re: [PATCH] drm/amd/powerplay:

RE: [PATCH] drm/amd/powerplay: mark symbols static where possible

2016-10-24 Thread Deucher, Alexander
Yang, > Eric; Yang, Young; Huang, Ray; Dan Carpenter; Cui, Flora; Nils Wallménius; > Liu, > Monk; Wang, Ken; Min, Frank; tang.qiang...@zte.com.cn; > xie.bao...@zte.com.cn; LKML; Maling list - DRI developers; > han@zte.com.cn > Subject: Re: [PATCH] drm/amd/powerplay:

Re: [PATCH] drm/amd/powerplay: mark symbols static where possible

2016-10-24 Thread Arnd Bergmann
On Monday, October 24, 2016 12:36:52 PM CEST Alex Deucher wrote: > On Sat, Oct 22, 2016 at 4:56 AM, Baoyou Xie wrote: > > We get a few warnings when building kernel with W=1: > > drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/fiji_smumgr.c:162:5: > > warning: no previous

Re: [PATCH] drm/amd/powerplay: mark symbols static where possible

2016-10-24 Thread Arnd Bergmann
On Monday, October 24, 2016 12:36:52 PM CEST Alex Deucher wrote: > On Sat, Oct 22, 2016 at 4:56 AM, Baoyou Xie wrote: > > We get a few warnings when building kernel with W=1: > > drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/fiji_smumgr.c:162:5: > > warning: no previous prototype for

Re: [PATCH] drm/amd/powerplay: mark symbols static where possible

2016-10-24 Thread Alex Deucher
On Sat, Oct 22, 2016 at 4:56 AM, Baoyou Xie wrote: > We get a few warnings when building kernel with W=1: > drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/fiji_smumgr.c:162:5: warning: > no previous prototype for 'fiji_setup_pwr_virus' [-Wmissing-prototypes] >

Re: [PATCH] drm/amd/powerplay: mark symbols static where possible

2016-10-24 Thread Alex Deucher
On Sat, Oct 22, 2016 at 4:56 AM, Baoyou Xie wrote: > We get a few warnings when building kernel with W=1: > drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/fiji_smumgr.c:162:5: warning: > no previous prototype for 'fiji_setup_pwr_virus' [-Wmissing-prototypes] >

Re: [PATCH] drm/amd/powerplay: mark symbols static where possible

2016-10-22 Thread Edward O'Callaghan
Oh dear, still more of these? Why not perhaps fix them all at once into a series? In any case, Acked-by: Edward O'Callaghan On 10/22/2016 07:56 PM, Baoyou Xie wrote: > We get a few warnings when building kernel with W=1: >

Re: [PATCH] drm/amd/powerplay: mark symbols static where possible

2016-10-22 Thread Edward O'Callaghan
Oh dear, still more of these? Why not perhaps fix them all at once into a series? In any case, Acked-by: Edward O'Callaghan On 10/22/2016 07:56 PM, Baoyou Xie wrote: > We get a few warnings when building kernel with W=1: > drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/fiji_smumgr.c:162:5: