Re: [PATCH] drm/radeon: remove code that can never get executed

2014-10-13 Thread Henning Schild
On Mon, 13 Oct 2014 17:31:12 + "Deucher, Alexander" wrote: > Ah, ok. The attached patches should do the trick then. Yes that would do the trick. But i suggest doing the NULL initialization in drm_edid_to_speaker_allocation. The kernel doc suggests that whatever

RE: [PATCH] drm/radeon: remove code that can never get executed

2014-10-13 Thread Deucher, Alexander
> -Original Message- > From: Henning Schild [mailto:henn...@hennsch.de] > Sent: Saturday, October 11, 2014 8:51 AM > To: linux-kernel@vger.kernel.org > Cc: Henning Schild; Deucher, Alexander; Rafał Miłecki > Subject: [PATCH] drm/radeon: remove code that can never get executed > > Removing

RE: [PATCH] drm/radeon: remove code that can never get executed

2014-10-13 Thread Deucher, Alexander
> -Original Message- > From: Henning Schild [mailto:henn...@hennsch.de] > Sent: Monday, October 13, 2014 12:44 PM > To: Deucher, Alexander; linux-kernel@vger.kernel.org > Cc: Rafał Miłecki > Subject: RE: [PATCH] drm/radeon: remove code that can never get executed >

RE: [PATCH] drm/radeon: remove code that can never get executed

2014-10-13 Thread Henning Schild
Well i am not sure what the code actually is supposed to do. That is up to you because you know the hardware. I just wanted to point out that right now some code can never be reached. I ran into the whole thing because the pointer (sadp) that gets kfreed was never initialized (in one of the three

RE: [PATCH] drm/radeon: remove code that can never get executed

2014-10-13 Thread Henning Schild
Well i am not sure what the code actually is supposed to do. That is up to you because you know the hardware. I just wanted to point out that right now some code can never be reached. I ran into the whole thing because the pointer (sadp) that gets kfreed was never initialized (in one of the three

RE: [PATCH] drm/radeon: remove code that can never get executed

2014-10-13 Thread Deucher, Alexander
-Original Message- From: Henning Schild [mailto:henn...@hennsch.de] Sent: Monday, October 13, 2014 12:44 PM To: Deucher, Alexander; linux-kernel@vger.kernel.org Cc: Rafał Miłecki Subject: RE: [PATCH] drm/radeon: remove code that can never get executed Well i am not sure what

RE: [PATCH] drm/radeon: remove code that can never get executed

2014-10-13 Thread Deucher, Alexander
-Original Message- From: Henning Schild [mailto:henn...@hennsch.de] Sent: Saturday, October 11, 2014 8:51 AM To: linux-kernel@vger.kernel.org Cc: Henning Schild; Deucher, Alexander; Rafał Miłecki Subject: [PATCH] drm/radeon: remove code that can never get executed Removing a

Re: [PATCH] drm/radeon: remove code that can never get executed

2014-10-13 Thread Henning Schild
On Mon, 13 Oct 2014 17:31:12 + Deucher, Alexander alexander.deuc...@amd.com wrote: Ah, ok. The attached patches should do the trick then. Yes that would do the trick. But i suggest doing the NULL initialization in drm_edid_to_speaker_allocation. The kernel doc suggests that whatever