RE: [PATCH] mm/compaction: remove unused variable sysctl_compact_memory

2021-03-03 Thread Nitin Gupta
ernel.org; iamjoonsoo@lge.com; > sh_...@163.com; mateusznos...@gmail.com; b...@redhat.com; > vba...@suse.cz; yzai...@google.com; keesc...@chromium.org; > mcg...@kernel.org; mgor...@techsingularity.net; pintu.p...@gmail.com > Subject: Re: [PATCH] mm/compaction: remove unused variable >

Re: [PATCH] mm/compaction: remove unused variable sysctl_compact_memory

2021-03-03 Thread pintu
On 2021-03-03 22:39, Vlastimil Babka wrote: On 3/2/21 6:56 PM, Pintu Kumar wrote: The sysctl_compact_memory is mostly unsed in mm/compaction.c It just acts as a place holder for sysctl. Thus we can remove it from here and move the declaration directly in kernel/sysctl.c itself. This will also

Re: [PATCH] mm/compaction: remove unused variable sysctl_compact_memory

2021-03-03 Thread Vlastimil Babka
On 3/2/21 6:56 PM, Pintu Kumar wrote: > The sysctl_compact_memory is mostly unsed in mm/compaction.c > It just acts as a place holder for sysctl. > > Thus we can remove it from here and move the declaration directly > in kernel/sysctl.c itself. > This will also eliminate the extern declaration

Re: [PATCH] mm/compaction: remove unused variable sysctl_compact_memory

2021-03-03 Thread pintu
On 2021-03-03 01:48, Nitin Gupta wrote: -Original Message- From: pintu=codeaurora@mg.codeaurora.org On Behalf Of Pintu Kumar Sent: Tuesday, March 2, 2021 9:56 AM To: linux-kernel@vger.kernel.org; a...@linux-foundation.org; linux- m...@kvack.org; linux-fsde...@vger.kernel.org;

Re: [PATCH] mm/compaction: remove unused variable sysctl_compact_memory

2021-03-03 Thread Chaitanya Kulkarni
On 3/2/21 22:21, Pintu Kumar wrote: > The sysctl_compact_memory is mostly unsed in mm/compaction.c > It just acts as a place holder for sysctl. > > Thus we can remove it from here and move the declaration directly > in kernel/sysctl.c itself. > This will also eliminate the extern declaration from

RE: [PATCH] mm/compaction: remove unused variable sysctl_compact_memory

2021-03-02 Thread Nitin Gupta
> -Original Message- > From: pintu=codeaurora@mg.codeaurora.org > On Behalf Of Pintu Kumar > Sent: Tuesday, March 2, 2021 9:56 AM > To: linux-kernel@vger.kernel.org; a...@linux-foundation.org; linux- > m...@kvack.org; linux-fsde...@vger.kernel.org; pi...@codeaurora.org; >