Re: [PATCH 10/11] spi/s3c64xx: improve error handling

2012-08-10 Thread Arnd Bergmann
On Friday 10 August 2012, Kukjin Kim wrote: > BTW for same reason, probably, we need following fix? > > arch/arm/mach-tegra/tegra2_emc.c |4 ++-- > arch/c6x/kernel/setup.c |2 +- > arch/powerpc/kernel/ibmebus.c|2 +- >

Re: [PATCH 10/11] spi/s3c64xx: improve error handling

2012-08-10 Thread Thomas Abraham
On 8 August 2012 20:17, Arnd Bergmann wrote: > When a device tree definition os an s3c64xx SPI master is missing > a "controller-data" subnode, the newly added s3c64xx_get_slave_ctrldata > function might use uninitialized memory in place of that node, > which was correctly reported by gcc. > >

RE: [PATCH 10/11] spi/s3c64xx: improve error handling

2012-08-10 Thread Kukjin Kim
Arnd Bergmann wrote: > > When a device tree definition os an s3c64xx SPI master is missing > a "controller-data" subnode, the newly added s3c64xx_get_slave_ctrldata > function might use uninitialized memory in place of that node, > which was correctly reported by gcc. > > Without this patch,

RE: [PATCH 10/11] spi/s3c64xx: improve error handling

2012-08-10 Thread Kukjin Kim
Arnd Bergmann wrote: When a device tree definition os an s3c64xx SPI master is missing a controller-data subnode, the newly added s3c64xx_get_slave_ctrldata function might use uninitialized memory in place of that node, which was correctly reported by gcc. Without this patch, building

Re: [PATCH 10/11] spi/s3c64xx: improve error handling

2012-08-10 Thread Thomas Abraham
On 8 August 2012 20:17, Arnd Bergmann a...@arndb.de wrote: When a device tree definition os an s3c64xx SPI master is missing a controller-data subnode, the newly added s3c64xx_get_slave_ctrldata function might use uninitialized memory in place of that node, which was correctly reported by gcc.

Re: [PATCH 10/11] spi/s3c64xx: improve error handling

2012-08-10 Thread Arnd Bergmann
On Friday 10 August 2012, Kukjin Kim wrote: BTW for same reason, probably, we need following fix? arch/arm/mach-tegra/tegra2_emc.c |4 ++-- arch/c6x/kernel/setup.c |2 +- arch/powerpc/kernel/ibmebus.c|2 +-