Re: [PATCH v4 1/2] usb: phy: samsung: Common out the generic stuff

2013-02-04 Thread Vivek Gautam
Hi Kukjin, On Wed, Jan 30, 2013 at 11:26 AM, Kukjin Kim wrote: > Vivek Gautam wrote: >> >> Moving register and structure definitions to header file, >> and keeping the generic functions to be used across >> multiple PHYs in common file "samsung-usbphy.c". >> Also renaming the usb 2.0 phy driver

Re: [PATCH v4 1/2] usb: phy: samsung: Common out the generic stuff

2013-02-04 Thread Vivek Gautam
Hi Kukjin, On Wed, Jan 30, 2013 at 11:26 AM, Kukjin Kim kgene@samsung.com wrote: Vivek Gautam wrote: Moving register and structure definitions to header file, and keeping the generic functions to be used across multiple PHYs in common file samsung-usbphy.c. Also renaming the usb 2.0

RE: [PATCH v4 1/2] usb: phy: samsung: Common out the generic stuff

2013-01-29 Thread Kukjin Kim
Vivek Gautam wrote: > > Moving register and structure definitions to header file, > and keeping the generic functions to be used across > multiple PHYs in common file "samsung-usbphy.c". > Also renaming the usb 2.0 phy driver to "samsung-usb2.c" Just in my opinion, Samsung-usb2phy is more

RE: [PATCH v4 1/2] usb: phy: samsung: Common out the generic stuff

2013-01-29 Thread Kukjin Kim
Vivek Gautam wrote: Moving register and structure definitions to header file, and keeping the generic functions to be used across multiple PHYs in common file samsung-usbphy.c. Also renaming the usb 2.0 phy driver to samsung-usb2.c Just in my opinion, Samsung-usb2phy is more clear?...In