RE: [PATCHv3 1/3] ASoC: codec: Simplify ASoC probe code.

2014-03-09 Thread li.xi...@freescale.com
> Subject: Re: [PATCHv3 1/3] ASoC: codec: Simplify ASoC probe code. > > On Mon, Mar 03, 2014 at 07:24:36AM +, li.xi...@freescale.com wrote: > > > > > /* Default to using ALC auto offset calibration mode. */ > > > > snd_soc

RE: [PATCHv3 1/3] ASoC: codec: Simplify ASoC probe code.

2014-03-09 Thread li.xi...@freescale.com
Subject: Re: [PATCHv3 1/3] ASoC: codec: Simplify ASoC probe code. On Mon, Mar 03, 2014 at 07:24:36AM +, li.xi...@freescale.com wrote: /* Default to using ALC auto offset calibration mode. */ snd_soc_update_bits(codec, DA7213_ALC_CTRL1

Re: [PATCHv3 1/3] ASoC: codec: Simplify ASoC probe code.

2014-03-03 Thread Mark Brown
On Mon, Mar 03, 2014 at 07:24:36AM +, li.xi...@freescale.com wrote: > > > /* Default to using ALC auto offset calibration mode. */ > > > snd_soc_update_bits(codec, DA7213_ALC_CTRL1, > > > DA7213_ALC_CALIB_MODE_MAN, 0); > > This one will fail. > Sorry, I'm not very

Re: [PATCHv3 1/3] ASoC: codec: Simplify ASoC probe code.

2014-03-03 Thread Mark Brown
On Mon, Mar 03, 2014 at 07:24:36AM +, li.xi...@freescale.com wrote: /* Default to using ALC auto offset calibration mode. */ snd_soc_update_bits(codec, DA7213_ALC_CTRL1, DA7213_ALC_CALIB_MODE_MAN, 0); This one will fail. Sorry, I'm not very understand

RE: [PATCHv3 1/3] ASoC: codec: Simplify ASoC probe code.

2014-03-02 Thread li.xi...@freescale.com
> > static int ak4535_probe(struct snd_soc_codec *codec) > > { > > - struct ak4535_priv *ak4535 = snd_soc_codec_get_drvdata(codec); > > - int ret; > > - > > - codec->control_data = ak4535->regmap; > > - ret = snd_soc_codec_set_cache_io(codec, 8, 8, SND_SOC_REGMAP); > > - if (ret < 0) {

Re: [PATCHv3 1/3] ASoC: codec: Simplify ASoC probe code.

2014-03-02 Thread Mark Brown
On Mon, Mar 03, 2014 at 10:42:22AM +0800, Xiubo Li wrote: > static int ak4535_probe(struct snd_soc_codec *codec) > { > - struct ak4535_priv *ak4535 = snd_soc_codec_get_drvdata(codec); > - int ret; > - > - codec->control_data = ak4535->regmap; > - ret =

Re: [PATCHv3 1/3] ASoC: codec: Simplify ASoC probe code.

2014-03-02 Thread Mark Brown
On Mon, Mar 03, 2014 at 10:42:22AM +0800, Xiubo Li wrote: static int ak4535_probe(struct snd_soc_codec *codec) { - struct ak4535_priv *ak4535 = snd_soc_codec_get_drvdata(codec); - int ret; - - codec-control_data = ak4535-regmap; - ret = snd_soc_codec_set_cache_io(codec,

RE: [PATCHv3 1/3] ASoC: codec: Simplify ASoC probe code.

2014-03-02 Thread li.xi...@freescale.com
static int ak4535_probe(struct snd_soc_codec *codec) { - struct ak4535_priv *ak4535 = snd_soc_codec_get_drvdata(codec); - int ret; - - codec-control_data = ak4535-regmap; - ret = snd_soc_codec_set_cache_io(codec, 8, 8, SND_SOC_REGMAP); - if (ret 0) { -