RE: [alsa-devel] [PATCHv2 1/3] ASoC: codec: Simplify ASoC probe code.

2014-03-02 Thread li.xi...@freescale.com
> Looks good in general, but try to build these kinds of changes with > CONFIG_COMPILE_TEST=y and CONFIG_SND_SOC_ALL_CODECS=y before sending the > patch. There are a lot of warnings about unused variables caused by this > patch. > @Lars, Oh, yes, these are very low-level errors, I will fix

RE: [alsa-devel] [PATCHv2 1/3] ASoC: codec: Simplify ASoC probe code.

2014-03-02 Thread li.xi...@freescale.com
Looks good in general, but try to build these kinds of changes with CONFIG_COMPILE_TEST=y and CONFIG_SND_SOC_ALL_CODECS=y before sending the patch. There are a lot of warnings about unused variables caused by this patch. @Lars, Oh, yes, these are very low-level errors, I will fix them

Re: [alsa-devel] [PATCHv2 1/3] ASoC: codec: Simplify ASoC probe code.

2014-02-28 Thread Lars-Peter Clausen
On 02/28/2014 10:04 AM, Xiubo Li wrote: Signed-off-by: Xiubo Li --- @Mark, @Lars, @All, I have checked for each driver about the following issue from Lars: "Just removing the set_cache_io() call will not work for all drivers. There are some MFD child devices which use regmap from the parent

Re: [alsa-devel] [PATCHv2 1/3] ASoC: codec: Simplify ASoC probe code.

2014-02-28 Thread Lars-Peter Clausen
On 02/28/2014 10:04 AM, Xiubo Li wrote: Signed-off-by: Xiubo Li li.xi...@freescale.com --- @Mark, @Lars, @All, I have checked for each driver about the following issue from Lars: Just removing the set_cache_io() call will not work for all drivers. There are some MFD child devices which use