Re: [PATCH] Convert drivers/scsi/ch.c to use unlocked_ioctl

On Mon, Jan 14, 2008 at 03:31:17PM +0100, Mathieu Segaud wrote: > + .owner = THIS_MODULE, > + .open = ch_open, > + .release= ch_release, > + .unlocked_ioctl = ch_ioctl, Do you have a tab setting that's not 8? You seem to have

Re: [PATCH] Convert drivers/scsi/ch.c to use unlocked_ioctl

Vous m'avez dit récemment : > On Mon, Jan 14, 2008 at 02:32:13PM +0100, Mathieu Segaud wrote: >> +#include > You don't add any uses of lock_kernel() and there are none in the > driver currently. yep, it was before I noticed the locking semantics of ch_ioctl_compat() >> -.owner=

Re: [PATCH] Convert drivers/scsi/ch.c to use unlocked_ioctl

On Mon, Jan 14, 2008 at 02:32:13PM +0100, Mathieu Segaud wrote: > +#include You don't add any uses of lock_kernel() and there are none in the driver currently. > - .owner= THIS_MODULE, > - .open = ch_open, > - .release = ch_release, > - .ioctl=

Re: [PATCH] Convert drivers/scsi/ch.c to use unlocked_ioctl

On Mon, Jan 14, 2008 at 02:32:13PM +0100, Mathieu Segaud wrote: +#include linux/smp_lock.h You don't add any uses of lock_kernel() and there are none in the driver currently. - .owner= THIS_MODULE, - .open = ch_open, - .release = ch_release, - .ioctl

Re: [PATCH] Convert drivers/scsi/ch.c to use unlocked_ioctl

Vous m'avez dit récemment : On Mon, Jan 14, 2008 at 02:32:13PM +0100, Mathieu Segaud wrote: +#include linux/smp_lock.h You don't add any uses of lock_kernel() and there are none in the driver currently. yep, it was before I noticed the locking semantics of ch_ioctl_compat() -.owner

Re: [PATCH] Convert drivers/scsi/ch.c to use unlocked_ioctl

On Mon, Jan 14, 2008 at 03:31:17PM +0100, Mathieu Segaud wrote: + .owner = THIS_MODULE, + .open = ch_open, + .release= ch_release, + .unlocked_ioctl = ch_ioctl, Do you have a tab setting that's not 8? You seem to have used