Hi Andrzej,
Some hopefully useful/constructive feedback:
Andrzej Krzysztofowicz wrote:
>
> +static char version[]
> +#ifdef MODULE
> + __initdata
> +#else
> + __devinitdata
> +#endif
> + = KERN_INFO RTL8139_DRIVER_NAME "\n";
This doesn't look right. If defined(MODULE) then _
On Thu, May 24, 2001 at 09:00:20AM -0700, Jonathan Lundell wrote:
[...]
>
> Fine. But:
>
> At 3:02 AM +0200 2001-05-24, Andrzej Krzysztofowicz wrote:
> >-printk(version);
> >+#ifdef MODULE
> >+printk("s", version);
> > printed_version = 1;
> >+#endif /* MODULE */
>
> ...is playing i
> > - printk(version);
> > + printk("%s", version);
> >
> Could you please explain the purpose of this change? To me it looks less
> efficient in both performance and memory usage.
its called 'programming in C not taking ugly shortcuts'
>
-
To unsubscribe from this list: se
> Thanks for your impressive clean-up patch. I have a couple of comments
> regarding your clean-up of the dmfe.c driver.
Thanks for your response.
> On Thu, 24 May 2001, Andrzej Krzysztofowicz wrote:
>
> > @@ -395,7 +395,7 @@
> > u32 dev_rev, pci_pmr;
> >
> > if (!printed_version++)
>
On 2001-05-24T10:45:25,
Tobias Ringstrom <[EMAIL PROTECTED]> said:
> > if (!printed_version++)
> > - printk(version);
> > + printk("%s", version);
> >
> > DMFE_DBUG(0, "dmfe_init_one()", 0);
> >
>
> Could you please explain the purpose of this change? To me it loo
Andrzej,
Thanks for your impressive clean-up patch. I have a couple of comments
regarding your clean-up of the dmfe.c driver.
On Thu, 24 May 2001, Andrzej Krzysztofowicz wrote:
> @@ -395,7 +395,7 @@
> u32 dev_rev, pci_pmr;
>
> if (!printed_version++)
> - printk(version)
These two patches look generally ok. However, I'm going to hold them in
my mailbox for a little while, until two 8139 bug fixes and a tulip bug
fix are sent to Linus/Alan.
--
Jeff Garzik | "Are you the police?"
Building 1024| "No, ma'am. We're musicians."
MandrakeSoft |
-
To unsubs
7 matches
Mail list logo
