Re: [PATCH] drm/nouveau/bios: fix bug introduced in 457e77b2

2014-04-11 Thread Ben Skeggs
On Thu, Apr 10, 2014 at 5:33 AM, Andreas Noever wrote: > 457e77b2 effectively replaces (... & 0xff00) << 8 with (... >> 8) << 8. > Which does not do the same and breaks boot on my machine. > > Restore the old behaviour and remove the unnecessary cast. > > Signed-off-by: Andreas Noever

Re: [PATCH] drm/nouveau/bios: fix bug introduced in 457e77b2

2014-04-11 Thread Ben Skeggs
On Thu, Apr 10, 2014 at 5:33 AM, Andreas Noever andreas.noe...@gmail.com wrote: 457e77b2 effectively replaces (... 0xff00) 8 with (... 8) 8. Which does not do the same and breaks boot on my machine. Restore the old behaviour and remove the unnecessary cast. Signed-off-by: Andreas

REGRESSION Re: [PATCH] drm/nouveau/bios: fix bug introduced in 457e77b2

2014-04-10 Thread Thomas Glanzmann
Hello Andreas, after pulling and rebooting my machine this morning, nouveau was no longer working: [6.455247] nouveau [ DEVICE][:02:00.0] BOOT0 : 0x0ac080b1 [6.455312] nouveau [ DEVICE][:02:00.0] Chipset: MCP79/MCP7A (NVAC) [6.455374] nouveau [ DEVICE][:02:00.0]

REGRESSION Re: [PATCH] drm/nouveau/bios: fix bug introduced in 457e77b2

2014-04-10 Thread Thomas Glanzmann
Hello Andreas, after pulling and rebooting my machine this morning, nouveau was no longer working: [6.455247] nouveau [ DEVICE][:02:00.0] BOOT0 : 0x0ac080b1 [6.455312] nouveau [ DEVICE][:02:00.0] Chipset: MCP79/MCP7A (NVAC) [6.455374] nouveau [ DEVICE][:02:00.0]