Re: [PATCH] mmc: rtsx: fix incorrect last byte in R2 response

2014-08-14 Thread Ulf Hansson
On 14 August 2014 08:06, Roger Tseng wrote: > On Wed, 2014-08-13 at 17:09 +0200, Ulf Hansson wrote: >> On 11 August 2014 10:32, wrote: >> > From: Roger Tseng >> > >> > Current code erroneously fill the last byte of R2 response with an >> > undefined >> > value. In addition, it is impossible

Re: [PATCH] mmc: rtsx: fix incorrect last byte in R2 response

2014-08-14 Thread Roger Tseng
On Wed, 2014-08-13 at 17:09 +0200, Ulf Hansson wrote: > On 11 August 2014 10:32, wrote: > > From: Roger Tseng > > > > Current code erroneously fill the last byte of R2 response with an undefined > > value. In addition, it is impossible to obtain the real values since the > > controller actually

Re: [PATCH] mmc: rtsx: fix incorrect last byte in R2 response

2014-08-14 Thread Roger Tseng
On Wed, 2014-08-13 at 17:09 +0200, Ulf Hansson wrote: On 11 August 2014 10:32, rogera...@realtek.com wrote: From: Roger Tseng rogera...@realtek.com Current code erroneously fill the last byte of R2 response with an undefined value. In addition, it is impossible to obtain the real values

Re: [PATCH] mmc: rtsx: fix incorrect last byte in R2 response

2014-08-14 Thread Ulf Hansson
On 14 August 2014 08:06, Roger Tseng rogera...@realtek.com wrote: On Wed, 2014-08-13 at 17:09 +0200, Ulf Hansson wrote: On 11 August 2014 10:32, rogera...@realtek.com wrote: From: Roger Tseng rogera...@realtek.com Current code erroneously fill the last byte of R2 response with an

Re: [PATCH] mmc: rtsx: fix incorrect last byte in R2 response

2014-08-13 Thread Ulf Hansson
On 11 August 2014 10:32, wrote: > From: Roger Tseng > > Current code erroneously fill the last byte of R2 response with an undefined > value. In addition, it is impossible to obtain the real values since the > controller actually 'offloads' the last byte(CRC7, end bit) while receiving R2 >

Re: [PATCH] mmc: rtsx: fix incorrect last byte in R2 response

2014-08-13 Thread Dan Carpenter
On Tue, Aug 12, 2014 at 03:19:12PM +0800, Roger wrote: > I can remove the unused rsp_len in this function. But I'm afraid the > loop is still required. The destination cmd->resp is cpu-endian, but > the raw response from SD card in the buffer (pointed by ptr) is > big-endian. Oh, yes. Of course.

Re: [PATCH] mmc: rtsx: fix incorrect last byte in R2 response

2014-08-13 Thread Dan Carpenter
On Tue, Aug 12, 2014 at 03:19:12PM +0800, Roger wrote: I can remove the unused rsp_len in this function. But I'm afraid the loop is still required. The destination cmd-resp is cpu-endian, but the raw response from SD card in the buffer (pointed by ptr) is big-endian. Oh, yes. Of course.

Re: [PATCH] mmc: rtsx: fix incorrect last byte in R2 response

2014-08-13 Thread Ulf Hansson
On 11 August 2014 10:32, rogera...@realtek.com wrote: From: Roger Tseng rogera...@realtek.com Current code erroneously fill the last byte of R2 response with an undefined value. In addition, it is impossible to obtain the real values since the controller actually 'offloads' the last

Re: [PATCH] mmc: rtsx: fix incorrect last byte in R2 response

2014-08-12 Thread Roger
On 08/11/2014 09:02 PM, Dan Carpenter wrote: On Mon, Aug 11, 2014 at 04:32:16PM +0800, rogera...@realtek.com wrote: From: Roger Tseng Current code erroneously fill the last byte of R2 response with an undefined value. In addition, it is impossible to obtain the real values since the

Re: [PATCH] mmc: rtsx: fix incorrect last byte in R2 response

2014-08-12 Thread Roger
On 08/11/2014 09:02 PM, Dan Carpenter wrote: On Mon, Aug 11, 2014 at 04:32:16PM +0800, rogera...@realtek.com wrote: From: Roger Tseng rogera...@realtek.com Current code erroneously fill the last byte of R2 response with an undefined value. In addition, it is impossible to obtain the real

Re: [PATCH] mmc: rtsx: fix incorrect last byte in R2 response

2014-08-11 Thread Dan Carpenter
On Mon, Aug 11, 2014 at 04:32:16PM +0800, rogera...@realtek.com wrote: > From: Roger Tseng > > Current code erroneously fill the last byte of R2 response with an undefined > value. In addition, it is impossible to obtain the real values since the > controller actually 'offloads' the last

Re: [PATCH] mmc: rtsx: fix incorrect last byte in R2 response

2014-08-11 Thread Dan Carpenter
On Mon, Aug 11, 2014 at 04:32:16PM +0800, rogera...@realtek.com wrote: From: Roger Tseng rogera...@realtek.com Current code erroneously fill the last byte of R2 response with an undefined value. In addition, it is impossible to obtain the real values since the controller actually 'offloads'