Re: [PATCH] serial: samsung: fix the inconsistency in spinlock

>>> In my next patch I have tried to remove the spin_unlock/spin_lock over >>> uart_write_wakeup(port); >> >> Which may create lockups. Previously there was no port locking around >> uart_write_wakeup. Now there will be. You are effectively adding locking >> over uart_write_wakeup(). >> Again, we

Re: [PATCH] serial: samsung: fix the inconsistency in spinlock

>>> In my next patch I have tried to remove the spin_unlock/spin_lock over >>> uart_write_wakeup(port); >> >> Which may create lockups. Previously there was no port locking around >> uart_write_wakeup. Now there will be. You are effectively adding locking >> over uart_write_wakeup(). >> Again, we

Re: [PATCH] serial: samsung: fix the inconsistency in spinlock

Hi Krzysztof, On 19 February 2016 at 13:57, Krzysztof Kozlowski wrote: > On 19.02.2016 17:23, Anand Moon wrote: >> Hi Krzysztof, >> >> On 19 February 2016 at 13:14, Krzysztof Kozlowski >> wrote: >>> On 19.02.2016 15:51, Anand Moon wrote: Hi

Re: [PATCH] serial: samsung: fix the inconsistency in spinlock

Hi Krzysztof, On 19 February 2016 at 13:57, Krzysztof Kozlowski wrote: > On 19.02.2016 17:23, Anand Moon wrote: >> Hi Krzysztof, >> >> On 19 February 2016 at 13:14, Krzysztof Kozlowski >> wrote: >>> On 19.02.2016 15:51, Anand Moon wrote: Hi Krzysztof, On 19 February 2016 at

Re: [PATCH] serial: samsung: fix the inconsistency in spinlock

On 19.02.2016 17:23, Anand Moon wrote: > Hi Krzysztof, > > On 19 February 2016 at 13:14, Krzysztof Kozlowski > wrote: >> On 19.02.2016 15:51, Anand Moon wrote: >>> Hi Krzysztof, >>> >>> On 19 February 2016 at 11:39, Krzysztof Kozlowski >>>

Re: [PATCH] serial: samsung: fix the inconsistency in spinlock

On 19.02.2016 17:23, Anand Moon wrote: > Hi Krzysztof, > > On 19 February 2016 at 13:14, Krzysztof Kozlowski > wrote: >> On 19.02.2016 15:51, Anand Moon wrote: >>> Hi Krzysztof, >>> >>> On 19 February 2016 at 11:39, Krzysztof Kozlowski >>> wrote: 2016-02-19 4:14 GMT+09:00 Anand Moon :

Re: [PATCH] serial: samsung: fix the inconsistency in spinlock

Hi Krzysztof, On 19 February 2016 at 13:14, Krzysztof Kozlowski wrote: > On 19.02.2016 15:51, Anand Moon wrote: >> Hi Krzysztof, >> >> On 19 February 2016 at 11:39, Krzysztof Kozlowski >> wrote: >>> 2016-02-19 4:14 GMT+09:00 Anand Moon

Re: [PATCH] serial: samsung: fix the inconsistency in spinlock

Hi Krzysztof, On 19 February 2016 at 13:14, Krzysztof Kozlowski wrote: > On 19.02.2016 15:51, Anand Moon wrote: >> Hi Krzysztof, >> >> On 19 February 2016 at 11:39, Krzysztof Kozlowski >> wrote: >>> 2016-02-19 4:14 GMT+09:00 Anand Moon : Hi Peter, On 18 February 2016 at 23:18,

Re: [PATCH] serial: samsung: fix the inconsistency in spinlock

On 19.02.2016 15:51, Anand Moon wrote: > Hi Krzysztof, > > On 19 February 2016 at 11:39, Krzysztof Kozlowski > wrote: >> 2016-02-19 4:14 GMT+09:00 Anand Moon : >>> Hi Peter, >>> >>> On 18 February 2016 at 23:18, Peter Hurley

Re: [PATCH] serial: samsung: fix the inconsistency in spinlock

On 19.02.2016 15:51, Anand Moon wrote: > Hi Krzysztof, > > On 19 February 2016 at 11:39, Krzysztof Kozlowski > wrote: >> 2016-02-19 4:14 GMT+09:00 Anand Moon : >>> Hi Peter, >>> >>> On 18 February 2016 at 23:18, Peter Hurley wrote: Hi Anand, On 02/18/2016 09:40 AM, Anand Moon

Re: [PATCH] serial: samsung: fix the inconsistency in spinlock

Hi Krzysztof, On 19 February 2016 at 11:39, Krzysztof Kozlowski wrote: > 2016-02-19 4:14 GMT+09:00 Anand Moon : >> Hi Peter, >> >> On 18 February 2016 at 23:18, Peter Hurley wrote: >>> Hi Anand, >>> >>> On 02/18/2016

Re: [PATCH] serial: samsung: fix the inconsistency in spinlock

Hi Krzysztof, On 19 February 2016 at 11:39, Krzysztof Kozlowski wrote: > 2016-02-19 4:14 GMT+09:00 Anand Moon : >> Hi Peter, >> >> On 18 February 2016 at 23:18, Peter Hurley wrote: >>> Hi Anand, >>> >>> On 02/18/2016 09:40 AM, Anand Moon wrote: From: Anand Moon changes fix the

Re: [PATCH] serial: samsung: fix the inconsistency in spinlock

2016-02-19 4:14 GMT+09:00 Anand Moon : > Hi Peter, > > On 18 February 2016 at 23:18, Peter Hurley wrote: >> Hi Anand, >> >> On 02/18/2016 09:40 AM, Anand Moon wrote: >>> From: Anand Moon >>> >>> changes fix the correct order

Re: [PATCH] serial: samsung: fix the inconsistency in spinlock

2016-02-19 4:14 GMT+09:00 Anand Moon : > Hi Peter, > > On 18 February 2016 at 23:18, Peter Hurley wrote: >> Hi Anand, >> >> On 02/18/2016 09:40 AM, Anand Moon wrote: >>> From: Anand Moon >>> >>> changes fix the correct order of the spin_lock_irqrestore/save. >>> >>> Signed-off-by: Anand Moon

Re: [PATCH] serial: samsung: fix the inconsistency in spinlock

On 02/18/2016 11:14 AM, Anand Moon wrote: > Thanks for pointing out. > Their is no lock up, just the inconstancy of the spin_lock. > Then I will resend this patch dropping the spin_unlock/spin_lock > around uart_write_wakeup. > Is that ok with you. Yes.

Re: [PATCH] serial: samsung: fix the inconsistency in spinlock

On 02/18/2016 11:14 AM, Anand Moon wrote: > Thanks for pointing out. > Their is no lock up, just the inconstancy of the spin_lock. > Then I will resend this patch dropping the spin_unlock/spin_lock > around uart_write_wakeup. > Is that ok with you. Yes.

Re: [PATCH] serial: samsung: fix the inconsistency in spinlock

Hi Peter, On 18 February 2016 at 23:18, Peter Hurley wrote: > Hi Anand, > > On 02/18/2016 09:40 AM, Anand Moon wrote: >> From: Anand Moon >> >> changes fix the correct order of the spin_lock_irqrestore/save. >> >> Signed-off-by: Anand Moon

Re: [PATCH] serial: samsung: fix the inconsistency in spinlock

Hi Peter, On 18 February 2016 at 23:18, Peter Hurley wrote: > Hi Anand, > > On 02/18/2016 09:40 AM, Anand Moon wrote: >> From: Anand Moon >> >> changes fix the correct order of the spin_lock_irqrestore/save. >> >> Signed-off-by: Anand Moon >> --- >> drivers/tty/serial/samsung.c | 4 ++-- >> 1

Re: [PATCH] serial: samsung: fix the inconsistency in spinlock

Hi Anand, On 02/18/2016 09:40 AM, Anand Moon wrote: > From: Anand Moon > > changes fix the correct order of the spin_lock_irqrestore/save. > > Signed-off-by: Anand Moon > --- > drivers/tty/serial/samsung.c | 4 ++-- > 1 file changed, 2

Re: [PATCH] serial: samsung: fix the inconsistency in spinlock

Hi Anand, On 02/18/2016 09:40 AM, Anand Moon wrote: > From: Anand Moon > > changes fix the correct order of the spin_lock_irqrestore/save. > > Signed-off-by: Anand Moon > --- > drivers/tty/serial/samsung.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git