Re: [PATCH -mm] Add LZO1X compression support to the kernel

2007-06-07 Thread Nitin Gupta
On 6/7/07, Richard Purdie <[EMAIL PROTECTED]> wrote: On Thu, 2007-06-07 at 10:11 +0530, Nitin Gupta wrote: > Your code now looks nice and clean. But I don't know what you want. I > already spent lot of time on version 7 I posted and contains all those > corrections which were suggested for my

Re: [PATCH -mm] Add LZO1X compression support to the kernel

2007-06-07 Thread Richard Purdie
On Thu, 2007-06-07 at 10:11 +0530, Nitin Gupta wrote: > Your code now looks nice and clean. But I don't know what you want. I > already spent lot of time on version 7 I posted and contains all those > corrections which were suggested for my earlier version. I cannot ask > you to look into possible

Re: [PATCH -mm] Add LZO1X compression support to the kernel

2007-06-07 Thread Paul Mundt
On Wed, Jun 06, 2007 at 06:26:32PM +0100, Richard Purdie wrote: > +/* Which machines to allow unaligned accesses on */ > +#if defined(CONFIG_X86_32) || defined(CONFIG_X86_64) > +#define LZO_UNALIGNED_OK_2 > +#define LZO_UNALIGNED_OK_4 > +#endif > + This is silly, just use get/put_unaligned(). This

Re: [PATCH -mm] Add LZO1X compression support to the kernel

2007-06-07 Thread Paul Mundt
On Wed, Jun 06, 2007 at 06:26:32PM +0100, Richard Purdie wrote: +/* Which machines to allow unaligned accesses on */ +#if defined(CONFIG_X86_32) || defined(CONFIG_X86_64) +#define LZO_UNALIGNED_OK_2 +#define LZO_UNALIGNED_OK_4 +#endif + This is silly, just use get/put_unaligned(). This same

Re: [PATCH -mm] Add LZO1X compression support to the kernel

2007-06-07 Thread Richard Purdie
On Thu, 2007-06-07 at 10:11 +0530, Nitin Gupta wrote: Your code now looks nice and clean. But I don't know what you want. I already spent lot of time on version 7 I posted and contains all those corrections which were suggested for my earlier version. I cannot ask you to look into possible

Re: [PATCH -mm] Add LZO1X compression support to the kernel

2007-06-07 Thread Nitin Gupta
On 6/7/07, Richard Purdie [EMAIL PROTECTED] wrote: On Thu, 2007-06-07 at 10:11 +0530, Nitin Gupta wrote: Your code now looks nice and clean. But I don't know what you want. I already spent lot of time on version 7 I posted and contains all those corrections which were suggested for my earlier

Re: [PATCH -mm] Add LZO1X compression support to the kernel

2007-06-06 Thread Nitin Gupta
On 6/6/07, Richard Purdie <[EMAIL PROTECTED]> wrote: Nitin: Have you any objections to this version? If not, I'll finish analysing the PTR_ code changes and then hopefully we can get something into -mm... Your code now looks nice and clean. But I don't know what you want. I already spent

Re: [PATCH -mm] Add LZO1X compression support to the kernel

2007-06-06 Thread Nitin Gupta
On 6/6/07, Richard Purdie [EMAIL PROTECTED] wrote: snip Nitin: Have you any objections to this version? If not, I'll finish analysing the PTR_ code changes and then hopefully we can get something into -mm... Your code now looks nice and clean. But I don't know what you want. I already spent