Re: [PATCH -mm] mm: Fix memory hotplug + sparsemem build.

2007-09-14 Thread Andrew Morton
On Fri, 14 Sep 2007 10:09:27 -0400 Lee Schermerhorn <[EMAIL PROTECTED]> wrote: > I originally sent in the "update-n_high_memory..." patch against > 23-rc3-mm1 on 27aug to fix a problem that I introduced when I moved the > populating of N_HIGH_MEMORY state to free_area_init_nodes(). This would >

Re: [PATCH -mm] mm: Fix memory hotplug + sparsemem build.

2007-09-14 Thread Lee Schermerhorn
On Thu, 2007-09-13 at 19:41 -0700, Andrew Morton wrote: > On Fri, 14 Sep 2007 11:02:43 +0900 Yasunori Goto <[EMAIL PROTECTED]> wrote: > > > > > /* call arch's memory hotadd */ > > > > > > > > > > OK, we're getting into a mess here. This patch fixes > > >

Re: [PATCH -mm] mm: Fix memory hotplug + sparsemem build.

2007-09-14 Thread Lee Schermerhorn
On Thu, 2007-09-13 at 19:41 -0700, Andrew Morton wrote: On Fri, 14 Sep 2007 11:02:43 +0900 Yasunori Goto [EMAIL PROTECTED] wrote: /* call arch's memory hotadd */ OK, we're getting into a mess here. This patch fixes

Re: [PATCH -mm] mm: Fix memory hotplug + sparsemem build.

2007-09-14 Thread Andrew Morton
On Fri, 14 Sep 2007 10:09:27 -0400 Lee Schermerhorn [EMAIL PROTECTED] wrote: I originally sent in the update-n_high_memory... patch against 23-rc3-mm1 on 27aug to fix a problem that I introduced when I moved the populating of N_HIGH_MEMORY state to free_area_init_nodes(). This would miss

Re: [PATCH -mm] mm: Fix memory hotplug + sparsemem build.

2007-09-13 Thread Yasunori Goto
> On Fri, 14 Sep 2007 11:02:43 +0900 Yasunori Goto <[EMAIL PROTECTED]> wrote: > > > > > /* call arch's memory hotadd */ > > > > > > > > > > OK, we're getting into a mess here. This patch fixes > > > update-n_high_memory-node-state-for-memory-hotadd.patch, but which patch > > > does

Re: [PATCH -mm] mm: Fix memory hotplug + sparsemem build.

2007-09-13 Thread Andrew Morton
On Fri, 14 Sep 2007 11:02:43 +0900 Yasunori Goto <[EMAIL PROTECTED]> wrote: > > > /* call arch's memory hotadd */ > > > > > > > OK, we're getting into a mess here. This patch fixes > > update-n_high_memory-node-state-for-memory-hotadd.patch, but which patch > > does

Re: [PATCH -mm] mm: Fix memory hotplug + sparsemem build.

2007-09-13 Thread Yasunori Goto
> On Tue, 11 Sep 2007 18:37:12 +0900 Yasunori Goto <[EMAIL PROTECTED]> wrote: > > > > > > > + if (onlined_pages){ > > > > > > Nit, needs a space there before the '{'. > > > > Ah, Ok. I attached fixed patch in this mail. > > > > > The problem as I see it is that when we boot the system

Re: [PATCH -mm] mm: Fix memory hotplug + sparsemem build.

2007-09-13 Thread Andrew Morton
On Tue, 11 Sep 2007 18:37:12 +0900 Yasunori Goto <[EMAIL PROTECTED]> wrote: > > > > + if (onlined_pages){ > > > > Nit, needs a space there before the '{'. > > Ah, Ok. I attached fixed patch in this mail. > > > The problem as I see it is that when we boot the system we start a > > kswapd on

Re: [PATCH -mm] mm: Fix memory hotplug + sparsemem build.

2007-09-13 Thread Andrew Morton
On Tue, 11 Sep 2007 18:37:12 +0900 Yasunori Goto [EMAIL PROTECTED] wrote: + if (onlined_pages){ Nit, needs a space there before the '{'. Ah, Ok. I attached fixed patch in this mail. The problem as I see it is that when we boot the system we start a kswapd on all nodes with

Re: [PATCH -mm] mm: Fix memory hotplug + sparsemem build.

2007-09-13 Thread Yasunori Goto
On Tue, 11 Sep 2007 18:37:12 +0900 Yasunori Goto [EMAIL PROTECTED] wrote: + if (onlined_pages){ Nit, needs a space there before the '{'. Ah, Ok. I attached fixed patch in this mail. The problem as I see it is that when we boot the system we start a kswapd on

Re: [PATCH -mm] mm: Fix memory hotplug + sparsemem build.

2007-09-13 Thread Andrew Morton
On Fri, 14 Sep 2007 11:02:43 +0900 Yasunori Goto [EMAIL PROTECTED] wrote: /* call arch's memory hotadd */ OK, we're getting into a mess here. This patch fixes update-n_high_memory-node-state-for-memory-hotadd.patch, but which patch does

Re: [PATCH -mm] mm: Fix memory hotplug + sparsemem build.

2007-09-13 Thread Yasunori Goto
On Fri, 14 Sep 2007 11:02:43 +0900 Yasunori Goto [EMAIL PROTECTED] wrote: /* call arch's memory hotadd */ OK, we're getting into a mess here. This patch fixes update-n_high_memory-node-state-for-memory-hotadd.patch, but which patch does

Re: [PATCH -mm] mm: Fix memory hotplug + sparsemem build.

2007-09-11 Thread Yasunori Goto
> > + if (onlined_pages){ > > Nit, needs a space there before the '{'. Ah, Ok. I attached fixed patch in this mail. > The problem as I see it is that when we boot the system we start a > kswapd on all nodes with memory. If the hot-add adds memory to a > pre-existing node with no memory we

Re: [PATCH -mm] mm: Fix memory hotplug + sparsemem build.

2007-09-11 Thread Andy Whitcroft
On Tue, Sep 11, 2007 at 05:18:01PM +0900, Yasunori Goto wrote: > > if (onlined_pages) > > - node_set_state(zone->node, N_HIGH_MEMORY); > > + node_set_state(zone_to_nid(zone), N_HIGH_MEMORY); > > > > setup_per_zone_pages_min(); > > Thanks Paul-san. > > I also have

Re: [PATCH -mm] mm: Fix memory hotplug + sparsemem build.

2007-09-11 Thread Paul Mundt
Hi Goto-san, On Tue, Sep 11, 2007 at 05:18:01PM +0900, Yasunori Goto wrote: > > if (onlined_pages) > > - node_set_state(zone->node, N_HIGH_MEMORY); > > + node_set_state(zone_to_nid(zone), N_HIGH_MEMORY); > > > > setup_per_zone_pages_min(); > > Thanks Paul-san. > >

Re: [PATCH -mm] mm: Fix memory hotplug + sparsemem build.

2007-09-11 Thread Yasunori Goto
> if (onlined_pages) > - node_set_state(zone->node, N_HIGH_MEMORY); > + node_set_state(zone_to_nid(zone), N_HIGH_MEMORY); > > setup_per_zone_pages_min(); Thanks Paul-san. I also have another issue around here. (Kswapd doesn't run on memory less node now. It

Re: [PATCH -mm] mm: Fix memory hotplug + sparsemem build.

2007-09-11 Thread Yasunori Goto
if (onlined_pages) - node_set_state(zone-node, N_HIGH_MEMORY); + node_set_state(zone_to_nid(zone), N_HIGH_MEMORY); setup_per_zone_pages_min(); Thanks Paul-san. I also have another issue around here. (Kswapd doesn't run on memory less node now. It

Re: [PATCH -mm] mm: Fix memory hotplug + sparsemem build.

2007-09-11 Thread Paul Mundt
Hi Goto-san, On Tue, Sep 11, 2007 at 05:18:01PM +0900, Yasunori Goto wrote: if (onlined_pages) - node_set_state(zone-node, N_HIGH_MEMORY); + node_set_state(zone_to_nid(zone), N_HIGH_MEMORY); setup_per_zone_pages_min(); Thanks Paul-san. I also have

Re: [PATCH -mm] mm: Fix memory hotplug + sparsemem build.

2007-09-11 Thread Andy Whitcroft
On Tue, Sep 11, 2007 at 05:18:01PM +0900, Yasunori Goto wrote: if (onlined_pages) - node_set_state(zone-node, N_HIGH_MEMORY); + node_set_state(zone_to_nid(zone), N_HIGH_MEMORY); setup_per_zone_pages_min(); Thanks Paul-san. I also have another issue

Re: [PATCH -mm] mm: Fix memory hotplug + sparsemem build.

2007-09-11 Thread Yasunori Goto
+ if (onlined_pages){ Nit, needs a space there before the '{'. Ah, Ok. I attached fixed patch in this mail. The problem as I see it is that when we boot the system we start a kswapd on all nodes with memory. If the hot-add adds memory to a pre-existing node with no memory we will not