Re: [PATCH 0/3] dynamic_hex_dump cleanup

On Fri, Apr 28, 2017 at 4:04 PM, Joe Perches wrote: > On Fri, 2017-04-28 at 15:59 -0700, Dan Williams wrote: >> ...but again, hex_dump_dbg() implies to me dev_dbg() behavior, i.e. >> that the hexdump happens in the KERN_DEBUG case > > I think you are confusing KERN_DEBUG, a

Re: [PATCH 0/3] dynamic_hex_dump cleanup

On Fri, Apr 28, 2017 at 4:04 PM, Joe Perches wrote: > On Fri, 2017-04-28 at 15:59 -0700, Dan Williams wrote: >> ...but again, hex_dump_dbg() implies to me dev_dbg() behavior, i.e. >> that the hexdump happens in the KERN_DEBUG case > > I think you are confusing KERN_DEBUG, a logging level, with a

Re: [PATCH 0/3] dynamic_hex_dump cleanup

On Fri, 2017-04-28 at 15:59 -0700, Dan Williams wrote: > ...but again, hex_dump_dbg() implies to me dev_dbg() behavior, i.e. > that the hexdump happens in the KERN_DEBUG case I think you are confusing KERN_DEBUG, a logging level, with a preprocessor #define of DEBUG. > which I don't want. I >

Re: [PATCH 0/3] dynamic_hex_dump cleanup

On Fri, 2017-04-28 at 15:59 -0700, Dan Williams wrote: > ...but again, hex_dump_dbg() implies to me dev_dbg() behavior, i.e. > that the hexdump happens in the KERN_DEBUG case I think you are confusing KERN_DEBUG, a logging level, with a preprocessor #define of DEBUG. > which I don't want. I >

Re: [PATCH 0/3] dynamic_hex_dump cleanup

On Fri, Apr 28, 2017 at 3:31 PM, Joe Perches wrote: > On Fri, 2017-04-28 at 15:19 -0700, Dan Williams wrote: >> On Fri, Apr 28, 2017 at 3:14 PM, Dan Williams >> wrote: >> > On Fri, Apr 28, 2017 at 3:07 PM, Joe Perches wrote: >> > >

Re: [PATCH 0/3] dynamic_hex_dump cleanup

On Fri, Apr 28, 2017 at 3:31 PM, Joe Perches wrote: > On Fri, 2017-04-28 at 15:19 -0700, Dan Williams wrote: >> On Fri, Apr 28, 2017 at 3:14 PM, Dan Williams >> wrote: >> > On Fri, Apr 28, 2017 at 3:07 PM, Joe Perches wrote: >> > > On Fri, 2017-04-28 at 14:52 -0700, Dan Williams wrote: >> > >

Re: [PATCH 0/3] dynamic_hex_dump cleanup

On Fri, 2017-04-28 at 15:19 -0700, Dan Williams wrote: > On Fri, Apr 28, 2017 at 3:14 PM, Dan Williams > wrote: > > On Fri, Apr 28, 2017 at 3:07 PM, Joe Perches wrote: > > > On Fri, 2017-04-28 at 14:52 -0700, Dan Williams wrote: > > > > On Fri, Apr

Re: [PATCH 0/3] dynamic_hex_dump cleanup

On Fri, 2017-04-28 at 15:19 -0700, Dan Williams wrote: > On Fri, Apr 28, 2017 at 3:14 PM, Dan Williams > wrote: > > On Fri, Apr 28, 2017 at 3:07 PM, Joe Perches wrote: > > > On Fri, 2017-04-28 at 14:52 -0700, Dan Williams wrote: > > > > On Fri, Apr 28, 2017 at 2:49 PM, Joe Perches wrote: > > >

Re: [PATCH 0/3] dynamic_hex_dump cleanup

On Fri, Apr 28, 2017 at 3:14 PM, Dan Williams wrote: > On Fri, Apr 28, 2017 at 3:07 PM, Joe Perches wrote: >> On Fri, 2017-04-28 at 14:52 -0700, Dan Williams wrote: >>> On Fri, Apr 28, 2017 at 2:49 PM, Joe Perches wrote: >>> > On

Re: [PATCH 0/3] dynamic_hex_dump cleanup

On Fri, Apr 28, 2017 at 3:14 PM, Dan Williams wrote: > On Fri, Apr 28, 2017 at 3:07 PM, Joe Perches wrote: >> On Fri, 2017-04-28 at 14:52 -0700, Dan Williams wrote: >>> On Fri, Apr 28, 2017 at 2:49 PM, Joe Perches wrote: >>> > On Fri, 2017-04-28 at 14:28 -0700, Dan Williams wrote: >>> > > More

Re: [PATCH 0/3] dynamic_hex_dump cleanup

On Fri, Apr 28, 2017 at 3:07 PM, Joe Perches wrote: > On Fri, 2017-04-28 at 14:52 -0700, Dan Williams wrote: >> On Fri, Apr 28, 2017 at 2:49 PM, Joe Perches wrote: >> > On Fri, 2017-04-28 at 14:28 -0700, Dan Williams wrote: >> > > More than one driver has

Re: [PATCH 0/3] dynamic_hex_dump cleanup

On Fri, Apr 28, 2017 at 3:07 PM, Joe Perches wrote: > On Fri, 2017-04-28 at 14:52 -0700, Dan Williams wrote: >> On Fri, Apr 28, 2017 at 2:49 PM, Joe Perches wrote: >> > On Fri, 2017-04-28 at 14:28 -0700, Dan Williams wrote: >> > > More than one driver has worked around the fact that >> > >

Re: [PATCH 0/3] dynamic_hex_dump cleanup

On Fri, 2017-04-28 at 14:52 -0700, Dan Williams wrote: > On Fri, Apr 28, 2017 at 2:49 PM, Joe Perches wrote: > > On Fri, 2017-04-28 at 14:28 -0700, Dan Williams wrote: > > > More than one driver has worked around the fact that > > > print_hex_dump_debug() requires

Re: [PATCH 0/3] dynamic_hex_dump cleanup

On Fri, 2017-04-28 at 14:52 -0700, Dan Williams wrote: > On Fri, Apr 28, 2017 at 2:49 PM, Joe Perches wrote: > > On Fri, 2017-04-28 at 14:28 -0700, Dan Williams wrote: > > > More than one driver has worked around the fact that > > > print_hex_dump_debug() requires CONFIG_DYNAMIC_DEBUG=y to build.

Re: [PATCH 0/3] dynamic_hex_dump cleanup

On Fri, Apr 28, 2017 at 2:49 PM, Joe Perches wrote: > On Fri, 2017-04-28 at 14:28 -0700, Dan Williams wrote: >> More than one driver has worked around the fact that >> print_hex_dump_debug() requires CONFIG_DYNAMIC_DEBUG=y to build. > > No it doesn't. builds work fine. Output

Re: [PATCH 0/3] dynamic_hex_dump cleanup

On Fri, Apr 28, 2017 at 2:49 PM, Joe Perches wrote: > On Fri, 2017-04-28 at 14:28 -0700, Dan Williams wrote: >> More than one driver has worked around the fact that >> print_hex_dump_debug() requires CONFIG_DYNAMIC_DEBUG=y to build. > > No it doesn't. builds work fine. Output is restricted. >

Re: [PATCH 0/3] dynamic_hex_dump cleanup

On Fri, 2017-04-28 at 14:28 -0700, Dan Williams wrote: > More than one driver has worked around the fact that > print_hex_dump_debug() requires CONFIG_DYNAMIC_DEBUG=y to build. No it doesn't. builds work fine. Output is restricted. > Provide a dynamic_hex_dump() so that drivers that want the

Re: [PATCH 0/3] dynamic_hex_dump cleanup

On Fri, 2017-04-28 at 14:28 -0700, Dan Williams wrote: > More than one driver has worked around the fact that > print_hex_dump_debug() requires CONFIG_DYNAMIC_DEBUG=y to build. No it doesn't. builds work fine. Output is restricted. > Provide a dynamic_hex_dump() so that drivers that want the