On Thu, Apr 15, 2021 at 12:57 AM Andrii Nakryiko
wrote:
>
> On Wed, Apr 14, 2021 at 2:46 AM Florent Revest wrote:
> >
> > On Wed, Apr 14, 2021 at 1:16 AM Andrii Nakryiko
> > wrote:
> > > On Mon, Apr 12, 2021 at 8:38 AM Florent Revest
> > > wrote:
> > > > +
> > > > + return err + 1;
> >
Hi Andrii,
On Thu, Apr 15, 2021 at 12:58 AM Andrii Nakryiko
wrote:
> On Wed, Apr 14, 2021 at 11:30 AM Florent Revest wrote:
> > On Wed, Apr 14, 2021 at 8:02 PM Geert Uytterhoeven
> > wrote:
> > > On Wed, Apr 14, 2021 at 9:41 AM Andrii Nakryiko
> > > wrote:
> > > > On Mon, Apr 12, 2021 at
On Wed, Apr 14, 2021 at 11:30 AM Florent Revest wrote:
>
> Hey Geert! :)
>
> On Wed, Apr 14, 2021 at 8:02 PM Geert Uytterhoeven
> wrote:
> > On Wed, Apr 14, 2021 at 9:41 AM Andrii Nakryiko
> > wrote:
> > > On Mon, Apr 12, 2021 at 8:38 AM Florent Revest
> > > wrote:
> > > > + fmt =
On Wed, Apr 14, 2021 at 2:46 AM Florent Revest wrote:
>
> On Wed, Apr 14, 2021 at 1:16 AM Andrii Nakryiko
> wrote:
> > On Mon, Apr 12, 2021 at 8:38 AM Florent Revest wrote:
> > > +static int check_bpf_snprintf_call(struct bpf_verifier_env *env,
> > > + struct
Hey Geert! :)
On Wed, Apr 14, 2021 at 8:02 PM Geert Uytterhoeven wrote:
> On Wed, Apr 14, 2021 at 9:41 AM Andrii Nakryiko
> wrote:
> > On Mon, Apr 12, 2021 at 8:38 AM Florent Revest wrote:
> > > + fmt = (char *)fmt_addr + fmt_map_off;
> > > +
> >
> > bot complained about lack of (long)
Hi Andrii,
On Wed, Apr 14, 2021 at 9:41 AM Andrii Nakryiko
wrote:
> On Mon, Apr 12, 2021 at 8:38 AM Florent Revest wrote:
> > The implementation takes inspiration from the existing bpf_trace_printk
> > helper but there are a few differences:
> >
> > To allow for a large number of
On Mon, Apr 12, 2021 at 10:32 PM kernel test robot wrote:
>m68k-linux-ld: kernel/bpf/verifier.o: in function
> `check_helper_call.isra.0':
> >> verifier.c:(.text+0xf79e): undefined reference to `bpf_printf_prepare'
>m68k-linux-ld: kernel/bpf/helpers.o: in function `bpf_base_func_proto':
On Wed, Apr 14, 2021 at 1:16 AM Andrii Nakryiko
wrote:
> On Mon, Apr 12, 2021 at 8:38 AM Florent Revest wrote:
> > +static int check_bpf_snprintf_call(struct bpf_verifier_env *env,
> > + struct bpf_reg_state *regs)
> > +{
> > + struct bpf_reg_state *fmt_reg
On Mon, Apr 12, 2021 at 8:38 AM Florent Revest wrote:
>
> The implementation takes inspiration from the existing bpf_trace_printk
> helper but there are a few differences:
>
> To allow for a large number of format-specifiers, parameters are
> provided in an array, like in bpf_seq_printf.
>
>
Hi Florent,
I love your patch! Yet something to improve:
[auto build test ERROR on bpf-next/master]
url:
https://github.com/0day-ci/linux/commits/Florent-Revest/Add-a-snprintf-eBPF-helper/20210412-233921
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config:
Hi Florent,
I love your patch! Yet something to improve:
[auto build test ERROR on bpf-next/master]
url:
https://github.com/0day-ci/linux/commits/Florent-Revest/Add-a-snprintf-eBPF-helper/20210412-233921
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config:
Hi Florent,
I love your patch! Perhaps something to improve:
[auto build test WARNING on bpf-next/master]
url:
https://github.com/0day-ci/linux/commits/Florent-Revest/Add-a-snprintf-eBPF-helper/20210412-233921
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
12 matches
Mail list logo
