Re: [PATCH net-next 17/18] net: dsa: mv88e6xxx: support the VTU Page bit

> That's not a big deal though, one can make it clearer later if needed. Agreed. Lets keep it as is. Andrew

Re: [PATCH net-next 17/18] net: dsa: mv88e6xxx: support the VTU Page bit

> That's not a big deal though, one can make it clearer later if needed. Agreed. Lets keep it as is. Andrew

Re: [PATCH net-next 17/18] net: dsa: mv88e6xxx: support the VTU Page bit

Hi Andrew, Andrew Lunn writes: >> +if (val & GLOBAL_VTU_VID_PAGE) >> +entry->vid |= 0x1000; > > I'm undecided myself, so i will just bring it up for discussion. > > Maybe it would be more readable to say: > > entry->vid += 4096; > > ??? VID values

Re: [PATCH net-next 17/18] net: dsa: mv88e6xxx: support the VTU Page bit

Hi Andrew, Andrew Lunn writes: >> +if (val & GLOBAL_VTU_VID_PAGE) >> +entry->vid |= 0x1000; > > I'm undecided myself, so i will just bring it up for discussion. > > Maybe it would be more readable to say: > > entry->vid += 4096; > > ??? VID values are usually

Re: [PATCH net-next 17/18] net: dsa: mv88e6xxx: support the VTU Page bit

On Wed, Apr 26, 2017 at 11:53:35AM -0400, Vivien Didelot wrote: > Newer chips such as the 88E6390 have a VTU Page bit in the VTU VID > register to specify a 13th bit for the VID. This can be used to support > 8K VLANs. Hi Vivien At the moment, this code appears to be generic to all chips. Do we

Re: [PATCH net-next 17/18] net: dsa: mv88e6xxx: support the VTU Page bit

On Wed, Apr 26, 2017 at 11:53:35AM -0400, Vivien Didelot wrote: > Newer chips such as the 88E6390 have a VTU Page bit in the VTU VID > register to specify a 13th bit for the VID. This can be used to support > 8K VLANs. Hi Vivien At the moment, this code appears to be generic to all chips. Do we