Re: [PATCH v12 2/7] mm: factor helpers for memory_failure_dev_pagemap

2022-04-11 Thread Shiyang Ruan
在 2022/4/11 14:37, Christoph Hellwig 写道: + unmap_and_kill(_kill, pfn, page->mapping, page->index, flags); +unlock: + dax_unlock_page(page, cookie); + return 0; As the buildbot points out this should probably be a "return rc". Yes, my mistake, when resolving the conflict

Re: [PATCH v12 2/7] mm: factor helpers for memory_failure_dev_pagemap

2022-04-11 Thread Christoph Hellwig
> + unmap_and_kill(_kill, pfn, page->mapping, page->index, flags); > +unlock: > + dax_unlock_page(page, cookie); > + return 0; As the buildbot points out this should probably be a "return rc".

Re: [PATCH v12 2/7] mm: factor helpers for memory_failure_dev_pagemap

2022-04-10 Thread kernel test robot
Hi Shiyang, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on hnaz-mm/master] [also build test WARNING on next-20220408] [cannot apply to xfs-linux/for-next linus/master linux/master v5.18-rc1] [If your patch is applied to the wrong git tree, kindly drop us a

Re: [PATCH v12 2/7] mm: factor helpers for memory_failure_dev_pagemap

2022-04-10 Thread kernel test robot
Hi Shiyang, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on hnaz-mm/master] [also build test WARNING on next-20220408] [cannot apply to xfs-linux/for-next linus/master linux/master v5.18-rc1] [If your patch is applied to the wrong git tree, kindly drop us a