Re: [PATCH v2] ADP1653 board code for Nokia RX-51

2013-09-23 Thread Pavel Machek
Hi! > > > > Right. So Tony, will you accept future patches for board files? > > > > > > Only fixes to board-*.c files please unless there's a _really_ > > > good reason to make things more complex with the platform data. > > > Let's not make the DT conversion any more complex than it > > >

Re: [PATCH v2] ADP1653 board code for Nokia RX-51

2013-09-23 Thread Tony Lindgren
* Pavel Machek [130921 05:45]: > Hi! > > > > > > > > --- /dev/null > > > > > > > +++ b/arch/arm/mach-omap2/board-rx51-camera.c > > > > > > > > > > [...] > > > > > > > > > > > Ping, can you review this patch v2? > > > > > > > > > > I don't think Tony will accept any new board stuff for > > > >

Re: [PATCH v2] ADP1653 board code for Nokia RX-51

2013-09-23 Thread Tony Lindgren
* Pavel Machek pa...@ucw.cz [130921 05:45]: Hi! --- /dev/null +++ b/arch/arm/mach-omap2/board-rx51-camera.c [...] Ping, can you review this patch v2? I don't think Tony will accept any new board stuff for RX-51/N900. See for example:

Re: [PATCH v2] ADP1653 board code for Nokia RX-51

2013-09-23 Thread Pavel Machek
Hi! Right. So Tony, will you accept future patches for board files? Only fixes to board-*.c files please unless there's a _really_ good reason to make things more complex with the platform data. Let's not make the DT conversion any more complex than it already is.

Re: [PATCH v2] ADP1653 board code for Nokia RX-51

2013-09-21 Thread Pavel Machek
Hi! > > > > > > --- /dev/null > > > > > > +++ b/arch/arm/mach-omap2/board-rx51-camera.c > > > > > > > > [...] > > > > > > > > > Ping, can you review this patch v2? > > > > > > > > I don't think Tony will accept any new board stuff for > > > > RX-51/N900. See for example: > > > >

Re: [PATCH v2] ADP1653 board code for Nokia RX-51

2013-09-21 Thread Pavel Machek
Hi! --- /dev/null +++ b/arch/arm/mach-omap2/board-rx51-camera.c [...] Ping, can you review this patch v2? I don't think Tony will accept any new board stuff for RX-51/N900. See for example: http://marc.info/?l=linux-kernelm=137629626213187w=2

Re: [PATCH v2] ADP1653 board code for Nokia RX-51

2013-09-20 Thread Tony Lindgren
* Pali Rohár [130919 15:38]: > On Wednesday 18 September 2013 19:42:12 Tony Lindgren wrote: > > * Pali Rohár [130918 09:08]: > > > On Wednesday 18 September 2013 15:16:44 Pavel Machek wrote: > > > > On Sun 2013-09-08 02:02:52, Aaro Koskinen wrote: > > > > > Hi, > > > > > > > > > > On Fri, Sep

Re: [PATCH v2] ADP1653 board code for Nokia RX-51

2013-09-20 Thread Tony Lindgren
* Pali Rohár pali.ro...@gmail.com [130919 15:38]: On Wednesday 18 September 2013 19:42:12 Tony Lindgren wrote: * Pali Rohár pali.ro...@gmail.com [130918 09:08]: On Wednesday 18 September 2013 15:16:44 Pavel Machek wrote: On Sun 2013-09-08 02:02:52, Aaro Koskinen wrote: Hi,

Re: [PATCH v2] ADP1653 board code for Nokia RX-51

2013-09-19 Thread Pali Rohár
On Wednesday 18 September 2013 19:42:12 Tony Lindgren wrote: > * Pali Rohár [130918 09:08]: > > On Wednesday 18 September 2013 15:16:44 Pavel Machek wrote: > > > On Sun 2013-09-08 02:02:52, Aaro Koskinen wrote: > > > > Hi, > > > > > > > > On Fri, Sep 06, 2013 at 10:34:05PM +0200, Pali Rohár

Re: [PATCH v2] ADP1653 board code for Nokia RX-51

2013-09-19 Thread Pali Rohár
On Wednesday 18 September 2013 19:42:12 Tony Lindgren wrote: * Pali Rohár pali.ro...@gmail.com [130918 09:08]: On Wednesday 18 September 2013 15:16:44 Pavel Machek wrote: On Sun 2013-09-08 02:02:52, Aaro Koskinen wrote: Hi, On Fri, Sep 06, 2013 at 10:34:05PM +0200, Pali Rohár

Re: [PATCH v2] ADP1653 board code for Nokia RX-51

2013-09-18 Thread Tony Lindgren
* Javier Martinez Canillas [130918 07:20]: > > Hi Tony, > > I don't know if OMAP2+ DT will happen soon as you said. At least I > know about a big issue we had with GPIO pins not being auto-requested > when are mapped as IRQ. You can refer to [1] for the latest approach > and how this discussion

Re: [PATCH v2] ADP1653 board code for Nokia RX-51

2013-09-18 Thread Tony Lindgren
* Pali Rohár [130918 09:08]: > On Wednesday 18 September 2013 15:16:44 Pavel Machek wrote: > > On Sun 2013-09-08 02:02:52, Aaro Koskinen wrote: > > > Hi, > > > > > > On Fri, Sep 06, 2013 at 10:34:05PM +0200, Pali Rohár wrote: > > > > > --- /dev/null > > > > > +++

Re: [PATCH v2] ADP1653 board code for Nokia RX-51

2013-09-18 Thread Pali Rohár
On Wednesday 18 September 2013 15:16:44 Pavel Machek wrote: > On Sun 2013-09-08 02:02:52, Aaro Koskinen wrote: > > Hi, > > > > On Fri, Sep 06, 2013 at 10:34:05PM +0200, Pali Rohár wrote: > > > > --- /dev/null > > > > +++ b/arch/arm/mach-omap2/board-rx51-camera.c > > > > [...] > > > > > Ping,

Re: [PATCH v2] ADP1653 board code for Nokia RX-51

2013-09-18 Thread Javier Martinez Canillas
On Wed, Sep 18, 2013 at 1:50 AM, Tony Lindgren wrote: > * Aaro Koskinen [130907 16:10]: >> Hi, >> >> On Fri, Sep 06, 2013 at 10:34:05PM +0200, Pali Rohár wrote: >> > > --- /dev/null >> > > +++ b/arch/arm/mach-omap2/board-rx51-camera.c >> [...] >> > Ping, can you review this patch v2? >> >> I

Re: [PATCH v2] ADP1653 board code for Nokia RX-51

2013-09-18 Thread Pavel Machek
On Sun 2013-09-08 02:02:52, Aaro Koskinen wrote: > Hi, > > On Fri, Sep 06, 2013 at 10:34:05PM +0200, Pali Rohár wrote: > > > --- /dev/null > > > +++ b/arch/arm/mach-omap2/board-rx51-camera.c > [...] > > Ping, can you review this patch v2? > > I don't think Tony will accept any new board stuff

Re: [PATCH v2] ADP1653 board code for Nokia RX-51

2013-09-18 Thread Pavel Machek
On Sun 2013-09-08 02:02:52, Aaro Koskinen wrote: Hi, On Fri, Sep 06, 2013 at 10:34:05PM +0200, Pali Rohár wrote: --- /dev/null +++ b/arch/arm/mach-omap2/board-rx51-camera.c [...] Ping, can you review this patch v2? I don't think Tony will accept any new board stuff for RX-51/N900.

Re: [PATCH v2] ADP1653 board code for Nokia RX-51

2013-09-18 Thread Javier Martinez Canillas
On Wed, Sep 18, 2013 at 1:50 AM, Tony Lindgren t...@atomide.com wrote: * Aaro Koskinen aaro.koski...@iki.fi [130907 16:10]: Hi, On Fri, Sep 06, 2013 at 10:34:05PM +0200, Pali Rohár wrote: --- /dev/null +++ b/arch/arm/mach-omap2/board-rx51-camera.c [...] Ping, can you review this patch

Re: [PATCH v2] ADP1653 board code for Nokia RX-51

2013-09-18 Thread Pali Rohár
On Wednesday 18 September 2013 15:16:44 Pavel Machek wrote: On Sun 2013-09-08 02:02:52, Aaro Koskinen wrote: Hi, On Fri, Sep 06, 2013 at 10:34:05PM +0200, Pali Rohár wrote: --- /dev/null +++ b/arch/arm/mach-omap2/board-rx51-camera.c [...] Ping, can you review this patch

Re: [PATCH v2] ADP1653 board code for Nokia RX-51

2013-09-18 Thread Tony Lindgren
* Pali Rohár pali.ro...@gmail.com [130918 09:08]: On Wednesday 18 September 2013 15:16:44 Pavel Machek wrote: On Sun 2013-09-08 02:02:52, Aaro Koskinen wrote: Hi, On Fri, Sep 06, 2013 at 10:34:05PM +0200, Pali Rohár wrote: --- /dev/null +++

Re: [PATCH v2] ADP1653 board code for Nokia RX-51

2013-09-18 Thread Tony Lindgren
* Javier Martinez Canillas martinez.jav...@gmail.com [130918 07:20]: Hi Tony, I don't know if OMAP2+ DT will happen soon as you said. At least I know about a big issue we had with GPIO pins not being auto-requested when are mapped as IRQ. You can refer to [1] for the latest approach and

Re: [PATCH v2] ADP1653 board code for Nokia RX-51

2013-09-17 Thread Tony Lindgren
* Aaro Koskinen [130907 16:10]: > Hi, > > On Fri, Sep 06, 2013 at 10:34:05PM +0200, Pali Rohár wrote: > > > --- /dev/null > > > +++ b/arch/arm/mach-omap2/board-rx51-camera.c > [...] > > Ping, can you review this patch v2? > > I don't think Tony will accept any new board stuff for RX-51/N900. >

Re: [PATCH v2] ADP1653 board code for Nokia RX-51

2013-09-17 Thread Tony Lindgren
* Aaro Koskinen aaro.koski...@iki.fi [130907 16:10]: Hi, On Fri, Sep 06, 2013 at 10:34:05PM +0200, Pali Rohár wrote: --- /dev/null +++ b/arch/arm/mach-omap2/board-rx51-camera.c [...] Ping, can you review this patch v2? I don't think Tony will accept any new board stuff for

Re: [PATCH v2] ADP1653 board code for Nokia RX-51

2013-09-07 Thread Aaro Koskinen
Hi, On Fri, Sep 06, 2013 at 10:34:05PM +0200, Pali Rohár wrote: > > --- /dev/null > > +++ b/arch/arm/mach-omap2/board-rx51-camera.c [...] > Ping, can you review this patch v2? I don't think Tony will accept any new board stuff for RX-51/N900. See for example:

Re: [PATCH v2] ADP1653 board code for Nokia RX-51

2013-09-07 Thread Aaro Koskinen
Hi, On Fri, Sep 06, 2013 at 10:34:05PM +0200, Pali Rohár wrote: --- /dev/null +++ b/arch/arm/mach-omap2/board-rx51-camera.c [...] Ping, can you review this patch v2? I don't think Tony will accept any new board stuff for RX-51/N900. See for example:

Re: [PATCH v2] ADP1653 board code for Nokia RX-51

2013-09-06 Thread Pali Rohár
On Wednesday 06 March 2013 21:12:06 Pali Rohár wrote: > On Sunday 17 February 2013 20:03:03 Aaro Koskinen wrote: > > Hi, > > > > On Sun, Feb 17, 2013 at 04:16:49PM +0100, Pali Rohár wrote: > > > I'm sending ADP1653 flash torch board code for Nokia > > > RX-51. Kernel driver ADP1653 is already in

Re: [PATCH v2] ADP1653 board code for Nokia RX-51

2013-09-06 Thread Pali Rohár
On Wednesday 06 March 2013 21:12:06 Pali Rohár wrote: On Sunday 17 February 2013 20:03:03 Aaro Koskinen wrote: Hi, On Sun, Feb 17, 2013 at 04:16:49PM +0100, Pali Rohár wrote: I'm sending ADP1653 flash torch board code for Nokia RX-51. Kernel driver ADP1653 is already in upstream

Re: [PATCH v2] ADP1653 board code for Nokia RX-51

2013-04-04 Thread Laurent Pinchart
Hi Sakari, On Thursday 04 April 2013 01:22:28 Sakari Ailus wrote: > On Tue, Mar 26, 2013 at 12:07:01AM +0100, Laurent Pinchart wrote: > > On Sunday 24 March 2013 23:46:01 Sakari Ailus wrote: > > > Pali Rohár wrote: > > > > On Thursday 07 March 2013 23:18:27 Sakari Ailus wrote: > > > >> On Wed,

Re: [PATCH v2] ADP1653 board code for Nokia RX-51

2013-04-04 Thread Laurent Pinchart
Hi Sakari, On Thursday 04 April 2013 01:22:28 Sakari Ailus wrote: On Tue, Mar 26, 2013 at 12:07:01AM +0100, Laurent Pinchart wrote: On Sunday 24 March 2013 23:46:01 Sakari Ailus wrote: Pali Rohár wrote: On Thursday 07 March 2013 23:18:27 Sakari Ailus wrote: On Wed, Mar 06, 2013 at

Re: [PATCH v2] ADP1653 board code for Nokia RX-51

2013-04-03 Thread Sakari Ailus
Hi Laurent, On Tue, Mar 26, 2013 at 12:07:01AM +0100, Laurent Pinchart wrote: > On Sunday 24 March 2013 23:46:01 Sakari Ailus wrote: > > Pali Rohár wrote: > > > On Thursday 07 March 2013 23:18:27 Sakari Ailus wrote: > > >> On Wed, Mar 06, 2013 at 10:44:41PM +0100, Sebastian Reichel wrote: > > >>>

Re: [PATCH v2] ADP1653 board code for Nokia RX-51

2013-04-03 Thread Sakari Ailus
Hi Laurent, On Tue, Mar 26, 2013 at 12:07:01AM +0100, Laurent Pinchart wrote: On Sunday 24 March 2013 23:46:01 Sakari Ailus wrote: Pali Rohár wrote: On Thursday 07 March 2013 23:18:27 Sakari Ailus wrote: On Wed, Mar 06, 2013 at 10:44:41PM +0100, Sebastian Reichel wrote: On Wed, Mar

Re: [PATCH v2] ADP1653 board code for Nokia RX-51

2013-03-25 Thread Laurent Pinchart
Hi Sakari, On Sunday 24 March 2013 23:46:01 Sakari Ailus wrote: > Pali Rohár wrote: > > On Thursday 07 March 2013 23:18:27 Sakari Ailus wrote: > >> On Wed, Mar 06, 2013 at 10:44:41PM +0100, Sebastian Reichel wrote: > >>> On Wed, Mar 06, 2013 at 09:20:16PM +0100, Pali Rohár wrote: > On

Re: [PATCH v2] ADP1653 board code for Nokia RX-51

2013-03-25 Thread Laurent Pinchart
Hi Sakari, On Sunday 24 March 2013 23:46:01 Sakari Ailus wrote: Pali Rohár wrote: On Thursday 07 March 2013 23:18:27 Sakari Ailus wrote: On Wed, Mar 06, 2013 at 10:44:41PM +0100, Sebastian Reichel wrote: On Wed, Mar 06, 2013 at 09:20:16PM +0100, Pali Rohár wrote: On Wednesday 06 March

Re: [PATCH v2] ADP1653 board code for Nokia RX-51

2013-03-24 Thread Sakari Ailus
Hi Pali, Pali Rohár wrote: > On Thursday 07 March 2013 23:18:27 Sakari Ailus wrote: >> Hi guys, >> >> On Wed, Mar 06, 2013 at 10:44:41PM +0100, Sebastian Reichel > wrote: >>> On Wed, Mar 06, 2013 at 09:20:16PM +0100, Pali Rohár wrote: On Wednesday 06 March 2013 21:12:06 Pali Rohár wrote:

Re: [PATCH v2] ADP1653 board code for Nokia RX-51

2013-03-24 Thread Pali Rohár
On Thursday 07 March 2013 23:18:27 Sakari Ailus wrote: > Hi guys, > > On Wed, Mar 06, 2013 at 10:44:41PM +0100, Sebastian Reichel wrote: > > On Wed, Mar 06, 2013 at 09:20:16PM +0100, Pali Rohár wrote: > > > On Wednesday 06 March 2013 21:12:06 Pali Rohár wrote: > > > > On Sunday 17 February 2013

Re: [PATCH v2] ADP1653 board code for Nokia RX-51

2013-03-24 Thread Pali Rohár
On Thursday 07 March 2013 23:18:27 Sakari Ailus wrote: Hi guys, On Wed, Mar 06, 2013 at 10:44:41PM +0100, Sebastian Reichel wrote: On Wed, Mar 06, 2013 at 09:20:16PM +0100, Pali Rohár wrote: On Wednesday 06 March 2013 21:12:06 Pali Rohár wrote: On Sunday 17 February 2013 20:03:03

Re: [PATCH v2] ADP1653 board code for Nokia RX-51

2013-03-24 Thread Sakari Ailus
Hi Pali, Pali Rohár wrote: On Thursday 07 March 2013 23:18:27 Sakari Ailus wrote: Hi guys, On Wed, Mar 06, 2013 at 10:44:41PM +0100, Sebastian Reichel wrote: On Wed, Mar 06, 2013 at 09:20:16PM +0100, Pali Rohár wrote: On Wednesday 06 March 2013 21:12:06 Pali Rohár wrote: On Sunday 17

Re: [PATCH v2] ADP1653 board code for Nokia RX-51

2013-03-07 Thread Sakari Ailus
Hi guys, On Wed, Mar 06, 2013 at 10:44:41PM +0100, Sebastian Reichel wrote: > On Wed, Mar 06, 2013 at 09:20:16PM +0100, Pali Rohár wrote: > > On Wednesday 06 March 2013 21:12:06 Pali Rohár wrote: > > > On Sunday 17 February 2013 20:03:03 Aaro Koskinen wrote: > > > > On Sun, Feb 17, 2013 at

Re: [PATCH v2] ADP1653 board code for Nokia RX-51

2013-03-07 Thread Sakari Ailus
Hi guys, On Wed, Mar 06, 2013 at 10:44:41PM +0100, Sebastian Reichel wrote: On Wed, Mar 06, 2013 at 09:20:16PM +0100, Pali Rohár wrote: On Wednesday 06 March 2013 21:12:06 Pali Rohár wrote: On Sunday 17 February 2013 20:03:03 Aaro Koskinen wrote: On Sun, Feb 17, 2013 at 04:16:49PM

Re: [PATCH v2] ADP1653 board code for Nokia RX-51

2013-03-06 Thread Sebastian Reichel
On Wed, Mar 06, 2013 at 09:20:16PM +0100, Pali Rohár wrote: > On Wednesday 06 March 2013 21:12:06 Pali Rohár wrote: > > On Sunday 17 February 2013 20:03:03 Aaro Koskinen wrote: > > > On Sun, Feb 17, 2013 at 04:16:49PM +0100, Pali Rohár wrote: > > > > +/* > > > > + *

Re: [PATCH v2] ADP1653 board code for Nokia RX-51

2013-03-06 Thread Pali Rohár
On Wednesday 06 March 2013 21:12:06 Pali Rohár wrote: > On Sunday 17 February 2013 20:03:03 Aaro Koskinen wrote: > > Hi, > > > > On Sun, Feb 17, 2013 at 04:16:49PM +0100, Pali Rohár wrote: > > > +/* > > > + * arch/arm/mach-omap2/board-rx51-camera.c > > > + * > > > + * Copyright (C) 2008 Nokia

Re: [PATCH v2] ADP1653 board code for Nokia RX-51

2013-03-06 Thread Pali Rohár
On Sunday 17 February 2013 20:03:03 Aaro Koskinen wrote: > Hi, > > On Sun, Feb 17, 2013 at 04:16:49PM +0100, Pali Rohár wrote: > > I'm sending ADP1653 flash torch board code for Nokia RX-51. > > Kernel driver ADP1653 is already in upstream kernel. Board > > code was extracted from this big camera

Re: [PATCH v2] ADP1653 board code for Nokia RX-51

2013-03-06 Thread Pali Rohár
On Sunday 17 February 2013 20:03:03 Aaro Koskinen wrote: Hi, On Sun, Feb 17, 2013 at 04:16:49PM +0100, Pali Rohár wrote: I'm sending ADP1653 flash torch board code for Nokia RX-51. Kernel driver ADP1653 is already in upstream kernel. Board code was extracted from this big camera meego

Re: [PATCH v2] ADP1653 board code for Nokia RX-51

2013-03-06 Thread Pali Rohár
On Wednesday 06 March 2013 21:12:06 Pali Rohár wrote: On Sunday 17 February 2013 20:03:03 Aaro Koskinen wrote: Hi, On Sun, Feb 17, 2013 at 04:16:49PM +0100, Pali Rohár wrote: +/* + * arch/arm/mach-omap2/board-rx51-camera.c + * + * Copyright (C) 2008 Nokia Corporation + *

Re: [PATCH v2] ADP1653 board code for Nokia RX-51

2013-03-06 Thread Sebastian Reichel
On Wed, Mar 06, 2013 at 09:20:16PM +0100, Pali Rohár wrote: On Wednesday 06 March 2013 21:12:06 Pali Rohár wrote: On Sunday 17 February 2013 20:03:03 Aaro Koskinen wrote: On Sun, Feb 17, 2013 at 04:16:49PM +0100, Pali Rohár wrote: +/* + * arch/arm/mach-omap2/board-rx51-camera.c +