Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

Hi, On Fri, Dec 15, 2017 at 07:01:40PM +0800, Yong wrote: > Hi Maxime, > > On Fri, 15 Dec 2017 11:50:47 +0100 > Maxime Ripard wrote: > > > Hi Yong, > > > > On Mon, Dec 04, 2017 at 05:45:11PM +0800, Yong wrote: > > > I just noticed that you are using the

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

Hi, On Fri, Dec 15, 2017 at 07:01:40PM +0800, Yong wrote: > Hi Maxime, > > On Fri, 15 Dec 2017 11:50:47 +0100 > Maxime Ripard wrote: > > > Hi Yong, > > > > On Mon, Dec 04, 2017 at 05:45:11PM +0800, Yong wrote: > > > I just noticed that you are using the second iteration? > > > Have you

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

Hi Maxime, On Fri, 15 Dec 2017 11:50:47 +0100 Maxime Ripard wrote: > Hi Yong, > > On Mon, Dec 04, 2017 at 05:45:11PM +0800, Yong wrote: > > I just noticed that you are using the second iteration? > > Have you received my third iteration? > > Sorry for the

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

Hi Maxime, On Fri, 15 Dec 2017 11:50:47 +0100 Maxime Ripard wrote: > Hi Yong, > > On Mon, Dec 04, 2017 at 05:45:11PM +0800, Yong wrote: > > I just noticed that you are using the second iteration? > > Have you received my third iteration? > > Sorry for the late reply, and for not coming back

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

Hi Yong, On Mon, Dec 04, 2017 at 05:45:11PM +0800, Yong wrote: > I just noticed that you are using the second iteration? > Have you received my third iteration? Sorry for the late reply, and for not coming back to you yet about that test. No, this is still in your v2. I've definitely received

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

Hi Yong, On Mon, Dec 04, 2017 at 05:45:11PM +0800, Yong wrote: > I just noticed that you are using the second iteration? > Have you received my third iteration? Sorry for the late reply, and for not coming back to you yet about that test. No, this is still in your v2. I've definitely received

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

Hi Maxime, I just noticed that you are using the second iteration? Have you received my third iteration? On Sat, 25 Nov 2017 17:02:33 +0100 Maxime Ripard wrote: > On Thu, Nov 23, 2017 at 09:14:44AM +0800, Yong wrote: > > > On Wed, Nov 22, 2017 at 09:33:06AM

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

Hi Maxime, I just noticed that you are using the second iteration? Have you received my third iteration? On Sat, 25 Nov 2017 17:02:33 +0100 Maxime Ripard wrote: > On Thu, Nov 23, 2017 at 09:14:44AM +0800, Yong wrote: > > > On Wed, Nov 22, 2017 at 09:33:06AM +0800, Yong wrote: > > > > > On Thu,

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

On Thu, Nov 23, 2017 at 09:14:44AM +0800, Yong wrote: > > On Wed, Nov 22, 2017 at 09:33:06AM +0800, Yong wrote: > > > > On Thu, Jul 27, 2017 at 01:01:35PM +0800, Yong Deng wrote: > > > > > Allwinner V3s SoC have two CSI module. CSI0 is used for MIPI interface > > > > > and CSI1 is used for

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

On Thu, Nov 23, 2017 at 09:14:44AM +0800, Yong wrote: > > On Wed, Nov 22, 2017 at 09:33:06AM +0800, Yong wrote: > > > > On Thu, Jul 27, 2017 at 01:01:35PM +0800, Yong Deng wrote: > > > > > Allwinner V3s SoC have two CSI module. CSI0 is used for MIPI interface > > > > > and CSI1 is used for

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

Hi, On Wed, 22 Nov 2017 10:45:26 +0100 Maxime Ripard wrote: > Hi, > > On Wed, Nov 22, 2017 at 09:33:06AM +0800, Yong wrote: > > > On Thu, Jul 27, 2017 at 01:01:35PM +0800, Yong Deng wrote: > > > > Allwinner V3s SoC have two CSI module. CSI0 is used for MIPI

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

Hi, On Wed, 22 Nov 2017 10:45:26 +0100 Maxime Ripard wrote: > Hi, > > On Wed, Nov 22, 2017 at 09:33:06AM +0800, Yong wrote: > > > On Thu, Jul 27, 2017 at 01:01:35PM +0800, Yong Deng wrote: > > > > Allwinner V3s SoC have two CSI module. CSI0 is used for MIPI interface > > > > and CSI1 is used

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

Hi, On Wed, Nov 22, 2017 at 09:33:06AM +0800, Yong wrote: > > On Thu, Jul 27, 2017 at 01:01:35PM +0800, Yong Deng wrote: > > > Allwinner V3s SoC have two CSI module. CSI0 is used for MIPI interface > > > and CSI1 is used for parallel interface. This is not documented in > > > datasheet but by

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

Hi, On Wed, Nov 22, 2017 at 09:33:06AM +0800, Yong wrote: > > On Thu, Jul 27, 2017 at 01:01:35PM +0800, Yong Deng wrote: > > > Allwinner V3s SoC have two CSI module. CSI0 is used for MIPI interface > > > and CSI1 is used for parallel interface. This is not documented in > > > datasheet but by

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

On Tue, 21 Nov 2017 16:48:27 +0100 Maxime Ripard wrote: > Hi, > > On Thu, Jul 27, 2017 at 01:01:35PM +0800, Yong Deng wrote: > > Allwinner V3s SoC have two CSI module. CSI0 is used for MIPI interface > > and CSI1 is used for parallel interface. This is not

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

On Tue, 21 Nov 2017 16:48:27 +0100 Maxime Ripard wrote: > Hi, > > On Thu, Jul 27, 2017 at 01:01:35PM +0800, Yong Deng wrote: > > Allwinner V3s SoC have two CSI module. CSI0 is used for MIPI interface > > and CSI1 is used for parallel interface. This is not documented in > > datasheet but by

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

Hi, On Thu, Jul 27, 2017 at 01:01:35PM +0800, Yong Deng wrote: > Allwinner V3s SoC have two CSI module. CSI0 is used for MIPI interface > and CSI1 is used for parallel interface. This is not documented in > datasheet but by testing and guess. > > This patch implement a v4l2 framework driver for

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

Hi, On Thu, Jul 27, 2017 at 01:01:35PM +0800, Yong Deng wrote: > Allwinner V3s SoC have two CSI module. CSI0 is used for MIPI interface > and CSI1 is used for parallel interface. This is not documented in > datasheet but by testing and guess. > > This patch implement a v4l2 framework driver for

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

Hello Mylène, On Fri, 22 Sep 2017 10:44:13 +0200 Mylene JOSSERAND wrote: > Hello Yong, > > Thank you for these drivers! > > I tested it with an OV5640 camera on an Nanopi M1 plus (Allwinner H3) > and I noticed that I got a frame correctly displayed only on

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

Hello Mylène, On Fri, 22 Sep 2017 10:44:13 +0200 Mylene JOSSERAND wrote: > Hello Yong, > > Thank you for these drivers! > > I tested it with an OV5640 camera on an Nanopi M1 plus (Allwinner H3) > and I noticed that I got a frame correctly displayed only on a half of > the frame's size. > >

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

Hello Yong, Thank you for these drivers! I tested it with an OV5640 camera on an Nanopi M1 plus (Allwinner H3) and I noticed that I got a frame correctly displayed only on a half of the frame's size. It is related to your "sun6i_csi_set_window" function (see below). > Allwinner V3s SoC have

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

Hello Yong, Thank you for these drivers! I tested it with an OV5640 camera on an Nanopi M1 plus (Allwinner H3) and I noticed that I got a frame correctly displayed only on a half of the frame's size. It is related to your "sun6i_csi_set_window" function (see below). > Allwinner V3s SoC have

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

Hi Maxime, On Fri, 25 Aug 2017 15:41:14 +0200 Maxime Ripard wrote: > Hi Yong, > > On Wed, Aug 23, 2017 at 10:32:16AM +0800, Yong wrote: > > > > > > +static int sun6i_graph_notify_complete(struct v4l2_async_notifier > > > > > > *notifier) > > > > > > +{ > > >

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

Hi Maxime, On Fri, 25 Aug 2017 15:41:14 +0200 Maxime Ripard wrote: > Hi Yong, > > On Wed, Aug 23, 2017 at 10:32:16AM +0800, Yong wrote: > > > > > > +static int sun6i_graph_notify_complete(struct v4l2_async_notifier > > > > > > *notifier) > > > > > > +{ > > > > > > + struct sun6i_csi *csi =

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

Hi Yong, On Wed, Aug 23, 2017 at 10:32:16AM +0800, Yong wrote: > > > > > +static int sun6i_graph_notify_complete(struct v4l2_async_notifier > > > > > *notifier) > > > > > +{ > > > > > + struct sun6i_csi *csi = > > > > > + container_of(notifier, struct sun6i_csi, > > > >

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

Hi Yong, On Wed, Aug 23, 2017 at 10:32:16AM +0800, Yong wrote: > > > > > +static int sun6i_graph_notify_complete(struct v4l2_async_notifier > > > > > *notifier) > > > > > +{ > > > > > + struct sun6i_csi *csi = > > > > > + container_of(notifier, struct sun6i_csi, > > > >

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

On Wed, 23 Aug 2017 21:24:13 +0200 Maxime Ripard wrote: > On Wed, Aug 23, 2017 at 10:41:18AM +0800, Yong wrote: > > > > > > +static irqreturn_t sun6i_csi_isr(int irq, void *dev_id) > > > > > > +{ > > > > > > + struct sun6i_csi_dev *sdev = (struct sun6i_csi_dev

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

On Wed, 23 Aug 2017 21:24:13 +0200 Maxime Ripard wrote: > On Wed, Aug 23, 2017 at 10:41:18AM +0800, Yong wrote: > > > > > > +static irqreturn_t sun6i_csi_isr(int irq, void *dev_id) > > > > > > +{ > > > > > > + struct sun6i_csi_dev *sdev = (struct sun6i_csi_dev *)dev_id; > > > > > > + struct

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

On Wed, Aug 23, 2017 at 10:41:18AM +0800, Yong wrote: > > > > > +static irqreturn_t sun6i_csi_isr(int irq, void *dev_id) > > > > > +{ > > > > > + struct sun6i_csi_dev *sdev = (struct sun6i_csi_dev *)dev_id; > > > > > + struct regmap *regmap = sdev->regmap; > > > > > + u32 status; > > >

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

On Wed, Aug 23, 2017 at 10:41:18AM +0800, Yong wrote: > > > > > +static irqreturn_t sun6i_csi_isr(int irq, void *dev_id) > > > > > +{ > > > > > + struct sun6i_csi_dev *sdev = (struct sun6i_csi_dev *)dev_id; > > > > > + struct regmap *regmap = sdev->regmap; > > > > > + u32 status; > > >

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

在 2017-08-23 15:43，Laurent Pinchart 写道： Hi Hans, On Wednesday, 23 August 2017 09:52:00 EEST Hans Verkuil wrote: On 08/22/2017 10:17 PM, Maxime Ripard wrote: > On Tue, Aug 22, 2017 at 08:43:35AM +0200, Hans Verkuil wrote: > +static int sun6i_video_link_setup(struct media_entity *entity,

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

在 2017-08-23 15:43，Laurent Pinchart 写道： Hi Hans, On Wednesday, 23 August 2017 09:52:00 EEST Hans Verkuil wrote: On 08/22/2017 10:17 PM, Maxime Ripard wrote: > On Tue, Aug 22, 2017 at 08:43:35AM +0200, Hans Verkuil wrote: > +static int sun6i_video_link_setup(struct media_entity *entity,

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

Hi Hans, On Wednesday, 23 August 2017 09:52:00 EEST Hans Verkuil wrote: > On 08/22/2017 10:17 PM, Maxime Ripard wrote: > > On Tue, Aug 22, 2017 at 08:43:35AM +0200, Hans Verkuil wrote: > > +static int sun6i_video_link_setup(struct media_entity *entity, > > +

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

Hi Hans, On Wednesday, 23 August 2017 09:52:00 EEST Hans Verkuil wrote: > On 08/22/2017 10:17 PM, Maxime Ripard wrote: > > On Tue, Aug 22, 2017 at 08:43:35AM +0200, Hans Verkuil wrote: > > +static int sun6i_video_link_setup(struct media_entity *entity, > > +

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

On 08/22/2017 10:17 PM, Maxime Ripard wrote: > On Tue, Aug 22, 2017 at 08:43:35AM +0200, Hans Verkuil wrote: > +static int sun6i_video_link_setup(struct media_entity *entity, > + const struct media_pad *local, > + const struct

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

On 08/22/2017 10:17 PM, Maxime Ripard wrote: > On Tue, Aug 22, 2017 at 08:43:35AM +0200, Hans Verkuil wrote: > +static int sun6i_video_link_setup(struct media_entity *entity, > + const struct media_pad *local, > + const struct

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

On Mon, 21 Aug 2017 22:21:45 +0200 Maxime Ripard wrote: > Hi Baruch, > > On Sun, Jul 30, 2017 at 09:08:01AM +0300, Baruch Siach wrote: > > On Fri, Jul 28, 2017 at 06:02:33PM +0200, Maxime Ripard wrote: > > > Hi, > > > > > > Thanks for the second iteration! >

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

On Mon, 21 Aug 2017 22:21:45 +0200 Maxime Ripard wrote: > Hi Baruch, > > On Sun, Jul 30, 2017 at 09:08:01AM +0300, Baruch Siach wrote: > > On Fri, Jul 28, 2017 at 06:02:33PM +0200, Maxime Ripard wrote: > > > Hi, > > > > > > Thanks for the second iteration! > > > > > > On Thu, Jul 27, 2017 at

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

On Tue, 22 Aug 2017 19:43:39 +0200 Maxime Ripard wrote: > Hi Yong, > > On Mon, Jul 31, 2017 at 11:16:40AM +0800, Yong wrote: > > > > @@ -143,6 +143,7 @@ source "drivers/media/platform/am437x/Kconfig" > > > > source "drivers/media/platform/xilinx/Kconfig" > > >

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

On Tue, 22 Aug 2017 19:43:39 +0200 Maxime Ripard wrote: > Hi Yong, > > On Mon, Jul 31, 2017 at 11:16:40AM +0800, Yong wrote: > > > > @@ -143,6 +143,7 @@ source "drivers/media/platform/am437x/Kconfig" > > > > source "drivers/media/platform/xilinx/Kconfig" > > > > source

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

Hello, On Tuesday, 22 August 2017 23:17:31 EEST Maxime Ripard wrote: > On Tue, Aug 22, 2017 at 08:43:35AM +0200, Hans Verkuil wrote: > +static int sun6i_video_link_setup(struct media_entity *entity, > + const struct media_pad *local, > +

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

Hello, On Tuesday, 22 August 2017 23:17:31 EEST Maxime Ripard wrote: > On Tue, Aug 22, 2017 at 08:43:35AM +0200, Hans Verkuil wrote: > +static int sun6i_video_link_setup(struct media_entity *entity, > + const struct media_pad *local, > +

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

On Tue, Aug 22, 2017 at 08:43:35AM +0200, Hans Verkuil wrote: > >>> +static int sun6i_video_link_setup(struct media_entity *entity, > >>> + const struct media_pad *local, > >>> + const struct media_pad *remote, u32 flags) > >>> +{ > >>> + struct

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

On Tue, Aug 22, 2017 at 08:43:35AM +0200, Hans Verkuil wrote: > >>> +static int sun6i_video_link_setup(struct media_entity *entity, > >>> + const struct media_pad *local, > >>> + const struct media_pad *remote, u32 flags) > >>> +{ > >>> + struct

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

Hi Yong, On Mon, Jul 31, 2017 at 11:16:40AM +0800, Yong wrote: > > > @@ -143,6 +143,7 @@ source "drivers/media/platform/am437x/Kconfig" > > > source "drivers/media/platform/xilinx/Kconfig" > > > source "drivers/media/platform/rcar-vin/Kconfig" > > > source

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

Hi Yong, On Mon, Jul 31, 2017 at 11:16:40AM +0800, Yong wrote: > > > @@ -143,6 +143,7 @@ source "drivers/media/platform/am437x/Kconfig" > > > source "drivers/media/platform/xilinx/Kconfig" > > > source "drivers/media/platform/rcar-vin/Kconfig" > > > source

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

On Tue, 22 Aug 2017 08:43:35 +0200 Hans Verkuil wrote: > On 08/22/2017 05:01 AM, Yong wrote: > > Hi Hans, > > > > On Mon, 21 Aug 2017 16:37:41 +0200 > > Hans Verkuil wrote: > > > >> Hi Yong, > >> > >> First two high-level comments before I start the

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

On Tue, 22 Aug 2017 08:43:35 +0200 Hans Verkuil wrote: > On 08/22/2017 05:01 AM, Yong wrote: > > Hi Hans, > > > > On Mon, 21 Aug 2017 16:37:41 +0200 > > Hans Verkuil wrote: > > > >> Hi Yong, > >> > >> First two high-level comments before I start the review: > >> > >> 1) Can you provide the

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

On 08/22/2017 05:01 AM, Yong wrote: > Hi Hans, > > On Mon, 21 Aug 2017 16:37:41 +0200 > Hans Verkuil wrote: > >> Hi Yong, >> >> First two high-level comments before I start the review: >> >> 1) Can you provide the v4l2-compliance output? I can't merge this unless I >>see

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

On 08/22/2017 05:01 AM, Yong wrote: > Hi Hans, > > On Mon, 21 Aug 2017 16:37:41 +0200 > Hans Verkuil wrote: > >> Hi Yong, >> >> First two high-level comments before I start the review: >> >> 1) Can you provide the v4l2-compliance output? I can't merge this unless I >>see that it passes the

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

Hi Hans, On Mon, 21 Aug 2017 16:37:41 +0200 Hans Verkuil wrote: > Hi Yong, > > First two high-level comments before I start the review: > > 1) Can you provide the v4l2-compliance output? I can't merge this unless I >see that it passes the compliance tests. Make sure

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

Hi Hans, On Mon, 21 Aug 2017 16:37:41 +0200 Hans Verkuil wrote: > Hi Yong, > > First two high-level comments before I start the review: > > 1) Can you provide the v4l2-compliance output? I can't merge this unless I >see that it passes the compliance tests. Make sure you compile from the

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

Hi Baruch, On Sun, Jul 30, 2017 at 09:08:01AM +0300, Baruch Siach wrote: > On Fri, Jul 28, 2017 at 06:02:33PM +0200, Maxime Ripard wrote: > > Hi, > > > > Thanks for the second iteration! > > > > On Thu, Jul 27, 2017 at 01:01:35PM +0800, Yong Deng wrote: > > > Allwinner V3s SoC have two CSI

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

Hi Baruch, On Sun, Jul 30, 2017 at 09:08:01AM +0300, Baruch Siach wrote: > On Fri, Jul 28, 2017 at 06:02:33PM +0200, Maxime Ripard wrote: > > Hi, > > > > Thanks for the second iteration! > > > > On Thu, Jul 27, 2017 at 01:01:35PM +0800, Yong Deng wrote: > > > Allwinner V3s SoC have two CSI

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

Hi Yong, First two high-level comments before I start the review: 1) Can you provide the v4l2-compliance output? I can't merge this unless I see that it passes the compliance tests. Make sure you compile from the git repo (https://git.linuxtv.org/v4l-utils.git/) so you are using the latest

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

Hi Yong, First two high-level comments before I start the review: 1) Can you provide the v4l2-compliance output? I can't merge this unless I see that it passes the compliance tests. Make sure you compile from the git repo (https://git.linuxtv.org/v4l-utils.git/) so you are using the latest

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

Hi Yong, On Mon, Jul 31, 2017 at 09:48:06AM +0800, Yong wrote: > On Sun, 30 Jul 2017 09:08:01 +0300 > Baruch Siach wrote: > > On Fri, Jul 28, 2017 at 06:02:33PM +0200, Maxime Ripard wrote: > > > On Thu, Jul 27, 2017 at 01:01:35PM +0800, Yong Deng wrote: > > > > +

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

Hi Yong, On Mon, Jul 31, 2017 at 09:48:06AM +0800, Yong wrote: > On Sun, 30 Jul 2017 09:08:01 +0300 > Baruch Siach wrote: > > On Fri, Jul 28, 2017 at 06:02:33PM +0200, Maxime Ripard wrote: > > > On Thu, Jul 27, 2017 at 01:01:35PM +0800, Yong Deng wrote: > > > > + regmap_write(sdev->regmap,

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

Hi, On Fri, 28 Jul 2017 18:02:33 +0200 Maxime Ripard wrote: > Hi, > > Thanks for the second iteration! > > On Thu, Jul 27, 2017 at 01:01:35PM +0800, Yong Deng wrote: > > Allwinner V3s SoC have two CSI module. CSI0 is used for MIPI interface > > and CSI1 is

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

Hi, On Fri, 28 Jul 2017 18:02:33 +0200 Maxime Ripard wrote: > Hi, > > Thanks for the second iteration! > > On Thu, Jul 27, 2017 at 01:01:35PM +0800, Yong Deng wrote: > > Allwinner V3s SoC have two CSI module. CSI0 is used for MIPI interface > > and CSI1 is used for parallel interface. This

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

Hi, On Sun, 30 Jul 2017 09:08:01 +0300 Baruch Siach wrote: > Hi Maxime, Yong, > > On Fri, Jul 28, 2017 at 06:02:33PM +0200, Maxime Ripard wrote: > > Hi, > > > > Thanks for the second iteration! > > > > On Thu, Jul 27, 2017 at 01:01:35PM +0800, Yong Deng wrote: > > >

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

Hi, On Sun, 30 Jul 2017 09:08:01 +0300 Baruch Siach wrote: > Hi Maxime, Yong, > > On Fri, Jul 28, 2017 at 06:02:33PM +0200, Maxime Ripard wrote: > > Hi, > > > > Thanks for the second iteration! > > > > On Thu, Jul 27, 2017 at 01:01:35PM +0800, Yong Deng wrote: > > > Allwinner V3s SoC have

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

On Thu, 27 Jul 2017 14:25:51 +0200 Maxime Ripard wrote: > On Thu, Jul 27, 2017 at 03:16:44PM +0300, Baruch Siach wrote: > > Hi Yong, > > > > I managed to get the Frame Done interrupt with the previous version of this > > driver on the A33 OLinuXino. No data

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

On Thu, 27 Jul 2017 14:25:51 +0200 Maxime Ripard wrote: > On Thu, Jul 27, 2017 at 03:16:44PM +0300, Baruch Siach wrote: > > Hi Yong, > > > > I managed to get the Frame Done interrupt with the previous version of this > > driver on the A33 OLinuXino. No data yet (all zeros). I'm still working

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

Hi Maxime, Yong, On Fri, Jul 28, 2017 at 06:02:33PM +0200, Maxime Ripard wrote: > Hi, > > Thanks for the second iteration! > > On Thu, Jul 27, 2017 at 01:01:35PM +0800, Yong Deng wrote: > > Allwinner V3s SoC have two CSI module. CSI0 is used for MIPI interface > > and CSI1 is used for parallel

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

Hi Maxime, Yong, On Fri, Jul 28, 2017 at 06:02:33PM +0200, Maxime Ripard wrote: > Hi, > > Thanks for the second iteration! > > On Thu, Jul 27, 2017 at 01:01:35PM +0800, Yong Deng wrote: > > Allwinner V3s SoC have two CSI module. CSI0 is used for MIPI interface > > and CSI1 is used for parallel

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

Hi, Thanks for the second iteration! On Thu, Jul 27, 2017 at 01:01:35PM +0800, Yong Deng wrote: > Allwinner V3s SoC have two CSI module. CSI0 is used for MIPI interface > and CSI1 is used for parallel interface. This is not documented in > datasheet but by testing and guess. > > This patch

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

Hi, Thanks for the second iteration! On Thu, Jul 27, 2017 at 01:01:35PM +0800, Yong Deng wrote: > Allwinner V3s SoC have two CSI module. CSI0 is used for MIPI interface > and CSI1 is used for parallel interface. This is not documented in > datasheet but by testing and guess. > > This patch

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

On Thu, Jul 27, 2017 at 03:16:44PM +0300, Baruch Siach wrote: > Hi Yong, > > I managed to get the Frame Done interrupt with the previous version of this > driver on the A33 OLinuXino. No data yet (all zeros). I'm still working on it. > > One comment below. > > On Thu, Jul 27, 2017 at

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

On Thu, Jul 27, 2017 at 03:16:44PM +0300, Baruch Siach wrote: > Hi Yong, > > I managed to get the Frame Done interrupt with the previous version of this > driver on the A33 OLinuXino. No data yet (all zeros). I'm still working on it. > > One comment below. > > On Thu, Jul 27, 2017 at

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

Hi Yong, I managed to get the Frame Done interrupt with the previous version of this driver on the A33 OLinuXino. No data yet (all zeros). I'm still working on it. One comment below. On Thu, Jul 27, 2017 at 01:01:35PM +0800, Yong Deng wrote: > Allwinner V3s SoC have two CSI module. CSI0 is

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

Hi Yong, I managed to get the Frame Done interrupt with the previous version of this driver on the A33 OLinuXino. No data yet (all zeros). I'm still working on it. One comment below. On Thu, Jul 27, 2017 at 01:01:35PM +0800, Yong Deng wrote: > Allwinner V3s SoC have two CSI module. CSI0 is