Re: [PATCH v3] irqchip/tango: Don't use incorrect irq_mask_ack callback

On 21/08/2017 15:25, Marc Gonzalez wrote: Using separate mask and ack functions (i.e. my patch) # iperf3 -c 172.27.64.110 -t 20 Connecting to host 172.27.64.110, port 5201 [ 4] local 172.27.64.1 port 40868 connected to 172.27.64.110 port 5201 [ ID] Interval Transfer Bandwidth

Re: [PATCH v3] irqchip/tango: Don't use incorrect irq_mask_ack callback

On 21/08/2017 15:25, Marc Gonzalez wrote: Using separate mask and ack functions (i.e. my patch) # iperf3 -c 172.27.64.110 -t 20 Connecting to host 172.27.64.110, port 5201 [ 4] local 172.27.64.1 port 40868 connected to 172.27.64.110 port 5201 [ ID] Interval Transfer Bandwidth

Re: [PATCH v3] irqchip/tango: Don't use incorrect irq_mask_ack callback

On 07/08/2017 14:56, Marc Zyngier wrote: > On 28/07/17 15:06, Marc Gonzalez wrote: > >> On 27/07/2017 20:17, Florian Fainelli wrote: >> >>> On 07/26/2017 12:13 PM, Måns Rullgård wrote: >>> Florian Fainelli writes: > On 07/25/2017 06:29 AM, Måns Rullgård wrote: > >> Marc

Re: [PATCH v3] irqchip/tango: Don't use incorrect irq_mask_ack callback

On 07/08/2017 14:56, Marc Zyngier wrote: > On 28/07/17 15:06, Marc Gonzalez wrote: > >> On 27/07/2017 20:17, Florian Fainelli wrote: >> >>> On 07/26/2017 12:13 PM, Måns Rullgård wrote: >>> Florian Fainelli writes: > On 07/25/2017 06:29 AM, Måns Rullgård wrote: > >> Marc

Re: [PATCH v3] irqchip/tango: Don't use incorrect irq_mask_ack callback

Florian Fainelli writes: > What do we do with this patch series to move forward? Can we get Doug's > changes queued up for 4.14? My opinion is that the correct combined function should be added and the tango driver updated to use it. Patches already exist, so what are we

Re: [PATCH v3] irqchip/tango: Don't use incorrect irq_mask_ack callback

Florian Fainelli writes: > What do we do with this patch series to move forward? Can we get Doug's > changes queued up for 4.14? My opinion is that the correct combined function should be added and the tango driver updated to use it. Patches already exist, so what are we waiting for? -- Måns

Re: [PATCH v3] irqchip/tango: Don't use incorrect irq_mask_ack callback

On 08/07/2017 05:56 AM, Marc Zyngier wrote: > On 28/07/17 15:06, Marc Gonzalez wrote: >> On 27/07/2017 20:17, Florian Fainelli wrote: >> >>> On 07/26/2017 12:13 PM, Måns Rullgård wrote: >>> Florian Fainelli writes: > On 07/25/2017 06:29 AM, Måns Rullgård wrote: > >> Marc

Re: [PATCH v3] irqchip/tango: Don't use incorrect irq_mask_ack callback

On 08/07/2017 05:56 AM, Marc Zyngier wrote: > On 28/07/17 15:06, Marc Gonzalez wrote: >> On 27/07/2017 20:17, Florian Fainelli wrote: >> >>> On 07/26/2017 12:13 PM, Måns Rullgård wrote: >>> Florian Fainelli writes: > On 07/25/2017 06:29 AM, Måns Rullgård wrote: > >> Marc

Re: [PATCH v3] irqchip/tango: Don't use incorrect irq_mask_ack callback

On 28/07/17 15:06, Marc Gonzalez wrote: > On 27/07/2017 20:17, Florian Fainelli wrote: > >> On 07/26/2017 12:13 PM, Måns Rullgård wrote: >> >>> Florian Fainelli writes: >>> On 07/25/2017 06:29 AM, Måns Rullgård wrote: > Marc Gonzalez writes: >

Re: [PATCH v3] irqchip/tango: Don't use incorrect irq_mask_ack callback

On 28/07/17 15:06, Marc Gonzalez wrote: > On 27/07/2017 20:17, Florian Fainelli wrote: > >> On 07/26/2017 12:13 PM, Måns Rullgård wrote: >> >>> Florian Fainelli writes: >>> On 07/25/2017 06:29 AM, Måns Rullgård wrote: > Marc Gonzalez writes: > >> On 25/07/2017 15:16, Måns

Re: [PATCH v3] irqchip/tango: Don't use incorrect irq_mask_ack callback

On 27/07/2017 20:17, Florian Fainelli wrote: > On 07/26/2017 12:13 PM, Måns Rullgård wrote: > >> Florian Fainelli writes: >> >>> On 07/25/2017 06:29 AM, Måns Rullgård wrote: >>> Marc Gonzalez writes: > On 25/07/2017 15:16, Måns Rullgård wrote: >

Re: [PATCH v3] irqchip/tango: Don't use incorrect irq_mask_ack callback

On 27/07/2017 20:17, Florian Fainelli wrote: > On 07/26/2017 12:13 PM, Måns Rullgård wrote: > >> Florian Fainelli writes: >> >>> On 07/25/2017 06:29 AM, Måns Rullgård wrote: >>> Marc Gonzalez writes: > On 25/07/2017 15:16, Måns Rullgård wrote: > >> What happened to the

Re: [PATCH v3] irqchip/tango: Don't use incorrect irq_mask_ack callback

On 07/26/2017 12:13 PM, Måns Rullgård wrote: > Florian Fainelli writes: > >> On 07/25/2017 06:29 AM, Måns Rullgård wrote: >>> Marc Gonzalez writes: >>> On 25/07/2017 15:16, Måns Rullgård wrote: > What happened to the patch

Re: [PATCH v3] irqchip/tango: Don't use incorrect irq_mask_ack callback

On 07/26/2017 12:13 PM, Måns Rullgård wrote: > Florian Fainelli writes: > >> On 07/25/2017 06:29 AM, Måns Rullgård wrote: >>> Marc Gonzalez writes: >>> On 25/07/2017 15:16, Måns Rullgård wrote: > What happened to the patch adding the proper combined function? It appears

Re: [PATCH v3] irqchip/tango: Don't use incorrect irq_mask_ack callback

Florian Fainelli writes: > On 07/25/2017 06:29 AM, Måns Rullgård wrote: >> Marc Gonzalez writes: >> >>> On 25/07/2017 15:16, Måns Rullgård wrote: >>> What happened to the patch adding the proper combined function? >>> >>> It appears

Re: [PATCH v3] irqchip/tango: Don't use incorrect irq_mask_ack callback

Florian Fainelli writes: > On 07/25/2017 06:29 AM, Måns Rullgård wrote: >> Marc Gonzalez writes: >> >>> On 25/07/2017 15:16, Måns Rullgård wrote: >>> What happened to the patch adding the proper combined function? >>> >>> It appears you're not CCed on v2. >>> >>>

Re: [PATCH v3] irqchip/tango: Don't use incorrect irq_mask_ack callback

On 07/25/2017 06:29 AM, Måns Rullgård wrote: > Marc Gonzalez writes: > >> On 25/07/2017 15:16, Måns Rullgård wrote: >> >>> What happened to the patch adding the proper combined function? >> >> It appears you're not CCed on v2. >> >>

Re: [PATCH v3] irqchip/tango: Don't use incorrect irq_mask_ack callback

On 07/25/2017 06:29 AM, Måns Rullgård wrote: > Marc Gonzalez writes: > >> On 25/07/2017 15:16, Måns Rullgård wrote: >> >>> What happened to the patch adding the proper combined function? >> >> It appears you're not CCed on v2. >> >> https://patchwork.kernel.org/patch/9859799/ >> >> Doug wrote:

Re: [PATCH v3] irqchip/tango: Don't use incorrect irq_mask_ack callback

On 25/07/2017 15:08, Marc Gonzalez wrote: > irq_gc_mask_disable_reg_and_ack() is not equivalent to > irq_gc_mask_disable_reg() and irq_gc_ack_set_bit(). > > Leave the irq_mask_ack callback undefined, and let the irqchip > framework use irq_mask and irq_ack instead. > > Reported-by: Doug Berger

Re: [PATCH v3] irqchip/tango: Don't use incorrect irq_mask_ack callback

On 25/07/2017 15:08, Marc Gonzalez wrote: > irq_gc_mask_disable_reg_and_ack() is not equivalent to > irq_gc_mask_disable_reg() and irq_gc_ack_set_bit(). > > Leave the irq_mask_ack callback undefined, and let the irqchip > framework use irq_mask and irq_ack instead. > > Reported-by: Doug Berger

Re: [PATCH v3] irqchip/tango: Don't use incorrect irq_mask_ack callback

Marc Gonzalez writes: > On 25/07/2017 15:16, Måns Rullgård wrote: > >> What happened to the patch adding the proper combined function? > > It appears you're not CCed on v2. > > https://patchwork.kernel.org/patch/9859799/ > > Doug wrote: >> Yes, you understand

Re: [PATCH v3] irqchip/tango: Don't use incorrect irq_mask_ack callback

Marc Gonzalez writes: > On 25/07/2017 15:16, Måns Rullgård wrote: > >> What happened to the patch adding the proper combined function? > > It appears you're not CCed on v2. > > https://patchwork.kernel.org/patch/9859799/ > > Doug wrote: >> Yes, you understand correctly. The irq_mask_ack method

Re: [PATCH v3] irqchip/tango: Don't use incorrect irq_mask_ack callback

On 25/07/2017 15:16, Måns Rullgård wrote: > What happened to the patch adding the proper combined function? It appears you're not CCed on v2. https://patchwork.kernel.org/patch/9859799/ Doug wrote: > Yes, you understand correctly. The irq_mask_ack method is entirely > optional and I assume

Re: [PATCH v3] irqchip/tango: Don't use incorrect irq_mask_ack callback

On 25/07/2017 15:16, Måns Rullgård wrote: > What happened to the patch adding the proper combined function? It appears you're not CCed on v2. https://patchwork.kernel.org/patch/9859799/ Doug wrote: > Yes, you understand correctly. The irq_mask_ack method is entirely > optional and I assume

Re: [PATCH v3] irqchip/tango: Don't use incorrect irq_mask_ack callback

Marc Gonzalez writes: > irq_gc_mask_disable_reg_and_ack() is not equivalent to > irq_gc_mask_disable_reg() and irq_gc_ack_set_bit(). > > Leave the irq_mask_ack callback undefined, and let the irqchip > framework use irq_mask and irq_ack instead. > > Reported-by:

Re: [PATCH v3] irqchip/tango: Don't use incorrect irq_mask_ack callback

Marc Gonzalez writes: > irq_gc_mask_disable_reg_and_ack() is not equivalent to > irq_gc_mask_disable_reg() and irq_gc_ack_set_bit(). > > Leave the irq_mask_ack callback undefined, and let the irqchip > framework use irq_mask and irq_ack instead. > > Reported-by: Doug Berger > Fixes: