Re: [PATCH v3 1/2] checkpatch: add Kconfig 'default n' test

2016-06-08 Thread Paul Bolle
On di, 2016-06-07 at 21:16 +0800, Yingjoe Chen wrote: > On Mon, 2016-06-06 at 20:10 +0100, Andy Whitcroft wrote: > > > Is it obvious that a Kconfig has "default n" ? > > > This seems to work, but is this useful? > > While sending patch for upstream, I saw maintainers request it to be > removed. So

Re: [PATCH v3 1/2] checkpatch: add Kconfig 'default n' test

2016-06-07 Thread Yingjoe Chen
Hi, Thanks for the review. On Mon, 2016-06-06 at 20:10 +0100, Andy Whitcroft wrote: > On Mon, Jun 06, 2016 at 09:43:15AM -0700, Joe Perches wrote: > > On Sat, 2016-06-04 at 13:10 +0800, Yingjoe Chen wrote: > > > If a Kconfig config option doesn't specify 'default', the default > > > will be n.

Re: [PATCH v3 1/2] checkpatch: add Kconfig 'default n' test

2016-06-06 Thread Andy Whitcroft
On Mon, Jun 06, 2016 at 09:43:15AM -0700, Joe Perches wrote: > On Sat, 2016-06-04 at 13:10 +0800, Yingjoe Chen wrote: > > If a Kconfig config option doesn't specify 'default', the default > > will be n. Adding 'default n' is unnecessary. > > Add a test to warn about this. > > Is it obvious that a

Re: [PATCH v3 1/2] checkpatch: add Kconfig 'default n' test

2016-06-06 Thread Joe Perches
On Sat, 2016-06-04 at 13:10 +0800, Yingjoe Chen wrote: > If a Kconfig config option doesn't specify 'default', the default > will be n. Adding 'default n' is unnecessary. > Add a test to warn about this. Is it obvious that a Kconfig has "default n" ? This seems to work, but is this useful? > Sign