Re: [PATCH v3.1 1/3] drm/rockchip: dw_hdmi: add RK3399 HDMI support

2017-06-22 Thread Rob Herring
On Thu, Jun 22, 2017 at 2:17 AM, Mark Yao wrote: > RK3399 and RK3288 shared the same HDMI IP controller, only some light > difference with GRF configure. > > Signed-off-by: Yakir Yang > Signed-off-by: Mark Yao > --- >

Re: [PATCH v3.1 1/3] drm/rockchip: dw_hdmi: add RK3399 HDMI support

2017-06-22 Thread Rob Herring
On Thu, Jun 22, 2017 at 2:17 AM, Mark Yao wrote: > RK3399 and RK3288 shared the same HDMI IP controller, only some light > difference with GRF configure. > > Signed-off-by: Yakir Yang > Signed-off-by: Mark Yao > --- > Changes in v3.1: > Correct documentation compatible's format(Rob Herring).

Re: [PATCH v3.1 1/3] drm/rockchip: dw_hdmi: add RK3399 HDMI support

2017-06-22 Thread Heiko Stuebner
Am Donnerstag, 22. Juni 2017, 16:02:44 CEST schrieb Mark yao: > On 2017年06月22日 15:31, Heiko Stuebner wrote: > >> + > >> >+/** > >> >+ * struct rockchip_hdmi_chip_data - splite the grf setting of kind of > >> >chips > >> >+ * @lcdsel_grf_reg: grf register offset of lcdc select > >> >+ *

Re: [PATCH v3.1 1/3] drm/rockchip: dw_hdmi: add RK3399 HDMI support

2017-06-22 Thread Heiko Stuebner
Am Donnerstag, 22. Juni 2017, 16:02:44 CEST schrieb Mark yao: > On 2017年06月22日 15:31, Heiko Stuebner wrote: > >> + > >> >+/** > >> >+ * struct rockchip_hdmi_chip_data - splite the grf setting of kind of > >> >chips > >> >+ * @lcdsel_grf_reg: grf register offset of lcdc select > >> >+ *

Re: [PATCH v3.1 1/3] drm/rockchip: dw_hdmi: add RK3399 HDMI support

2017-06-22 Thread Mark yao
On 2017年06月22日 15:31, Heiko Stuebner wrote: + >+/** >+ * struct rockchip_hdmi_chip_data - splite the grf setting of kind of chips >+ * @lcdsel_grf_reg: grf register offset of lcdc select >+ * @lcdsel_big: reg value of selecting vop big for HDMI >+ * @lcdsel_lit: reg value of selecting vop little

Re: [PATCH v3.1 1/3] drm/rockchip: dw_hdmi: add RK3399 HDMI support

2017-06-22 Thread Mark yao
On 2017年06月22日 15:31, Heiko Stuebner wrote: + >+/** >+ * struct rockchip_hdmi_chip_data - splite the grf setting of kind of chips >+ * @lcdsel_grf_reg: grf register offset of lcdc select >+ * @lcdsel_big: reg value of selecting vop big for HDMI >+ * @lcdsel_lit: reg value of selecting vop little

Re: [PATCH v3.1 1/3] drm/rockchip: dw_hdmi: add RK3399 HDMI support

2017-06-22 Thread Heiko Stuebner
Hi Mark, Am Donnerstag, 22. Juni 2017, 15:17:24 CEST schrieb Mark Yao: > RK3399 and RK3288 shared the same HDMI IP controller, only some light > difference with GRF configure. > > Signed-off-by: Yakir Yang > Signed-off-by: Mark Yao > --- > Changes

Re: [PATCH v3.1 1/3] drm/rockchip: dw_hdmi: add RK3399 HDMI support

2017-06-22 Thread Heiko Stuebner
Hi Mark, Am Donnerstag, 22. Juni 2017, 15:17:24 CEST schrieb Mark Yao: > RK3399 and RK3288 shared the same HDMI IP controller, only some light > difference with GRF configure. > > Signed-off-by: Yakir Yang > Signed-off-by: Mark Yao > --- > Changes in v3.1: > Correct documentation