Re: [PATCH v4] platform/x86: ideapad-laptop: Add sysfs interface for touchpad state

2017-05-07 Thread Andy Shevchenko
On Wed, May 3, 2017 at 7:11 PM, Darren Hart wrote: > On Wed, May 03, 2017 at 05:42:02PM +0300, Andy Shevchenko wrote: >> On Wed, May 3, 2017 at 5:36 PM, Ritesh Raj Sarraf wrote: >> > Resending again, as Google servers are behaving weird lately. >> > >> > On

Re: [PATCH v4] platform/x86: ideapad-laptop: Add sysfs interface for touchpad state

2017-05-07 Thread Andy Shevchenko
On Wed, May 3, 2017 at 7:11 PM, Darren Hart wrote: > On Wed, May 03, 2017 at 05:42:02PM +0300, Andy Shevchenko wrote: >> On Wed, May 3, 2017 at 5:36 PM, Ritesh Raj Sarraf wrote: >> > Resending again, as Google servers are behaving weird lately. >> > >> > On Sun, 2017-04-30 at 15:54 +0300, Andy

Re: [PATCH v4] platform/x86: ideapad-laptop: Add sysfs interface for touchpad state

2017-05-03 Thread Darren Hart
On Wed, May 03, 2017 at 05:42:02PM +0300, Andy Shevchenko wrote: > On Wed, May 3, 2017 at 5:36 PM, Ritesh Raj Sarraf wrote: > > Resending again, as Google servers are behaving weird lately. > > > > On Sun, 2017-04-30 at 15:54 +0300, Andy Shevchenko wrote: > >> > > the main issue

Re: [PATCH v4] platform/x86: ideapad-laptop: Add sysfs interface for touchpad state

2017-05-03 Thread Darren Hart
On Wed, May 03, 2017 at 05:42:02PM +0300, Andy Shevchenko wrote: > On Wed, May 3, 2017 at 5:36 PM, Ritesh Raj Sarraf wrote: > > Resending again, as Google servers are behaving weird lately. > > > > On Sun, 2017-04-30 at 15:54 +0300, Andy Shevchenko wrote: > >> > > the main issue that driver

Re: [PATCH v4] platform/x86: ideapad-laptop: Add sysfs interface for touchpad state

2017-05-03 Thread Andy Shevchenko
On Wed, May 3, 2017 at 5:36 PM, Ritesh Raj Sarraf wrote: > Resending again, as Google servers are behaving weird lately. > > On Sun, 2017-04-30 at 15:54 +0300, Andy Shevchenko wrote: >> > > the main issue that driver doesn't >> > > send SW_TABLET_MODE event through input device.

Re: [PATCH v4] platform/x86: ideapad-laptop: Add sysfs interface for touchpad state

2017-05-03 Thread Andy Shevchenko
On Wed, May 3, 2017 at 5:36 PM, Ritesh Raj Sarraf wrote: > Resending again, as Google servers are behaving weird lately. > > On Sun, 2017-04-30 at 15:54 +0300, Andy Shevchenko wrote: >> > > the main issue that driver doesn't >> > > send SW_TABLET_MODE event through input device. >> > >> > Well.

Re: [PATCH v4] platform/x86: ideapad-laptop: Add sysfs interface for touchpad state

2017-05-03 Thread Ritesh Raj Sarraf
Resending again, as Google servers are behaving weird lately. On Sun, 2017-04-30 at 15:54 +0300, Andy Shevchenko wrote: > > > the main issue that driver doesn't > > > send SW_TABLET_MODE event through input device. > > > > Well. Yes. That is one part. If SW_TABLET_MODE is done in the driver,

Re: [PATCH v4] platform/x86: ideapad-laptop: Add sysfs interface for touchpad state

2017-05-03 Thread Ritesh Raj Sarraf
Resending again, as Google servers are behaving weird lately. On Sun, 2017-04-30 at 15:54 +0300, Andy Shevchenko wrote: > > > the main issue that driver doesn't > > > send SW_TABLET_MODE event through input device. > > > > Well. Yes. That is one part. If SW_TABLET_MODE is done in the driver,

Re: [PATCH v4] platform/x86: ideapad-laptop: Add sysfs interface for touchpad state

2017-05-01 Thread Darren Hart
On Mon, May 01, 2017 at 11:57:27PM +0530, Ritesh Raj Sarraf wrote: > On Mon, 2017-05-01 at 09:05 -0700, Darren Hart wrote: > > > sysfs ABI for drivers that provide input interface is quite strong for > > > my opinion. It means I'm not totally objecting, but I would accept it > > > if and only if

Re: [PATCH v4] platform/x86: ideapad-laptop: Add sysfs interface for touchpad state

2017-05-01 Thread Darren Hart
On Mon, May 01, 2017 at 11:57:27PM +0530, Ritesh Raj Sarraf wrote: > On Mon, 2017-05-01 at 09:05 -0700, Darren Hart wrote: > > > sysfs ABI for drivers that provide input interface is quite strong for > > > my opinion. It means I'm not totally objecting, but I would accept it > > > if and only if

Re: [PATCH v4] platform/x86: ideapad-laptop: Add sysfs interface for touchpad state

2017-05-01 Thread Ritesh Raj Sarraf
On Mon, 2017-05-01 at 09:05 -0700, Darren Hart wrote: > > sysfs ABI for drivers that provide input interface is quite strong for > > my opinion. It means I'm not totally objecting, but I would accept it > > if and only if there is nothing else could be done. > > Agreed, we've recently wanted to

Re: [PATCH v4] platform/x86: ideapad-laptop: Add sysfs interface for touchpad state

2017-05-01 Thread Ritesh Raj Sarraf
On Mon, 2017-05-01 at 09:05 -0700, Darren Hart wrote: > > sysfs ABI for drivers that provide input interface is quite strong for > > my opinion. It means I'm not totally objecting, but I would accept it > > if and only if there is nothing else could be done. > > Agreed, we've recently wanted to

Re: [PATCH v4] platform/x86: ideapad-laptop: Add sysfs interface for touchpad state

2017-05-01 Thread Darren Hart
On Sun, Apr 30, 2017 at 03:54:43PM +0300, Andy Shevchenko wrote: > On Sat, Apr 29, 2017 at 9:52 AM, Ritesh Raj Sarraf wrote: > > Hello, > > > > On Fri, 2017-04-28 at 22:17 +0300, Andy Shevchenko wrote: > >> On Wed, Feb 22, 2017 at 12:24 PM, Ritesh Raj Sarraf >

Re: [PATCH v4] platform/x86: ideapad-laptop: Add sysfs interface for touchpad state

2017-05-01 Thread Darren Hart
On Sun, Apr 30, 2017 at 03:54:43PM +0300, Andy Shevchenko wrote: > On Sat, Apr 29, 2017 at 9:52 AM, Ritesh Raj Sarraf wrote: > > Hello, > > > > On Fri, 2017-04-28 at 22:17 +0300, Andy Shevchenko wrote: > >> On Wed, Feb 22, 2017 at 12:24 PM, Ritesh Raj Sarraf > >> wrote: > >> > >> > Any further

Re: [PATCH v4] platform/x86: ideapad-laptop: Add sysfs interface for touchpad state

2017-04-30 Thread Andy Shevchenko
On Sat, Apr 29, 2017 at 9:52 AM, Ritesh Raj Sarraf wrote: > Hello, > > On Fri, 2017-04-28 at 22:17 +0300, Andy Shevchenko wrote: >> On Wed, Feb 22, 2017 at 12:24 PM, Ritesh Raj Sarraf wrote: >> >> > Any further comment on this patch ? Will this be accepted ? >>

Re: [PATCH v4] platform/x86: ideapad-laptop: Add sysfs interface for touchpad state

2017-04-30 Thread Andy Shevchenko
On Sat, Apr 29, 2017 at 9:52 AM, Ritesh Raj Sarraf wrote: > Hello, > > On Fri, 2017-04-28 at 22:17 +0300, Andy Shevchenko wrote: >> On Wed, Feb 22, 2017 at 12:24 PM, Ritesh Raj Sarraf wrote: >> >> > Any further comment on this patch ? Will this be accepted ? >> > Please give a N/ACK. >> >> Sorry

Re: [PATCH v4] platform/x86: ideapad-laptop: Add sysfs interface for touchpad state

2017-04-29 Thread Ritesh Raj Sarraf
Hello, On Fri, 2017-04-28 at 22:17 +0300, Andy Shevchenko wrote: > On Wed, Feb 22, 2017 at 12:24 PM, Ritesh Raj Sarraf wrote: > > > Any further comment on this patch ? Will this be accepted ? > > Please give a N/ACK. > > Sorry for a long delay, but I can't go with this without

Re: [PATCH v4] platform/x86: ideapad-laptop: Add sysfs interface for touchpad state

2017-04-29 Thread Ritesh Raj Sarraf
Hello, On Fri, 2017-04-28 at 22:17 +0300, Andy Shevchenko wrote: > On Wed, Feb 22, 2017 at 12:24 PM, Ritesh Raj Sarraf wrote: > > > Any further comment on this patch ? Will this be accepted ? > > Please give a N/ACK. > > Sorry for a long delay, but I can't go with this without clear >

Re: [PATCH v4] platform/x86: ideapad-laptop: Add sysfs interface for touchpad state

2017-04-28 Thread Andy Shevchenko
On Wed, Feb 22, 2017 at 12:24 PM, Ritesh Raj Sarraf wrote: > Any further comment on this patch ? Will this be accepted ? > Please give a N/ACK. Sorry for a long delay, but I can't go with this without clear understanding that there is indeed no other ways available. >From what

Re: [PATCH v4] platform/x86: ideapad-laptop: Add sysfs interface for touchpad state

2017-04-28 Thread Andy Shevchenko
On Wed, Feb 22, 2017 at 12:24 PM, Ritesh Raj Sarraf wrote: > Any further comment on this patch ? Will this be accepted ? > Please give a N/ACK. Sorry for a long delay, but I can't go with this without clear understanding that there is indeed no other ways available. >From what I read in the

Re: [PATCH v4] platform/x86: ideapad-laptop: Add sysfs interface for touchpad state

2017-03-01 Thread Andy Shevchenko
On Wed, Feb 22, 2017 at 12:24 PM, Ritesh Raj Sarraf wrote: > Any further comment on this patch ? Will this be accepted ? > Please give a N/ACK. First of all, please do not top post. > On Sat, 2017-02-18 at 00:17 +0530, Ritesh Raj Sarraf wrote: >> Lenovo Yoga (many variants:

Re: [PATCH v4] platform/x86: ideapad-laptop: Add sysfs interface for touchpad state

2017-03-01 Thread Andy Shevchenko
On Wed, Feb 22, 2017 at 12:24 PM, Ritesh Raj Sarraf wrote: > Any further comment on this patch ? Will this be accepted ? > Please give a N/ACK. First of all, please do not top post. > On Sat, 2017-02-18 at 00:17 +0530, Ritesh Raj Sarraf wrote: >> Lenovo Yoga (many variants: Yoga, Yoga2 Pro,

Re: [PATCH v4] platform/x86: ideapad-laptop: Add sysfs interface for touchpad state

2017-02-22 Thread Ritesh Raj Sarraf
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hello Darren / Andy, Any further comment on this patch ? Will this be accepted ? Please give a N/ACK. Thanks, Ritesh On Sat, 2017-02-18 at 00:17 +0530, Ritesh Raj Sarraf wrote: > Lenovo Yoga (many variants: Yoga, Yoga2 Pro, Yoga2 13, Yoga3 Pro,

Re: [PATCH v4] platform/x86: ideapad-laptop: Add sysfs interface for touchpad state

2017-02-22 Thread Ritesh Raj Sarraf
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hello Darren / Andy, Any further comment on this patch ? Will this be accepted ? Please give a N/ACK. Thanks, Ritesh On Sat, 2017-02-18 at 00:17 +0530, Ritesh Raj Sarraf wrote: > Lenovo Yoga (many variants: Yoga, Yoga2 Pro, Yoga2 13, Yoga3 Pro,