Re: [PATCH v5] KVM: VMX: Fix enable VPID conditions

2017-03-23 Thread Paolo Bonzini
On 23/03/2017 13:30, Wanpeng Li wrote: > From: Wanpeng Li > > This can be reproduced by running L2 on L1, and disable VPID on L0 > if w/o commit "KVM: nVMX: Fix nested VPID vmx exec control", the L2 > crash as below: > > KVM: entry failed, hardware error 0x7 >

Re: [PATCH v5] KVM: VMX: Fix enable VPID conditions

2017-03-23 Thread Paolo Bonzini
On 23/03/2017 13:30, Wanpeng Li wrote: > From: Wanpeng Li > > This can be reproduced by running L2 on L1, and disable VPID on L0 > if w/o commit "KVM: nVMX: Fix nested VPID vmx exec control", the L2 > crash as below: > > KVM: entry failed, hardware error 0x7 > EAX= EBX=

Re: [PATCH v5] KVM: VMX: Fix enable VPID conditions

2017-03-23 Thread Jim Mattson
On Thu, Mar 23, 2017 at 5:30 AM, Wanpeng Li wrote: > From: Wanpeng Li > > This can be reproduced by running L2 on L1, and disable VPID on L0 > if w/o commit "KVM: nVMX: Fix nested VPID vmx exec control", the L2 > crash as below: > > KVM: entry failed,

Re: [PATCH v5] KVM: VMX: Fix enable VPID conditions

2017-03-23 Thread Jim Mattson
On Thu, Mar 23, 2017 at 5:30 AM, Wanpeng Li wrote: > From: Wanpeng Li > > This can be reproduced by running L2 on L1, and disable VPID on L0 > if w/o commit "KVM: nVMX: Fix nested VPID vmx exec control", the L2 > crash as below: > > KVM: entry failed, hardware error 0x7 > EAX=

Re: [PATCH v5] KVM: VMX: Fix enable VPID conditions

2017-03-23 Thread David Hildenbrand
> - if (!cpu_has_vmx_vpid()) > + if (!cpu_has_vmx_vpid() || !cpu_has_vmx_invvpid() || > + !(cpu_has_vmx_invvpid_single() || cpu_has_vmx_invvpid_global())) I still don't like this way of indentation, but looks like I am the only one complaining :) So I think this patch is

Re: [PATCH v5] KVM: VMX: Fix enable VPID conditions

2017-03-23 Thread David Hildenbrand
> - if (!cpu_has_vmx_vpid()) > + if (!cpu_has_vmx_vpid() || !cpu_has_vmx_invvpid() || > + !(cpu_has_vmx_invvpid_single() || cpu_has_vmx_invvpid_global())) I still don't like this way of indentation, but looks like I am the only one complaining :) So I think this patch is