Re: [PATCHv2 2/4] dmaengine: dw_dmac: Add PCI part of the driver

2012-09-27 Thread Arnd Bergmann
On Thursday 27 September 2012, Vinod Koul wrote: > > where the first one is called by the other two, depending on the bus type. > > This could be done either splitting the driver into multiple files so you > > can > > have the platform and pci parts in separate driver modules depending on the > >

Re: [PATCHv2 2/4] dmaengine: dw_dmac: Add PCI part of the driver

2012-09-27 Thread Vinod Koul
On Thu, 2012-09-27 at 07:41 +, Arnd Bergmann wrote: > On Thursday 27 September 2012, viresh kumar wrote: > > I believe there is no common initialization part here, because PCI device > > in any > > case would be calling probe of platform device. :) > > Looking at the driver more closely now.

Re: [PATCHv2 2/4] dmaengine: dw_dmac: Add PCI part of the driver

2012-09-27 Thread Arnd Bergmann
On Thursday 27 September 2012, viresh kumar wrote: > I believe there is no common initialization part here, because PCI device in > any > case would be calling probe of platform device. :) Looking at the driver more closely now. Right now, it only supports platform devices, and the dw_probe

Re: [PATCHv2 2/4] dmaengine: dw_dmac: Add PCI part of the driver

2012-09-27 Thread Arnd Bergmann
On Thursday 27 September 2012, viresh kumar wrote: I believe there is no common initialization part here, because PCI device in any case would be calling probe of platform device. :) Looking at the driver more closely now. Right now, it only supports platform devices, and the dw_probe

Re: [PATCHv2 2/4] dmaengine: dw_dmac: Add PCI part of the driver

2012-09-27 Thread Vinod Koul
On Thu, 2012-09-27 at 07:41 +, Arnd Bergmann wrote: On Thursday 27 September 2012, viresh kumar wrote: I believe there is no common initialization part here, because PCI device in any case would be calling probe of platform device. :) Looking at the driver more closely now. Right

Re: [PATCHv2 2/4] dmaengine: dw_dmac: Add PCI part of the driver

2012-09-27 Thread Arnd Bergmann
On Thursday 27 September 2012, Vinod Koul wrote: where the first one is called by the other two, depending on the bus type. This could be done either splitting the driver into multiple files so you can have the platform and pci parts in separate driver modules depending on the common

Re: [PATCHv2 2/4] dmaengine: dw_dmac: Add PCI part of the driver

2012-09-26 Thread viresh kumar
On Thu, Sep 27, 2012 at 1:11 AM, Arnd Bergmann wrote: > On Wednesday 26 September 2012, Andy Shevchenko wrote: >> >> +#define DRIVER(_is_private, _chan_order, _chan_pri)\ >> >> + ((kernel_ulong_t)&(struct dw_dma_platform_data) { \ >> >> + .is_private =

Re: [PATCHv2 2/4] dmaengine: dw_dmac: Add PCI part of the driver

2012-09-26 Thread Arnd Bergmann
On Wednesday 26 September 2012, Andy Shevchenko wrote: > On Wed, Sep 26, 2012 at 5:33 PM, viresh kumar wrote: > > On Wed, Sep 26, 2012 at 6:10 PM, Andy Shevchenko > > wrote: > >> diff --git a/drivers/dma/dw_dmac_pci.c b/drivers/dma/dw_dmac_pci.c > >> +#include > >> +#include > >> +#include >

Re: [PATCHv2 2/4] dmaengine: dw_dmac: Add PCI part of the driver

2012-09-26 Thread Andy Shevchenko
On Wed, Sep 26, 2012 at 5:33 PM, viresh kumar wrote: > Forgot earlier, please keep spear-devel in cc... They will be going to > use dw_dmac driver :) Oh, my bad. v3 will be Cc'ed there as well. Sorry. > On Wed, Sep 26, 2012 at 6:10 PM, Andy Shevchenko > wrote: >> diff --git

Re: [PATCHv2 2/4] dmaengine: dw_dmac: Add PCI part of the driver

2012-09-26 Thread viresh kumar
Forgot earlier, please keep spear-devel in cc... They will be going to use dw_dmac driver :) On Wed, Sep 26, 2012 at 6:10 PM, Andy Shevchenko wrote: > diff --git a/drivers/dma/dw_dmac_pci.c b/drivers/dma/dw_dmac_pci.c > +#include > +#include > +#include > +#include > + > +#define

Re: [PATCHv2 2/4] dmaengine: dw_dmac: Add PCI part of the driver

2012-09-26 Thread viresh kumar
Forgot earlier, please keep spear-devel in cc... They will be going to use dw_dmac driver :) On Wed, Sep 26, 2012 at 6:10 PM, Andy Shevchenko andriy.shevche...@linux.intel.com wrote: diff --git a/drivers/dma/dw_dmac_pci.c b/drivers/dma/dw_dmac_pci.c +#include linux/module.h +#include

Re: [PATCHv2 2/4] dmaengine: dw_dmac: Add PCI part of the driver

2012-09-26 Thread Andy Shevchenko
On Wed, Sep 26, 2012 at 5:33 PM, viresh kumar viresh.ku...@linaro.org wrote: Forgot earlier, please keep spear-devel in cc... They will be going to use dw_dmac driver :) Oh, my bad. v3 will be Cc'ed there as well. Sorry. On Wed, Sep 26, 2012 at 6:10 PM, Andy Shevchenko

Re: [PATCHv2 2/4] dmaengine: dw_dmac: Add PCI part of the driver

2012-09-26 Thread Arnd Bergmann
On Wednesday 26 September 2012, Andy Shevchenko wrote: On Wed, Sep 26, 2012 at 5:33 PM, viresh kumar viresh.ku...@linaro.org wrote: On Wed, Sep 26, 2012 at 6:10 PM, Andy Shevchenko andriy.shevche...@linux.intel.com wrote: diff --git a/drivers/dma/dw_dmac_pci.c b/drivers/dma/dw_dmac_pci.c

Re: [PATCHv2 2/4] dmaengine: dw_dmac: Add PCI part of the driver

2012-09-26 Thread viresh kumar
On Thu, Sep 27, 2012 at 1:11 AM, Arnd Bergmann a...@arndb.de wrote: On Wednesday 26 September 2012, Andy Shevchenko wrote: +#define DRIVER(_is_private, _chan_order, _chan_pri)\ + ((kernel_ulong_t)(struct dw_dma_platform_data) { \ + .is_private =