Re: [RFC PATCH 8/17] input: RMI4 F09 Built-In Self Test

2012-09-04 Thread Christopher Heiny
On 08/27/2012 03:07 PM, Linus Walleij wrote: [snip] >+static struct device_attribute attrs[] = { >+ __ATTR(status, RMI_RW_ATTR, >+ rmi_f09_status_show, rmi_f09_status_store), >+ __ATTR(limitRegisterCount, RMI_RO_ATTR, >+

Re: [RFC PATCH 8/17] input: RMI4 F09 Built-In Self Test

2012-09-04 Thread Christopher Heiny
On 08/27/2012 03:07 PM, Linus Walleij wrote: [snip] +static struct device_attribute attrs[] = { + __ATTR(status, RMI_RW_ATTR, + rmi_f09_status_show, rmi_f09_status_store), + __ATTR(limitRegisterCount, RMI_RO_ATTR, + rmi_f09_limit_register_count_show,

Re: [RFC PATCH 8/17] input: RMI4 F09 Built-In Self Test

2012-08-27 Thread Linus Walleij
On Fri, Aug 17, 2012 at 3:17 PM, Christopher Heiny wrote: Put in a verbose description of what this is. (...) > +++ b/drivers/input/rmi4/rmi_f09.c > +/* data specific to fn $09 that needs to be kept around */ > +struct f09_query { > + u8 limit_register_count; > + union { > +

Re: [RFC PATCH 8/17] input: RMI4 F09 Built-In Self Test

2012-08-27 Thread Linus Walleij
On Fri, Aug 17, 2012 at 3:17 PM, Christopher Heiny che...@synaptics.com wrote: Put in a verbose description of what this is. (...) +++ b/drivers/input/rmi4/rmi_f09.c +/* data specific to fn $09 that needs to be kept around */ +struct f09_query { + u8 limit_register_count; +