Re: Stop SSD from waiting for "Spinning up disk..."

2015-06-25 Thread Joe Perches
On Thu, 2015-06-25 at 13:21 -0300, Henrique de Moraes Holschuh wrote: > On Mon, 22 Jun 2015, Jeff Chua wrote: > > There's no need to wait for disk spin-up for USB SSD devices. This patch > > No, you have to, instead, wait for SSD firmware startup. > > And looking at the contents of

Re: Stop SSD from waiting for "Spinning up disk..."

2015-06-25 Thread Henrique de Moraes Holschuh
On Mon, 22 Jun 2015, Jeff Chua wrote: > There's no need to wait for disk spin-up for USB SSD devices. This patch No, you have to, instead, wait for SSD firmware startup. And looking at the contents of sd_spinup_disk(), I don't think it is safe to just skip it, either. It would be be better to

Re: Stop SSD from waiting for "Spinning up disk..."

2015-06-25 Thread Jeff Chua
On Thu, Jun 25, 2015 at 2:08 PM, Martin Steigerwald wrote: > Am Mittwoch, 24. Juni 2015, 18:41:52 schrieb Greg Kroah-Hartman: >> On Thu, Jun 25, 2015 at 07:55:45AM +0800, Jeff Chua wrote: >> > On Thu, Jun 25, 2015 at 12:28 AM, Greg Kroah-Hartman >> > >> > wrote: >> > > On Thu, Jun 25, 2015 at

Re: Stop SSD from waiting for "Spinning up disk..."

2015-06-25 Thread Martin Steigerwald
Am Mittwoch, 24. Juni 2015, 18:41:52 schrieb Greg Kroah-Hartman: > On Thu, Jun 25, 2015 at 07:55:45AM +0800, Jeff Chua wrote: > > On Thu, Jun 25, 2015 at 12:28 AM, Greg Kroah-Hartman > > > > wrote: > > > On Thu, Jun 25, 2015 at 12:22:47AM +0800, Jeff Chua wrote: > > >> Both sda and sdb have the

Re: Stop SSD from waiting for Spinning up disk...

2015-06-25 Thread Henrique de Moraes Holschuh
On Mon, 22 Jun 2015, Jeff Chua wrote: There's no need to wait for disk spin-up for USB SSD devices. This patch No, you have to, instead, wait for SSD firmware startup. And looking at the contents of sd_spinup_disk(), I don't think it is safe to just skip it, either. It would be be better to

Re: Stop SSD from waiting for Spinning up disk...

2015-06-25 Thread Joe Perches
On Thu, 2015-06-25 at 13:21 -0300, Henrique de Moraes Holschuh wrote: On Mon, 22 Jun 2015, Jeff Chua wrote: There's no need to wait for disk spin-up for USB SSD devices. This patch No, you have to, instead, wait for SSD firmware startup. And looking at the contents of sd_spinup_disk(), I

Re: Stop SSD from waiting for Spinning up disk...

2015-06-25 Thread Martin Steigerwald
Am Mittwoch, 24. Juni 2015, 18:41:52 schrieb Greg Kroah-Hartman: On Thu, Jun 25, 2015 at 07:55:45AM +0800, Jeff Chua wrote: On Thu, Jun 25, 2015 at 12:28 AM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Thu, Jun 25, 2015 at 12:22:47AM +0800, Jeff Chua wrote: Both sda and

Re: Stop SSD from waiting for Spinning up disk...

2015-06-25 Thread Jeff Chua
On Thu, Jun 25, 2015 at 2:08 PM, Martin Steigerwald mar...@lichtvoll.de wrote: Am Mittwoch, 24. Juni 2015, 18:41:52 schrieb Greg Kroah-Hartman: On Thu, Jun 25, 2015 at 07:55:45AM +0800, Jeff Chua wrote: On Thu, Jun 25, 2015 at 12:28 AM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote:

Re: Stop SSD from waiting for "Spinning up disk..."

2015-06-24 Thread Greg Kroah-Hartman
On Thu, Jun 25, 2015 at 07:55:45AM +0800, Jeff Chua wrote: > On Thu, Jun 25, 2015 at 12:28 AM, Greg Kroah-Hartman > wrote: > > On Thu, Jun 25, 2015 at 12:22:47AM +0800, Jeff Chua wrote: > > >> Both sda and sdb have the same SSD model. > > > > That's a bug in your USB bridge chip, odds are it is

Re: Stop SSD from waiting for "Spinning up disk..."

2015-06-24 Thread Jeff Chua
On Thu, Jun 25, 2015 at 12:28 AM, Greg Kroah-Hartman wrote: > On Thu, Jun 25, 2015 at 12:22:47AM +0800, Jeff Chua wrote: >> Both sda and sdb have the same SSD model. > > That's a bug in your USB bridge chip, odds are it is not reporting the > value properly. There's nothing the scsi core or USB

Re: Stop SSD from waiting for "Spinning up disk..."

2015-06-24 Thread Greg Kroah-Hartman
On Thu, Jun 25, 2015 at 12:22:47AM +0800, Jeff Chua wrote: > On Wed, Jun 24, 2015 at 2:55 AM, Martin Steigerwald > wrote: > > Am Dienstag, 23. Juni 2015, 20:26:12 schriebst Du: > >> Hi, > > > > Hi, > > > >> [proper In-Reply-To trail missing since lkml.org now fails to provide it] > > […] > >> >

Re: Stop SSD from waiting for "Spinning up disk..."

2015-06-24 Thread Jeff Chua
On Wed, Jun 24, 2015 at 2:55 AM, Martin Steigerwald wrote: > Am Dienstag, 23. Juni 2015, 20:26:12 schriebst Du: >> Hi, > > Hi, > >> [proper In-Reply-To trail missing since lkml.org now fails to provide it] > […] >> > Greg, >> > >> > SSD is coming mainstream and it doesn't make sense wasting time

Re: Stop SSD from waiting for Spinning up disk...

2015-06-24 Thread Greg Kroah-Hartman
On Thu, Jun 25, 2015 at 07:55:45AM +0800, Jeff Chua wrote: On Thu, Jun 25, 2015 at 12:28 AM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Thu, Jun 25, 2015 at 12:22:47AM +0800, Jeff Chua wrote: Both sda and sdb have the same SSD model. That's a bug in your USB bridge chip,

Re: Stop SSD from waiting for Spinning up disk...

2015-06-24 Thread Jeff Chua
On Thu, Jun 25, 2015 at 12:28 AM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Thu, Jun 25, 2015 at 12:22:47AM +0800, Jeff Chua wrote: Both sda and sdb have the same SSD model. That's a bug in your USB bridge chip, odds are it is not reporting the value properly. There's nothing

Re: Stop SSD from waiting for Spinning up disk...

2015-06-24 Thread Greg Kroah-Hartman
On Thu, Jun 25, 2015 at 12:22:47AM +0800, Jeff Chua wrote: On Wed, Jun 24, 2015 at 2:55 AM, Martin Steigerwald mar...@lichtvoll.de wrote: Am Dienstag, 23. Juni 2015, 20:26:12 schriebst Du: Hi, Hi, [proper In-Reply-To trail missing since lkml.org now fails to provide it] […]

Re: Stop SSD from waiting for Spinning up disk...

2015-06-24 Thread Jeff Chua
On Wed, Jun 24, 2015 at 2:55 AM, Martin Steigerwald mar...@lichtvoll.de wrote: Am Dienstag, 23. Juni 2015, 20:26:12 schriebst Du: Hi, Hi, [proper In-Reply-To trail missing since lkml.org now fails to provide it] […] Greg, SSD is coming mainstream and it doesn't make sense wasting time

Re: Stop SSD from waiting for "Spinning up disk..."

2015-06-23 Thread Marc Burkhardt
You might want to grep for QUEUE_FLAG_NONROT or queue_nonrot_entry... Regards, Marc P.S: sent from mobile, might be short. Am 23. Juni 2015 17:02:22 MESZ, schrieb Jeff Chua : >On Mon, Jun 22, 2015 at 11:36 PM, Greg Kroah-Hartman > wrote: >> On Mon, Jun 22, 2015 at 03:25:29PM +0800, Jeff Chua

Re: Stop SSD from waiting for "Spinning up disk..."

2015-06-23 Thread Martin Steigerwald
Am Dienstag, 23. Juni 2015, 20:26:12 schriebst Du: > Hi, Hi, > [proper In-Reply-To trail missing since lkml.org now fails to provide it] […] > > Greg, > > > > SSD is coming mainstream and it doesn't make sense wasting time > > spinning up "disk" ... > > ...which probably is not truly being

Re: Stop SSD from waiting for "Spinning up disk..."

2015-06-23 Thread Frans Klaver
On Tue, Jun 23, 2015 at 5:02 PM, Jeff Chua wrote: > On Mon, Jun 22, 2015 at 11:36 PM, Greg Kroah-Hartman > wrote: >> On Mon, Jun 22, 2015 at 03:25:29PM +0800, Jeff Chua wrote: >>> >>> There's no need to wait for disk spin-up for USB SSD devices. This patch >>> allow the SSD to skip waiting disk

Re: Stop SSD from waiting for "Spinning up disk..."

2015-06-23 Thread Andreas Mohr
Hi, [proper In-Reply-To trail missing since lkml.org now fails to provide it] > On Mon, Jun 22, 2015 at 11:36 PM, Greg Kroah-Hartman > wrote: > > On Mon, Jun 22, 2015 at 03:25:29PM +0800, Jeff Chua wrote: > >> > >> There's no need to wait for disk spin-up for USB SSD devices. This > >> patch >

Re: Stop SSD from waiting for "Spinning up disk..."

2015-06-23 Thread Jeff Chua
On Mon, Jun 22, 2015 at 11:36 PM, Greg Kroah-Hartman wrote: > On Mon, Jun 22, 2015 at 03:25:29PM +0800, Jeff Chua wrote: >> >> There's no need to wait for disk spin-up for USB SSD devices. This patch >> allow the SSD to skip waiting disk spin-up by passing sd_mod.ssd=1 during >> boot-up. >> >> If

Re: Stop SSD from waiting for Spinning up disk...

2015-06-23 Thread Jeff Chua
On Mon, Jun 22, 2015 at 11:36 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Mon, Jun 22, 2015 at 03:25:29PM +0800, Jeff Chua wrote: There's no need to wait for disk spin-up for USB SSD devices. This patch allow the SSD to skip waiting disk spin-up by passing sd_mod.ssd=1 during

Re: Stop SSD from waiting for Spinning up disk...

2015-06-23 Thread Marc Burkhardt
You might want to grep for QUEUE_FLAG_NONROT or queue_nonrot_entry... Regards, Marc P.S: sent from mobile, might be short. Am 23. Juni 2015 17:02:22 MESZ, schrieb Jeff Chua jeff.chua.li...@gmail.com: On Mon, Jun 22, 2015 at 11:36 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Mon,

Re: Stop SSD from waiting for Spinning up disk...

2015-06-23 Thread Andreas Mohr
Hi, [proper In-Reply-To trail missing since lkml.org now fails to provide it] On Mon, Jun 22, 2015 at 11:36 PM, Greg Kroah-Hartman gregkh@xxx wrote: On Mon, Jun 22, 2015 at 03:25:29PM +0800, Jeff Chua wrote: There's no need to wait for disk spin-up for USB SSD devices.

Re: Stop SSD from waiting for Spinning up disk...

2015-06-23 Thread Frans Klaver
On Tue, Jun 23, 2015 at 5:02 PM, Jeff Chua jeff.chua.li...@gmail.com wrote: On Mon, Jun 22, 2015 at 11:36 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Mon, Jun 22, 2015 at 03:25:29PM +0800, Jeff Chua wrote: There's no need to wait for disk spin-up for USB SSD devices. This

Re: Stop SSD from waiting for Spinning up disk...

2015-06-23 Thread Martin Steigerwald
Am Dienstag, 23. Juni 2015, 20:26:12 schriebst Du: Hi, Hi, [proper In-Reply-To trail missing since lkml.org now fails to provide it] […] Greg, SSD is coming mainstream and it doesn't make sense wasting time spinning up disk ... ...which probably is not truly being achieved by

Re: Stop SSD from waiting for "Spinning up disk..."

2015-06-22 Thread Greg Kroah-Hartman
On Mon, Jun 22, 2015 at 03:25:29PM +0800, Jeff Chua wrote: > > There's no need to wait for disk spin-up for USB SSD devices. This patch > allow the SSD to skip waiting disk spin-up by passing sd_mod.ssd=1 during > boot-up. > > If there's a better way to handle this, please share. Module

Stop SSD from waiting for "Spinning up disk..."

2015-06-22 Thread Jeff Chua
There's no need to wait for disk spin-up for USB SSD devices. This patch allow the SSD to skip waiting disk spin-up by passing sd_mod.ssd=1 during boot-up. If there's a better way to handle this, please share. Thanks, Jeff --- linux/drivers/scsi/sd.c 2015-05-25 07:29:44.0

Re: Stop SSD from waiting for Spinning up disk...

2015-06-22 Thread Greg Kroah-Hartman
On Mon, Jun 22, 2015 at 03:25:29PM +0800, Jeff Chua wrote: There's no need to wait for disk spin-up for USB SSD devices. This patch allow the SSD to skip waiting disk spin-up by passing sd_mod.ssd=1 during boot-up. If there's a better way to handle this, please share. Module parameters

Stop SSD from waiting for Spinning up disk...

2015-06-22 Thread Jeff Chua
There's no need to wait for disk spin-up for USB SSD devices. This patch allow the SSD to skip waiting disk spin-up by passing sd_mod.ssd=1 during boot-up. If there's a better way to handle this, please share. Thanks, Jeff --- linux/drivers/scsi/sd.c 2015-05-25 07:29:44.0