Re: WARNING: bad unlock balance in xfs_iunlock

On Fri, May 11, 2018 at 10:59:53AM +0200, Dmitry Vyukov wrote: > On Thu, May 10, 2018 at 1:22 AM, Dave Chinner wrote: > > On Wed, May 09, 2018 at 10:43:05AM +0200, Dmitry Vyukov wrote: > >> Does "xfstests fuzzing infrastructure" use coverage-guidance? > > > > It's guided

Re: WARNING: bad unlock balance in xfs_iunlock

On Fri, May 11, 2018 at 10:59:53AM +0200, Dmitry Vyukov wrote: > On Thu, May 10, 2018 at 1:22 AM, Dave Chinner wrote: > > On Wed, May 09, 2018 at 10:43:05AM +0200, Dmitry Vyukov wrote: > >> Does "xfstests fuzzing infrastructure" use coverage-guidance? > > > > It's guided manually to fuzz a

Re: WARNING: bad unlock balance in xfs_iunlock

On Thu, May 10, 2018 at 1:22 AM, Dave Chinner wrote: > On Wed, May 09, 2018 at 10:43:05AM +0200, Dmitry Vyukov wrote: >> Does "xfstests fuzzing infrastructure" use coverage-guidance? > > It's guided manually to fuzz a substantial proportion of the fields > in the on-disk

Re: WARNING: bad unlock balance in xfs_iunlock

On Thu, May 10, 2018 at 1:22 AM, Dave Chinner wrote: > On Wed, May 09, 2018 at 10:43:05AM +0200, Dmitry Vyukov wrote: >> Does "xfstests fuzzing infrastructure" use coverage-guidance? > > It's guided manually to fuzz a substantial proportion of the fields > in the on-disk format that are

Re: WARNING: bad unlock balance in xfs_iunlock

On Wed, May 09, 2018 at 10:43:05AM +0200, Dmitry Vyukov wrote: > Does "xfstests fuzzing infrastructure" use coverage-guidance? It's guided manually to fuzz a substantial proportion of the fields in the on-disk format that are susceptible to fuzzing bqased attacks. It's not complete coverage yet,

Re: WARNING: bad unlock balance in xfs_iunlock

On Wed, May 09, 2018 at 10:43:05AM +0200, Dmitry Vyukov wrote: > Does "xfstests fuzzing infrastructure" use coverage-guidance? It's guided manually to fuzz a substantial proportion of the fields in the on-disk format that are susceptible to fuzzing bqased attacks. It's not complete coverage yet,

Re: WARNING: bad unlock balance in xfs_iunlock

On Wed, May 9, 2018 at 3:55 PM, Theodore Y. Ts'o wrote: C reproducer: https://syzkaller.appspot.com/x/repro.c?id=5719304272084992 syzkaller reproducer: https://syzkaller.appspot.com/x/repro.syz?id=5767783983874048 >>> >>> What a mess. A hand built, hopelessly broken

Re: WARNING: bad unlock balance in xfs_iunlock

On Wed, May 9, 2018 at 3:55 PM, Theodore Y. Ts'o wrote: C reproducer: https://syzkaller.appspot.com/x/repro.c?id=5719304272084992 syzkaller reproducer: https://syzkaller.appspot.com/x/repro.syz?id=5767783983874048 >>> >>> What a mess. A hand built, hopelessly broken filesystem

Re: WARNING: bad unlock balance in xfs_iunlock

>>> C reproducer: https://syzkaller.appspot.com/x/repro.c?id=5719304272084992 >>> syzkaller reproducer: >>> https://syzkaller.appspot.com/x/repro.syz?id=5767783983874048 >> >> What a mess. A hand built, hopelessly broken filesystem image made >> up of hex dumps, written into a mmap()d region of

Re: WARNING: bad unlock balance in xfs_iunlock

>>> C reproducer: https://syzkaller.appspot.com/x/repro.c?id=5719304272084992 >>> syzkaller reproducer: >>> https://syzkaller.appspot.com/x/repro.syz?id=5767783983874048 >> >> What a mess. A hand built, hopelessly broken filesystem image made >> up of hex dumps, written into a mmap()d region of

Re: WARNING: bad unlock balance in xfs_iunlock

On Wed, May 9, 2018 at 4:48 AM, Eric Sandeen wrote: > > > On 5/8/18 2:52 AM, Dmitry Vyukov wrote: >>> Or put another way, how did you arrive at the fs image values in the >>> reproducer, >>> i.e.: >> Currently they are completely random, nobody taught syzkaller about AGFs,

Re: WARNING: bad unlock balance in xfs_iunlock

On Wed, May 9, 2018 at 4:48 AM, Eric Sandeen wrote: > > > On 5/8/18 2:52 AM, Dmitry Vyukov wrote: >>> Or put another way, how did you arrive at the fs image values in the >>> reproducer, >>> i.e.: >> Currently they are completely random, nobody taught syzkaller about AGFs, >> etc. > > So you

Re: WARNING: bad unlock balance in xfs_iunlock

On 5/8/18 9:37 PM, Eric Biggers wrote: > On Wed, May 09, 2018 at 10:50:11AM +1000, Dave Chinner wrote: >> On Tue, May 08, 2018 at 09:56:01AM +0200, Dmitry Vyukov wrote: >>> On Wed, May 2, 2018 at 12:51 AM, Dave Chinner wrote: Hello, syzbot hit the

Re: WARNING: bad unlock balance in xfs_iunlock

On 5/8/18 9:37 PM, Eric Biggers wrote: > On Wed, May 09, 2018 at 10:50:11AM +1000, Dave Chinner wrote: >> On Tue, May 08, 2018 at 09:56:01AM +0200, Dmitry Vyukov wrote: >>> On Wed, May 2, 2018 at 12:51 AM, Dave Chinner wrote: Hello, syzbot hit the following crash on

Re: WARNING: bad unlock balance in xfs_iunlock

On 5/8/18 2:52 AM, Dmitry Vyukov wrote: >> Or put another way, how did you arrive at the fs image values in the >> reproducer, >> i.e.: > Currently they are completely random, nobody taught syzkaller about AGFs, etc. So you just combine a few megabytes of purely random bits out of thin air

Re: WARNING: bad unlock balance in xfs_iunlock

On 5/8/18 2:52 AM, Dmitry Vyukov wrote: >> Or put another way, how did you arrive at the fs image values in the >> reproducer, >> i.e.: > Currently they are completely random, nobody taught syzkaller about AGFs, etc. So you just combine a few megabytes of purely random bits out of thin air

Re: WARNING: bad unlock balance in xfs_iunlock

On Wed, May 09, 2018 at 10:50:11AM +1000, Dave Chinner wrote: > On Tue, May 08, 2018 at 09:56:01AM +0200, Dmitry Vyukov wrote: > > On Wed, May 2, 2018 at 12:51 AM, Dave Chinner wrote: > > >> >>> Hello, > > >> >>> > > >> >>> syzbot hit the following crash on upstream commit >

Re: WARNING: bad unlock balance in xfs_iunlock

On Wed, May 09, 2018 at 10:50:11AM +1000, Dave Chinner wrote: > On Tue, May 08, 2018 at 09:56:01AM +0200, Dmitry Vyukov wrote: > > On Wed, May 2, 2018 at 12:51 AM, Dave Chinner wrote: > > >> >>> Hello, > > >> >>> > > >> >>> syzbot hit the following crash on upstream commit > > >> >>>

Re: WARNING: bad unlock balance in xfs_iunlock

On Tue, May 08, 2018 at 09:56:01AM +0200, Dmitry Vyukov wrote: > On Wed, May 2, 2018 at 12:51 AM, Dave Chinner wrote: > >> >>> Hello, > >> >>> > >> >>> syzbot hit the following crash on upstream commit > >> >>> 86bbbebac1933e6e95e8234c4f7d220c5ddd38bc (Mon Apr 2 18:47:07 2018

Re: WARNING: bad unlock balance in xfs_iunlock

On Tue, May 08, 2018 at 09:56:01AM +0200, Dmitry Vyukov wrote: > On Wed, May 2, 2018 at 12:51 AM, Dave Chinner wrote: > >> >>> Hello, > >> >>> > >> >>> syzbot hit the following crash on upstream commit > >> >>> 86bbbebac1933e6e95e8234c4f7d220c5ddd38bc (Mon Apr 2 18:47:07 2018 > >> >>> +) >

Re: WARNING: bad unlock balance in xfs_iunlock

On Wed, May 2, 2018 at 12:51 AM, Dave Chinner wrote: >> >>> Hello, >> >>> >> >>> syzbot hit the following crash on upstream commit >> >>> 86bbbebac1933e6e95e8234c4f7d220c5ddd38bc (Mon Apr 2 18:47:07 2018 +) >> >>> Merge branch 'ras-core-for-linus' of >> >>>

Re: WARNING: bad unlock balance in xfs_iunlock

On Wed, May 2, 2018 at 12:51 AM, Dave Chinner wrote: >> >>> Hello, >> >>> >> >>> syzbot hit the following crash on upstream commit >> >>> 86bbbebac1933e6e95e8234c4f7d220c5ddd38bc (Mon Apr 2 18:47:07 2018 +) >> >>> Merge branch 'ras-core-for-linus' of >> >>>

Re: WARNING: bad unlock balance in xfs_iunlock

On Mon, Apr 30, 2018 at 5:14 PM, Eric Sandeen wrote: > On 4/30/18 9:02 AM, Dmitry Vyukov wrote: >> On Mon, Apr 30, 2018 at 3:49 PM, Eric Sandeen wrote: > > ... > It just extracted kernel source file name that looked relevant to this crash and

Re: WARNING: bad unlock balance in xfs_iunlock

On Mon, Apr 30, 2018 at 5:14 PM, Eric Sandeen wrote: > On 4/30/18 9:02 AM, Dmitry Vyukov wrote: >> On Mon, Apr 30, 2018 at 3:49 PM, Eric Sandeen wrote: > > ... > It just extracted kernel source file name that looked relevant to this crash and run get_maintainers.pl on it. Also the

Re: WARNING: bad unlock balance in xfs_iunlock

On Mon, Apr 30, 2018 at 5:14 PM, Eric Sandeen wrote: > On 4/30/18 9:02 AM, Dmitry Vyukov wrote: >> On Mon, Apr 30, 2018 at 3:49 PM, Eric Sandeen wrote: > > ... > It just extracted kernel source file name that looked relevant to this crash and

Re: WARNING: bad unlock balance in xfs_iunlock

On Mon, Apr 30, 2018 at 5:14 PM, Eric Sandeen wrote: > On 4/30/18 9:02 AM, Dmitry Vyukov wrote: >> On Mon, Apr 30, 2018 at 3:49 PM, Eric Sandeen wrote: > > ... > It just extracted kernel source file name that looked relevant to this crash and run get_maintainers.pl on it. Also the

Re: WARNING: bad unlock balance in xfs_iunlock

On Mon, Apr 30, 2018 at 5:14 PM, Eric Sandeen wrote: > On 4/30/18 9:02 AM, Dmitry Vyukov wrote: >> Suggestions are welcome. Currently it says "syzbot hit the following >> crash on upstream commit SHA1", which was supposed to mean just the >> state of the source tree when the

Re: WARNING: bad unlock balance in xfs_iunlock

On Mon, Apr 30, 2018 at 5:14 PM, Eric Sandeen wrote: > On 4/30/18 9:02 AM, Dmitry Vyukov wrote: >> Suggestions are welcome. Currently it says "syzbot hit the following >> crash on upstream commit SHA1", which was supposed to mean just the >> state of the source tree when the crash happened. But I

Re: WARNING: bad unlock balance in xfs_iunlock

On Mon, Apr 30, 2018 at 03:24:48PM +0200, Dmitry Vyukov wrote: > On Thu, Apr 5, 2018 at 8:54 PM, Dmitry Vyukov wrote: > > On Tue, Apr 3, 2018 at 6:38 AM, Dave Chinner wrote: > >> On Mon, Apr 02, 2018 at 07:01:02PM -0700, syzbot wrote: > >>> Hello, > >>> >

Re: WARNING: bad unlock balance in xfs_iunlock

On Mon, Apr 30, 2018 at 03:24:48PM +0200, Dmitry Vyukov wrote: > On Thu, Apr 5, 2018 at 8:54 PM, Dmitry Vyukov wrote: > > On Tue, Apr 3, 2018 at 6:38 AM, Dave Chinner wrote: > >> On Mon, Apr 02, 2018 at 07:01:02PM -0700, syzbot wrote: > >>> Hello, > >>> > >>> syzbot hit the following crash on

Re: WARNING: bad unlock balance in xfs_iunlock

On 4/30/18 9:02 AM, Dmitry Vyukov wrote: > On Mon, Apr 30, 2018 at 3:49 PM, Eric Sandeen wrote: ... >>> It just extracted kernel source file name that looked relevant >>> to this crash and run get_maintainers.pl on it. >>> Also the image can contain dynamically generated

Re: WARNING: bad unlock balance in xfs_iunlock

On 4/30/18 9:02 AM, Dmitry Vyukov wrote: > On Mon, Apr 30, 2018 at 3:49 PM, Eric Sandeen wrote: ... >>> It just extracted kernel source file name that looked relevant >>> to this crash and run get_maintainers.pl on it. >>> Also the image can contain dynamically generated data, which makes it

Re: WARNING: bad unlock balance in xfs_iunlock

On Mon, Apr 30, 2018 at 3:49 PM, Eric Sandeen wrote: > On 4/30/18 8:23 AM, Dmitry Vyukov wrote: >> On Mon, Apr 16, 2018 at 9:22 PM, Eric Sandeen wrote: > > ... > >>> It sure /seems/ to have a notion of images: what else is syz_mount_image()? >>> >>> i.e.

Re: WARNING: bad unlock balance in xfs_iunlock

On Mon, Apr 30, 2018 at 3:49 PM, Eric Sandeen wrote: > On 4/30/18 8:23 AM, Dmitry Vyukov wrote: >> On Mon, Apr 16, 2018 at 9:22 PM, Eric Sandeen wrote: > > ... > >>> It sure /seems/ to have a notion of images: what else is syz_mount_image()? >>> >>> i.e. you are mounting an image to reproduce

Re: WARNING: bad unlock balance in xfs_iunlock

On 4/30/18 8:23 AM, Dmitry Vyukov wrote: > On Mon, Apr 16, 2018 at 9:22 PM, Eric Sandeen wrote: ... >> It sure /seems/ to have a notion of images: what else is syz_mount_image()? >> >> i.e. you are mounting an image to reproduce the problem, correct? >> And the system is

Re: WARNING: bad unlock balance in xfs_iunlock

On 4/30/18 8:23 AM, Dmitry Vyukov wrote: > On Mon, Apr 16, 2018 at 9:22 PM, Eric Sandeen wrote: ... >> It sure /seems/ to have a notion of images: what else is syz_mount_image()? >> >> i.e. you are mounting an image to reproduce the problem, correct? >> And the system is "smart" enough to fire

Re: WARNING: bad unlock balance in xfs_iunlock

On Thu, Apr 5, 2018 at 8:54 PM, Dmitry Vyukov wrote: > On Tue, Apr 3, 2018 at 6:38 AM, Dave Chinner wrote: >> On Mon, Apr 02, 2018 at 07:01:02PM -0700, syzbot wrote: >>> Hello, >>> >>> syzbot hit the following crash on upstream commit >>>

Re: WARNING: bad unlock balance in xfs_iunlock

On Thu, Apr 5, 2018 at 8:54 PM, Dmitry Vyukov wrote: > On Tue, Apr 3, 2018 at 6:38 AM, Dave Chinner wrote: >> On Mon, Apr 02, 2018 at 07:01:02PM -0700, syzbot wrote: >>> Hello, >>> >>> syzbot hit the following crash on upstream commit >>> 86bbbebac1933e6e95e8234c4f7d220c5ddd38bc (Mon Apr 2

Re: WARNING: bad unlock balance in xfs_iunlock

ms list. It just extracted kernel source file name that looked relevant to this crash and run get_maintainers.pl on it. Also the image can contain dynamically generated data, which makes it impossible to have as a file at all. Thinking of this, what should be reasonably easy to do and may be a compro

Re: WARNING: bad unlock balance in xfs_iunlock

run get_maintainers.pl on it. Also the image can contain dynamically generated data, which makes it impossible to have as a file at all. Thinking of this, what should be reasonably easy to do and may be a compromise for near future is the following. We could insert code into syz_mount_image() which d

Re: WARNING: bad unlock balance in xfs_iunlock

n email to a filesystem list; if it does so, add a link to the image itself, as you already have already done for the C reproducer. Filesystem images are common parlance for filesystem engineers. When you engage with them you'll have better results if you provide them with inputs t

Re: WARNING: bad unlock balance in xfs_iunlock

to the image itself, as you already have already done for the C reproducer. Filesystem images are common parlance for filesystem engineers. When you engage with them you'll have better results if you provide them with inputs they can use directly instead of requiring them to reverse-engineer your cus

Re: WARNING: bad unlock balance in xfs_iunlock

On Fri, Apr 6, 2018 at 6:10 PM, Darrick J. Wong wrote: > On Fri, Apr 06, 2018 at 07:38:44AM +1000, Dave Chinner wrote: >> On Thu, Apr 05, 2018 at 08:54:50PM +0200, Dmitry Vyukov wrote: >> > On Tue, Apr 3, 2018 at 6:38 AM, Dave Chinner wrote: >> > >

Re: WARNING: bad unlock balance in xfs_iunlock

On Fri, Apr 6, 2018 at 6:10 PM, Darrick J. Wong wrote: > On Fri, Apr 06, 2018 at 07:38:44AM +1000, Dave Chinner wrote: >> On Thu, Apr 05, 2018 at 08:54:50PM +0200, Dmitry Vyukov wrote: >> > On Tue, Apr 3, 2018 at 6:38 AM, Dave Chinner wrote: >> > > On Mon, Apr 02, 2018 at 07:01:02PM -0700,

Re: WARNING: bad unlock balance in xfs_iunlock

On Fri, Apr 06, 2018 at 07:38:44AM +1000, Dave Chinner wrote: > On Thu, Apr 05, 2018 at 08:54:50PM +0200, Dmitry Vyukov wrote: > > On Tue, Apr 3, 2018 at 6:38 AM, Dave Chinner wrote: > > > On Mon, Apr 02, 2018 at 07:01:02PM -0700, syzbot wrote: > > >> Hello, > > >> > > >>

Re: WARNING: bad unlock balance in xfs_iunlock

On Fri, Apr 06, 2018 at 07:38:44AM +1000, Dave Chinner wrote: > On Thu, Apr 05, 2018 at 08:54:50PM +0200, Dmitry Vyukov wrote: > > On Tue, Apr 3, 2018 at 6:38 AM, Dave Chinner wrote: > > > On Mon, Apr 02, 2018 at 07:01:02PM -0700, syzbot wrote: > > >> Hello, > > >> > > >> syzbot hit the following

Re: WARNING: bad unlock balance in xfs_iunlock

On Thu, Apr 05, 2018 at 08:54:50PM +0200, Dmitry Vyukov wrote: > On Tue, Apr 3, 2018 at 6:38 AM, Dave Chinner wrote: > > On Mon, Apr 02, 2018 at 07:01:02PM -0700, syzbot wrote: > >> Hello, > >> > >> syzbot hit the following crash on upstream commit > >>

Re: WARNING: bad unlock balance in xfs_iunlock

On Thu, Apr 05, 2018 at 08:54:50PM +0200, Dmitry Vyukov wrote: > On Tue, Apr 3, 2018 at 6:38 AM, Dave Chinner wrote: > > On Mon, Apr 02, 2018 at 07:01:02PM -0700, syzbot wrote: > >> Hello, > >> > >> syzbot hit the following crash on upstream commit > >> 86bbbebac1933e6e95e8234c4f7d220c5ddd38bc

Re: WARNING: bad unlock balance in xfs_iunlock

On Tue, Apr 3, 2018 at 6:38 AM, Dave Chinner wrote: > On Mon, Apr 02, 2018 at 07:01:02PM -0700, syzbot wrote: >> Hello, >> >> syzbot hit the following crash on upstream commit >> 86bbbebac1933e6e95e8234c4f7d220c5ddd38bc (Mon Apr 2 18:47:07 2018 +) >> Merge branch

Re: WARNING: bad unlock balance in xfs_iunlock

On Tue, Apr 3, 2018 at 6:38 AM, Dave Chinner wrote: > On Mon, Apr 02, 2018 at 07:01:02PM -0700, syzbot wrote: >> Hello, >> >> syzbot hit the following crash on upstream commit >> 86bbbebac1933e6e95e8234c4f7d220c5ddd38bc (Mon Apr 2 18:47:07 2018 +) >> Merge branch 'ras-core-for-linus' of >>

Re: WARNING: bad unlock balance in xfs_iunlock

On Mon, Apr 02, 2018 at 07:01:02PM -0700, syzbot wrote: > Hello, > > syzbot hit the following crash on upstream commit > 86bbbebac1933e6e95e8234c4f7d220c5ddd38bc (Mon Apr 2 18:47:07 2018 +) > Merge branch 'ras-core-for-linus' of > git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip > syzbot

Re: WARNING: bad unlock balance in xfs_iunlock

On Mon, Apr 02, 2018 at 07:01:02PM -0700, syzbot wrote: > Hello, > > syzbot hit the following crash on upstream commit > 86bbbebac1933e6e95e8234c4f7d220c5ddd38bc (Mon Apr 2 18:47:07 2018 +) > Merge branch 'ras-core-for-linus' of > git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip > syzbot

WARNING: bad unlock balance in xfs_iunlock

Hello, syzbot hit the following crash on upstream commit 86bbbebac1933e6e95e8234c4f7d220c5ddd38bc (Mon Apr 2 18:47:07 2018 +) Merge branch 'ras-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip syzbot dashboard link:

WARNING: bad unlock balance in xfs_iunlock

Hello, syzbot hit the following crash on upstream commit 86bbbebac1933e6e95e8234c4f7d220c5ddd38bc (Mon Apr 2 18:47:07 2018 +) Merge branch 'ras-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip syzbot dashboard link: