Re: WARNING in apparmor_secid_to_secctx

2019-02-01 Thread Dmitry Vyukov
On Fri, Feb 1, 2019 at 11:44 AM Tetsuo Handa wrote: > > On 2019/02/01 19:09, Dmitry Vyukov wrote: > > Thanks for the explanations. > > > > Here is the change that I've come up with: > > https://github.com/google/syzkaller/commit/aa53be276dc84aa8b3825b3416542447ff82b41a > > You are not going to

Re: WARNING in apparmor_secid_to_secctx

2019-02-01 Thread Tetsuo Handa
On 2019/02/01 19:09, Dmitry Vyukov wrote: > Thanks for the explanations. > > Here is the change that I've come up with: > https://github.com/google/syzkaller/commit/aa53be276dc84aa8b3825b3416542447ff82b41a You are not going to apply this updated config to upstream kernels now, are you? Removing

Re: WARNING in apparmor_secid_to_secctx

2019-02-01 Thread Dmitry Vyukov
On Fri, Feb 1, 2019 at 11:09 AM Dmitry Vyukov wrote: > > On Thu, Jan 31, 2019 at 1:23 AM Tetsuo Handa > wrote: > > > > On 2019/01/30 23:45, Dmitry Vyukov wrote: > > >> Dmitry, is it possible to update configs for linux-next.git , for > > >> we want to test a big change in LSM which will go to

Re: WARNING in apparmor_secid_to_secctx

2019-02-01 Thread Dmitry Vyukov
On Thu, Jan 31, 2019 at 1:23 AM Tetsuo Handa wrote: > > On 2019/01/30 23:45, Dmitry Vyukov wrote: > >> Dmitry, is it possible to update configs for linux-next.git , for > >> we want to test a big change in LSM which will go to Linux 5.1 ? > >> > >> TOMOYO security module

Re: WARNING in apparmor_secid_to_secctx

2019-01-30 Thread Tetsuo Handa
On 2019/01/30 23:45, Dmitry Vyukov wrote: >> Dmitry, is it possible to update configs for linux-next.git , for >> we want to test a big change in LSM which will go to Linux 5.1 ? >> >> TOMOYO security module (CONFIG_SECURITY_TOMOYO=y) can now coexist with >> SELinux/Smack/AppArmor security

Re: WARNING in apparmor_secid_to_secctx

2019-01-30 Thread Micah Morton
On Wed, Jan 30, 2019 at 6:45 AM Dmitry Vyukov wrote: > > On Tue, Jan 29, 2019 at 12:32 PM Tetsuo Handa > wrote: > > > > On 2018/09/06 19:59, Dmitry Vyukov wrote: > > > On Wed, Sep 5, 2018 at 7:37 PM, Casey Schaufler > > > wrote: > > >> On 9/5/2018 4:08 AM, Dmitry Vyukov wrote: > > >>> Thanks!

Re: WARNING in apparmor_secid_to_secctx

2019-01-30 Thread Dmitry Vyukov
On Tue, Jan 29, 2019 at 12:32 PM Tetsuo Handa wrote: > > On 2018/09/06 19:59, Dmitry Vyukov wrote: > > On Wed, Sep 5, 2018 at 7:37 PM, Casey Schaufler > > wrote: > >> On 9/5/2018 4:08 AM, Dmitry Vyukov wrote: > >>> Thanks! I've re-enabled selinux on syzbot: > >>>

Re: WARNING in apparmor_secid_to_secctx

2019-01-29 Thread Tetsuo Handa
On 2018/09/06 19:59, Dmitry Vyukov wrote: > On Wed, Sep 5, 2018 at 7:37 PM, Casey Schaufler > wrote: >> On 9/5/2018 4:08 AM, Dmitry Vyukov wrote: >>> Thanks! I've re-enabled selinux on syzbot: >>> https://github.com/google/syzkaller/commit/196410e4f5665d4d2bf6c818d06f1c8d03cfa8cc >>> Now we will

Re: WARNING in apparmor_secid_to_secctx

2018-09-01 Thread syzbot
Hello, syzbot has tested the proposed patch and the reproducer did not trigger crash: Reported-and-tested-by: syzbot+21016130b0580a9de...@syzkaller.appspotmail.com Tested on: commit: 22dad84baabf apparmor: fix apparmor_secid_to_secctx incorr.. git tree:

Re: WARNING in apparmor_secid_to_secctx

2018-09-01 Thread syzbot
Hello, syzbot has tested the proposed patch and the reproducer did not trigger crash: Reported-and-tested-by: syzbot+21016130b0580a9de...@syzkaller.appspotmail.com Tested on: commit: 22dad84baabf apparmor: fix apparmor_secid_to_secctx incorr.. git tree:

Re: Re: WARNING in apparmor_secid_to_secctx

2018-09-01 Thread Dmitry Vyukov
po address. > > >> 4.18-syzbot-secid I guess the repo is: #syz test: git://git.kernel.org/pub/scm/linux/kernel/git/jj/linux-apparmor.git 4.18-syzbot-secid >>> --- > > >>> From 22dad84baabf4174f11f5e9b34a05529084fa29c Mon Sep 17 00:00:00 2001 >>> Fro

Re: Re: WARNING in apparmor_secid_to_secctx

2018-09-01 Thread Dmitry Vyukov
po address. > > >> 4.18-syzbot-secid I guess the repo is: #syz test: git://git.kernel.org/pub/scm/linux/kernel/git/jj/linux-apparmor.git 4.18-syzbot-secid >>> --- > > >>> From 22dad84baabf4174f11f5e9b34a05529084fa29c Mon Sep 17 00:00:00 2001 >>> Fro

Re: Re: WARNING in apparmor_secid_to_secctx

2018-09-01 Thread syzbot
---- AppArmor WARN apparmor_secid_to_secctx: ((!secdata)): WARNING: CPU: 0 PID: 14826 at security/apparmor/secid.c:82 apparmor_secid_to_secctx+0x2b5/0x2f0 security/apparmor/secid.c:82 Kernel panic - not syncing: panic_on_warn set ... CPU: 0 PID: 14826 Comm: syz-executor1 Not tainted 4.19.0-rc1+ #193 Hardwa

Re: WARNING in apparmor_secid_to_secctx

2018-09-01 Thread Dmitry Vyukov
test: git://git.kernel.org/pub/scm/linux/kernel/git/jj/linux-apparmor 4.18-syzbot-secid > --- > > From 22dad84baabf4174f11f5e9b34a05529084fa29c Mon Sep 17 00:00:00 2001 > From: John Johansen > Date: Sat, 1 Sep 2018 01:57:52 -0700 > Subject: [PATCH] apparmor: fix apparmor_secid_to_secctx incorrect deb

Re: Re: WARNING in apparmor_secid_to_secctx

2018-09-01 Thread syzbot
---- AppArmor WARN apparmor_secid_to_secctx: ((!secdata)): WARNING: CPU: 0 PID: 14826 at security/apparmor/secid.c:82 apparmor_secid_to_secctx+0x2b5/0x2f0 security/apparmor/secid.c:82 Kernel panic - not syncing: panic_on_warn set ... CPU: 0 PID: 14826 Comm: syz-executor1 Not tainted 4.19.0-rc1+ #193 Hardwa

Re: WARNING in apparmor_secid_to_secctx

2018-09-01 Thread Dmitry Vyukov
test: git://git.kernel.org/pub/scm/linux/kernel/git/jj/linux-apparmor 4.18-syzbot-secid > --- > > From 22dad84baabf4174f11f5e9b34a05529084fa29c Mon Sep 17 00:00:00 2001 > From: John Johansen > Date: Sat, 1 Sep 2018 01:57:52 -0700 > Subject: [PATCH] apparmor: fix apparmor_secid_to_secctx incorrect deb

Re: WARNING in apparmor_secid_to_secctx

2018-09-01 Thread John Johansen
ndition handle by the code. When kconfig SECURITY_APPARMOR_DEBUG is enabled the debug WARN_ON will trip when **secdata is NULL resulting in the following trace. [ cut here ] AppArmor WARN apparmor_secid_to_secctx: ((!secdata)): WARNING: CPU: 0 PID: 14826 at security/apparmor/secid.c:82

Re: WARNING in apparmor_secid_to_secctx

2018-09-01 Thread John Johansen
ndition handle by the code. When kconfig SECURITY_APPARMOR_DEBUG is enabled the debug WARN_ON will trip when **secdata is NULL resulting in the following trace. [ cut here ] AppArmor WARN apparmor_secid_to_secctx: ((!secdata)): WARNING: CPU: 0 PID: 14826 at security/apparmor/secid.c:82

Re: WARNING in apparmor_secid_to_secctx

2018-09-01 Thread Dmitry Vyukov
On Sat, Sep 1, 2018 at 11:18 AM, John Johansen wrote: > On 08/29/2018 07:17 PM, syzbot wrote: >> Hello, >> >> syzbot found the following crash on: >> >> HEAD commit:817e60a7a2bb Merge branch 'nfp-add-NFP5000-support' >> git tree: net-next >> console output:

Re: WARNING in apparmor_secid_to_secctx

2018-09-01 Thread Dmitry Vyukov
On Sat, Sep 1, 2018 at 11:18 AM, John Johansen wrote: > On 08/29/2018 07:17 PM, syzbot wrote: >> Hello, >> >> syzbot found the following crash on: >> >> HEAD commit:817e60a7a2bb Merge branch 'nfp-add-NFP5000-support' >> git tree: net-next >> console output:

Re: WARNING in apparmor_secid_to_secctx

2018-09-01 Thread John Johansen
On 08/29/2018 07:17 PM, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:    817e60a7a2bb Merge branch 'nfp-add-NFP5000-support' > git tree:   net-next > console output: https://syzkaller.appspot.com/x/log.txt?x=1536d29640 > kernel config: 

Re: WARNING in apparmor_secid_to_secctx

2018-09-01 Thread John Johansen
On 08/29/2018 07:17 PM, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:    817e60a7a2bb Merge branch 'nfp-add-NFP5000-support' > git tree:   net-next > console output: https://syzkaller.appspot.com/x/log.txt?x=1536d29640 > kernel config: 

Re: WARNING in apparmor_secid_to_secctx

2018-08-31 Thread Dmitry Vyukov
On Fri, Aug 31, 2018 at 9:17 AM, Stephen Smalley wrote: > On 08/31/2018 12:16 PM, Stephen Smalley wrote: >> >> On 08/31/2018 12:07 PM, Paul Moore wrote: >>> >>> On Fri, Aug 31, 2018 at 12:01 PM Stephen Smalley >>> wrote: On 08/29/2018 10:21 PM, Dmitry Vyukov wrote: > > On Wed,

Re: WARNING in apparmor_secid_to_secctx

2018-08-31 Thread Dmitry Vyukov
On Fri, Aug 31, 2018 at 9:17 AM, Stephen Smalley wrote: > On 08/31/2018 12:16 PM, Stephen Smalley wrote: >> >> On 08/31/2018 12:07 PM, Paul Moore wrote: >>> >>> On Fri, Aug 31, 2018 at 12:01 PM Stephen Smalley >>> wrote: On 08/29/2018 10:21 PM, Dmitry Vyukov wrote: > > On Wed,

Re: WARNING in apparmor_secid_to_secctx

2018-08-31 Thread Stephen Smalley
On 08/31/2018 12:07 PM, Paul Moore wrote: On Fri, Aug 31, 2018 at 12:01 PM Stephen Smalley wrote: On 08/29/2018 10:21 PM, Dmitry Vyukov wrote: On Wed, Aug 29, 2018 at 7:17 PM, syzbot wrote: Hello, syzbot found the following crash on: HEAD commit:817e60a7a2bb Merge branch

Re: WARNING in apparmor_secid_to_secctx

2018-08-31 Thread Stephen Smalley
On 08/31/2018 12:07 PM, Paul Moore wrote: On Fri, Aug 31, 2018 at 12:01 PM Stephen Smalley wrote: On 08/29/2018 10:21 PM, Dmitry Vyukov wrote: On Wed, Aug 29, 2018 at 7:17 PM, syzbot wrote: Hello, syzbot found the following crash on: HEAD commit:817e60a7a2bb Merge branch

Re: WARNING in apparmor_secid_to_secctx

2018-08-31 Thread Stephen Smalley
On 08/31/2018 12:16 PM, Stephen Smalley wrote: On 08/31/2018 12:07 PM, Paul Moore wrote: On Fri, Aug 31, 2018 at 12:01 PM Stephen Smalley wrote: On 08/29/2018 10:21 PM, Dmitry Vyukov wrote: On Wed, Aug 29, 2018 at 7:17 PM, syzbot wrote: Hello, syzbot found the following crash on: HEAD

Re: WARNING in apparmor_secid_to_secctx

2018-08-31 Thread Stephen Smalley
On 08/31/2018 12:16 PM, Stephen Smalley wrote: On 08/31/2018 12:07 PM, Paul Moore wrote: On Fri, Aug 31, 2018 at 12:01 PM Stephen Smalley wrote: On 08/29/2018 10:21 PM, Dmitry Vyukov wrote: On Wed, Aug 29, 2018 at 7:17 PM, syzbot wrote: Hello, syzbot found the following crash on: HEAD

Re: WARNING in apparmor_secid_to_secctx

2018-08-31 Thread Paul Moore
On Fri, Aug 31, 2018 at 12:01 PM Stephen Smalley wrote: > On 08/29/2018 10:21 PM, Dmitry Vyukov wrote: > > On Wed, Aug 29, 2018 at 7:17 PM, syzbot > > wrote: > >> Hello, > >> > >> syzbot found the following crash on: > >> > >> HEAD commit:817e60a7a2bb Merge branch 'nfp-add-NFP5000-support' >

Re: WARNING in apparmor_secid_to_secctx

2018-08-31 Thread Paul Moore
On Fri, Aug 31, 2018 at 12:01 PM Stephen Smalley wrote: > On 08/29/2018 10:21 PM, Dmitry Vyukov wrote: > > On Wed, Aug 29, 2018 at 7:17 PM, syzbot > > wrote: > >> Hello, > >> > >> syzbot found the following crash on: > >> > >> HEAD commit:817e60a7a2bb Merge branch 'nfp-add-NFP5000-support' >

Re: WARNING in apparmor_secid_to_secctx

2018-08-31 Thread Stephen Smalley
are currently getting 1 machine crash/minute on this bug: https://syzkaller.appspot.com/bug?extid=ab1882df6ecbb06d59be [ cut here ] AppArmor WARN apparmor_secid_to_secctx: ((!secdata)): WARNING: CPU: 0 PID: 14826 at security/apparmor/secid.c:82 apparmor_secid_to_secctx+0x2b5/0x2f0

Re: WARNING in apparmor_secid_to_secctx

2018-08-31 Thread Stephen Smalley
are currently getting 1 machine crash/minute on this bug: https://syzkaller.appspot.com/bug?extid=ab1882df6ecbb06d59be [ cut here ] AppArmor WARN apparmor_secid_to_secctx: ((!secdata)): WARNING: CPU: 0 PID: 14826 at security/apparmor/secid.c:82 apparmor_secid_to_secctx+0x2b5/0x2f0

Re: WARNING in apparmor_secid_to_secctx

2018-08-29 Thread syzbot
) [ cut here ] AppArmor WARN apparmor_secid_to_secctx: ((!secdata)): WARNING: CPU: 0 PID: 4682 at security/apparmor/secid.c:82 apparmor_secid_to_secctx+0x2b5/0x2f0 security/apparmor/secid.c:82 Kernel panic - not syncing: panic_on_warn set ... CPU: 0 PID: 4682 Comm: syz

Re: WARNING in apparmor_secid_to_secctx

2018-08-29 Thread syzbot
) [ cut here ] AppArmor WARN apparmor_secid_to_secctx: ((!secdata)): WARNING: CPU: 0 PID: 4682 at security/apparmor/secid.c:82 apparmor_secid_to_secctx+0x2b5/0x2f0 security/apparmor/secid.c:82 Kernel panic - not syncing: panic_on_warn set ... CPU: 0 PID: 4682 Comm: syz

Re: WARNING in apparmor_secid_to_secctx

2018-08-29 Thread Dmitry Vyukov
6f61e3aba21bb89ffb05b5db946 As expedited fix for this as possible would be nice to get, because we are currently getting 1 machine crash/minute on this bug: https://syzkaller.appspot.com/bug?extid=ab1882df6ecbb06d59be > ----[ cut here ]---- > AppArmor WARN apparmor_secid_to

Re: WARNING in apparmor_secid_to_secctx

2018-08-29 Thread Dmitry Vyukov
6f61e3aba21bb89ffb05b5db946 As expedited fix for this as possible would be nice to get, because we are currently getting 1 machine crash/minute on this bug: https://syzkaller.appspot.com/bug?extid=ab1882df6ecbb06d59be > ----[ cut here ]---- > AppArmor WARN apparmor_secid_to

WARNING in apparmor_secid_to_secctx

2018-08-29 Thread syzbot
...@syzkaller.appspotmail.com [ cut here ] AppArmor WARN apparmor_secid_to_secctx: ((!secdata)): WARNING: CPU: 0 PID: 14826 at security/apparmor/secid.c:82 apparmor_secid_to_secctx+0x2b5/0x2f0 security/apparmor/secid.c:82 Kernel panic - not syncing: panic_on_warn set

WARNING in apparmor_secid_to_secctx

2018-08-29 Thread syzbot
...@syzkaller.appspotmail.com [ cut here ] AppArmor WARN apparmor_secid_to_secctx: ((!secdata)): WARNING: CPU: 0 PID: 14826 at security/apparmor/secid.c:82 apparmor_secid_to_secctx+0x2b5/0x2f0 security/apparmor/secid.c:82 Kernel panic - not syncing: panic_on_warn set