Re: WARN_ON_ONCE() hit at kernel/events/core.c:330

2019-04-11 Thread Alexander Shishkin
Peter Zijlstra writes: > On Wed, Apr 10, 2019 at 03:51:24PM +0200, Thomas-Mich Richter wrote: >> Thanks for the fix with commit id 86071b11317550d994b55ce5e31aa06bcad783b5. >> >> However doing an fgrep on the pending_disable member of struct perf_event >> reveals two more hits in file

Re: WARN_ON_ONCE() hit at kernel/events/core.c:330

2019-04-10 Thread Peter Zijlstra
On Wed, Apr 10, 2019 at 03:51:24PM +0200, Thomas-Mich Richter wrote: > Thanks for the fix with commit id 86071b11317550d994b55ce5e31aa06bcad783b5. > > However doing an fgrep on the pending_disable member of struct perf_event > reveals two more hits in file kernel/events/ringbuffer.c when events >

Re: WARN_ON_ONCE() hit at kernel/events/core.c:330

2019-04-10 Thread Thomas-Mich Richter
On 4/9/19 10:53 AM, Mark Rutland wrote: > On Mon, Apr 08, 2019 at 11:50:31AM +0200, Peter Zijlstra wrote: >> On Mon, Apr 08, 2019 at 10:22:29AM +0200, Peter Zijlstra wrote: >>> On Mon, Apr 08, 2019 at 09:12:28AM +0200, Thomas-Mich Richter wrote: >> . >> >> Instead encode the CPU number in

Re: WARN_ON_ONCE() hit at kernel/events/core.c:330

2019-04-09 Thread Mark Rutland
On Mon, Apr 08, 2019 at 11:50:31AM +0200, Peter Zijlstra wrote: > On Mon, Apr 08, 2019 at 10:22:29AM +0200, Peter Zijlstra wrote: > > On Mon, Apr 08, 2019 at 09:12:28AM +0200, Thomas-Mich Richter wrote: > > > > very good news, your fix ran over the weekend without any hit!!! > > > > > > Thanks

Re: WARN_ON_ONCE() hit at kernel/events/core.c:330

2019-04-09 Thread Peter Zijlstra
On Tue, Apr 09, 2019 at 08:07:49AM +0200, Thomas-Mich Richter wrote: > On 4/8/19 11:50 AM, Peter Zijlstra wrote: > > On Mon, Apr 08, 2019 at 10:22:29AM +0200, Peter Zijlstra wrote: > >> On Mon, Apr 08, 2019 at 09:12:28AM +0200, Thomas-Mich Richter wrote: > > > >>> very good news, your fix ran

Re: WARN_ON_ONCE() hit at kernel/events/core.c:330

2019-04-09 Thread Thomas-Mich Richter
On 4/8/19 11:50 AM, Peter Zijlstra wrote: > On Mon, Apr 08, 2019 at 10:22:29AM +0200, Peter Zijlstra wrote: >> On Mon, Apr 08, 2019 at 09:12:28AM +0200, Thomas-Mich Richter wrote: > >>> very good news, your fix ran over the weekend without any hit!!! >>> >>> Thanks very much for your help. Do you

Re: WARN_ON_ONCE() hit at kernel/events/core.c:330

2019-04-08 Thread Thomas-Mich Richter
On 4/8/19 11:50 AM, Peter Zijlstra wrote: > On Mon, Apr 08, 2019 at 10:22:29AM +0200, Peter Zijlstra wrote: >> On Mon, Apr 08, 2019 at 09:12:28AM +0200, Thomas-Mich Richter wrote: > >>> very good news, your fix ran over the weekend without any hit!!! >>> >>> Thanks very much for your help. Do you

Re: WARN_ON_ONCE() hit at kernel/events/core.c:330

2019-04-08 Thread Peter Zijlstra
On Mon, Apr 08, 2019 at 10:22:29AM +0200, Peter Zijlstra wrote: > On Mon, Apr 08, 2019 at 09:12:28AM +0200, Thomas-Mich Richter wrote: > > very good news, your fix ran over the weekend without any hit!!! > > > > Thanks very much for your help. Do you submit this patch to the kernel > > mailing

Re: WARN_ON_ONCE() hit at kernel/events/core.c:330

2019-04-08 Thread Thomas-Mich Richter
On 4/8/19 10:22 AM, Peter Zijlstra wrote: > On Mon, Apr 08, 2019 at 09:12:28AM +0200, Thomas-Mich Richter wrote: >>> Does the below cure things? It's not exactly pretty, but it could just >>> do the trick. >>> >>> --- >>> diff --git a/kernel/events/core.c b/kernel/events/core.c >>> index

Re: WARN_ON_ONCE() hit at kernel/events/core.c:330

2019-04-08 Thread Peter Zijlstra
On Mon, Apr 08, 2019 at 09:12:28AM +0200, Thomas-Mich Richter wrote: > > Does the below cure things? It's not exactly pretty, but it could just > > do the trick. > > > > --- > > diff --git a/kernel/events/core.c b/kernel/events/core.c > > index dfc4bab0b02b..d496e6911442 100644 > > ---

Re: WARN_ON_ONCE() hit at kernel/events/core.c:330

2019-04-08 Thread Thomas-Mich Richter
On 4/4/19 3:03 PM, Peter Zijlstra wrote: > On Thu, Apr 04, 2019 at 01:09:09PM +0200, Peter Zijlstra wrote: > >> That is not entirely the scenario I talked about, but *groan*. >> >> So what I meant was: >> >> CPU-0 CPU-n >> >>

Re: WARN_ON_ONCE() hit at kernel/events/core.c:330

2019-04-05 Thread Peter Zijlstra
On Fri, Apr 05, 2019 at 12:18:54PM +0200, Thomas-Mich Richter wrote: > On 4/4/19 3:03 PM, Peter Zijlstra wrote: > > On Thu, Apr 04, 2019 at 01:09:09PM +0200, Peter Zijlstra wrote: > > > >> That is not entirely the scenario I talked about, but *groan*. > >> > >> So what I meant was: > >> > >>

Re: WARN_ON_ONCE() hit at kernel/events/core.c:330

2019-04-05 Thread Thomas-Mich Richter
On 4/4/19 3:03 PM, Peter Zijlstra wrote: > On Thu, Apr 04, 2019 at 01:09:09PM +0200, Peter Zijlstra wrote: > >> That is not entirely the scenario I talked about, but *groan*. >> >> So what I meant was: >> >> CPU-0 CPU-n >> >>

Re: WARN_ON_ONCE() hit at kernel/events/core.c:330

2019-04-04 Thread Thomas-Mich Richter
On 4/4/19 3:03 PM, Peter Zijlstra wrote: > On Thu, Apr 04, 2019 at 01:09:09PM +0200, Peter Zijlstra wrote: > >> That is not entirely the scenario I talked about, but *groan*. >> >> So what I meant was: >> >> CPU-0 CPU-n >> >>

Re: WARN_ON_ONCE() hit at kernel/events/core.c:330

2019-04-04 Thread Peter Zijlstra
On Thu, Apr 04, 2019 at 01:09:09PM +0200, Peter Zijlstra wrote: > That is not entirely the scenario I talked about, but *groan*. > > So what I meant was: > > CPU-0 CPU-n > > __schedule() > local_irq_disable() > >

Re: WARN_ON_ONCE() hit at kernel/events/core.c:330

2019-04-04 Thread Peter Zijlstra
On Thu, Apr 04, 2019 at 02:02:14PM +0200, Peter Zijlstra wrote: > On Thu, Apr 04, 2019 at 01:09:09PM +0200, Peter Zijlstra wrote: > > That is not entirely the scenario I talked about, but *groan*. > > > > So what I meant was: > > > > CPU-0

Re: WARN_ON_ONCE() hit at kernel/events/core.c:330

2019-04-04 Thread Peter Zijlstra
On Thu, Apr 04, 2019 at 01:09:09PM +0200, Peter Zijlstra wrote: > That is not entirely the scenario I talked about, but *groan*. > > So what I meant was: > > CPU-0 CPU-n > > __schedule() > local_irq_disable() > > ...

Re: WARN_ON_ONCE() hit at kernel/events/core.c:330

2019-04-04 Thread Peter Zijlstra
On Thu, Apr 04, 2019 at 11:15:39AM +0200, Thomas-Mich Richter wrote: > On 4/3/19 12:41 PM, Peter Zijlstra wrote: > > On Wed, Apr 03, 2019 at 11:47:00AM +0200, Thomas-Mich Richter wrote: > >> I use linux 5.1.0-rc3 on s390 and got this WARN_ON_ONCE message: > >> > >> WARNING: CPU: 15 PID: 0 at

Re: WARN_ON_ONCE() hit at kernel/events/core.c:330

2019-04-04 Thread Thomas-Mich Richter
On 4/3/19 12:41 PM, Peter Zijlstra wrote: > On Wed, Apr 03, 2019 at 11:47:00AM +0200, Thomas-Mich Richter wrote: >> I use linux 5.1.0-rc3 on s390 and got this WARN_ON_ONCE message: >> >> WARNING: CPU: 15 PID: 0 at kernel/events/core.c:330 >>

Re: WARN_ON_ONCE() hit at kernel/events/core.c:330

2019-04-03 Thread Thomas-Mich Richter
On 4/3/19 12:41 PM, Peter Zijlstra wrote: > On Wed, Apr 03, 2019 at 11:47:00AM +0200, Thomas-Mich Richter wrote: >> I use linux 5.1.0-rc3 on s390 and got this WARN_ON_ONCE message: >> >> WARNING: CPU: 15 PID: 0 at kernel/events/core.c:330 >>

Re: WARN_ON_ONCE() hit at kernel/events/core.c:330

2019-04-03 Thread Peter Zijlstra
On Wed, Apr 03, 2019 at 11:47:00AM +0200, Thomas-Mich Richter wrote: > I use linux 5.1.0-rc3 on s390 and got this WARN_ON_ONCE message: > > WARNING: CPU: 15 PID: 0 at kernel/events/core.c:330 > event_function_local.constprop.79+0xe2/0xe8 > > which was introduced with >commit

WARN_ON_ONCE() hit at kernel/events/core.c:330

2019-04-03 Thread Thomas-Mich Richter
I use linux 5.1.0-rc3 on s390 and got this WARN_ON_ONCE message: WARNING: CPU: 15 PID: 0 at kernel/events/core.c:330 event_function_local.constprop.79+0xe2/0xe8 which was introduced with commit cca2094605ef ("perf/core: Fix event_function_local()"). This is the WARN_ON_ONCE