Re: __ftrace_hash_rec_update FTRACE_WARN_ON.

2013-08-02 Thread Steven Rostedt
On Thu, 2013-08-01 at 21:51 -0700, Steve Hodgson wrote: > This patch also fixes the issue for me: ftrace works fine across module > removal. > > Sorry for being a little slow in testing this. > No problem. Thanks for testing :-) -- Steve -- To unsubscribe from this list: send the line

Re: __ftrace_hash_rec_update FTRACE_WARN_ON.

2013-08-02 Thread Steven Rostedt
On Thu, 2013-08-01 at 21:51 -0700, Steve Hodgson wrote: This patch also fixes the issue for me: ftrace works fine across module removal. Sorry for being a little slow in testing this. No problem. Thanks for testing :-) -- Steve -- To unsubscribe from this list: send the line

Re: __ftrace_hash_rec_update FTRACE_WARN_ON.

2013-08-01 Thread Steve Hodgson
On Tue, Jul 30, 2013 at 5:51 PM, Steven Rostedt wrote: > On Sat, 2013-07-27 at 12:16 -0700, Steve Hodgson wrote: > >> This patch fixes ftrace across module removal/reinsertion on our 3.6.11 >> kernel. > > I found a few corner cases that this patch doesn't work with, and the > solution is just

Re: __ftrace_hash_rec_update FTRACE_WARN_ON.

2013-08-01 Thread Steve Hodgson
On Tue, Jul 30, 2013 at 5:51 PM, Steven Rostedt rost...@goodmis.org wrote: On Sat, 2013-07-27 at 12:16 -0700, Steve Hodgson wrote: This patch fixes ftrace across module removal/reinsertion on our 3.6.11 kernel. I found a few corner cases that this patch doesn't work with, and the solution

Re: __ftrace_hash_rec_update FTRACE_WARN_ON.

2013-07-30 Thread Steven Rostedt
On Sat, 2013-07-27 at 12:16 -0700, Steve Hodgson wrote: > This patch fixes ftrace across module removal/reinsertion on our 3.6.11 > kernel. I found a few corner cases that this patch doesn't work with, and the solution is just getting uglier and uglier. I found a new solution that seems to

Re: __ftrace_hash_rec_update FTRACE_WARN_ON.

2013-07-30 Thread Steven Rostedt
On Sat, 2013-07-27 at 12:16 -0700, Steve Hodgson wrote: This patch fixes ftrace across module removal/reinsertion on our 3.6.11 kernel. I found a few corner cases that this patch doesn't work with, and the solution is just getting uglier and uglier. I found a new solution that seems to

Re: __ftrace_hash_rec_update FTRACE_WARN_ON.

2013-07-27 Thread Steve Hodgson
On Thu, Jul 25, 2013 at 8:23 PM, Steven Rostedt wrote: > On Thu, 2013-07-25 at 14:59 -0400, Steven Rostedt wrote: > >> Now that I know what's the problem, it shouldn't be too hard to fix. > > It was a bit more involved to fix than I expected. I don't like the fact > that if you filter on only

Re: __ftrace_hash_rec_update FTRACE_WARN_ON.

2013-07-27 Thread Steve Hodgson
On Thu, Jul 25, 2013 at 8:23 PM, Steven Rostedt rost...@goodmis.org wrote: On Thu, 2013-07-25 at 14:59 -0400, Steven Rostedt wrote: Now that I know what's the problem, it shouldn't be too hard to fix. It was a bit more involved to fix than I expected. I don't like the fact that if you filter

Re: __ftrace_hash_rec_update FTRACE_WARN_ON.

2013-07-25 Thread Steven Rostedt
On Thu, 2013-07-25 at 14:59 -0400, Steven Rostedt wrote: > Now that I know what's the problem, it shouldn't be too hard to fix. It was a bit more involved to fix than I expected. I don't like the fact that if you filter on only module functions and remove that module, you now remove the filter

Re: __ftrace_hash_rec_update FTRACE_WARN_ON.

2013-07-25 Thread Steven Rostedt
On Wed, 2013-07-24 at 22:46 -0700, Steve Hodgson wrote: > No, nothing so complicated. > > I added symbols from a kernel module into > /sys/kernel/debug/tracing/set_ftrace_filter, enabled tracing, then > unloaded the kernel module. > > Which I'll admit is a stupid thing to do. I was then

Re: __ftrace_hash_rec_update FTRACE_WARN_ON.

2013-07-25 Thread Steven Rostedt
On Wed, 2013-07-24 at 22:46 -0700, Steve Hodgson wrote: No, nothing so complicated. I added symbols from a kernel module into /sys/kernel/debug/tracing/set_ftrace_filter, enabled tracing, then unloaded the kernel module. Which I'll admit is a stupid thing to do. I was then punished for

Re: __ftrace_hash_rec_update FTRACE_WARN_ON.

2013-07-25 Thread Steven Rostedt
On Thu, 2013-07-25 at 14:59 -0400, Steven Rostedt wrote: Now that I know what's the problem, it shouldn't be too hard to fix. It was a bit more involved to fix than I expected. I don't like the fact that if you filter on only module functions and remove that module, you now remove the filter

Re: __ftrace_hash_rec_update FTRACE_WARN_ON.

2013-07-24 Thread Steve Hodgson
On Wed, Jul 24, 2013 at 6:24 PM, Steven Rostedt wrote: > > On Wed, 2013-07-24 at 12:04 -0400, Jörn Engel wrote: > > On Fri, 5 July 2013 10:53:54 -0400, Steven Rostedt wrote: > > > > > > Can you find an easy reproducer for this? > > > > We might have found something: > > > > Jul 23 19:00:59

Re: __ftrace_hash_rec_update FTRACE_WARN_ON.

2013-07-24 Thread Steven Rostedt
On Wed, 2013-07-24 at 12:04 -0400, Jörn Engel wrote: > On Fri, 5 July 2013 10:53:54 -0400, Steven Rostedt wrote: > > > > Can you find an easy reproducer for this? > > We might have found something: > > Jul 23 19:00:59 [28253.487058,08] WARNING: at kernel/trace/ftrace.c:1529 >

Re: __ftrace_hash_rec_update FTRACE_WARN_ON.

2013-07-24 Thread Jörn Engel
On Fri, 5 July 2013 10:53:54 -0400, Steven Rostedt wrote: > > Can you find an easy reproducer for this? We might have found something: Jul 23 19:00:59 [28253.487058,08] WARNING: at kernel/trace/ftrace.c:1529 __ftrace_hash_rec_update+0x1e3/0x230() Jul 23 19:00:59 [28253.487203,08] Pid: 20903,

Re: __ftrace_hash_rec_update FTRACE_WARN_ON.

2013-07-24 Thread Steven Rostedt
On Wed, 2013-07-24 at 12:04 -0400, Jörn Engel wrote: On Fri, 5 July 2013 10:53:54 -0400, Steven Rostedt wrote: Can you find an easy reproducer for this? We might have found something: Jul 23 19:00:59 [28253.487058,08] WARNING: at kernel/trace/ftrace.c:1529

Re: __ftrace_hash_rec_update FTRACE_WARN_ON.

2013-07-24 Thread Steve Hodgson
On Wed, Jul 24, 2013 at 6:24 PM, Steven Rostedt rost...@goodmis.org wrote: On Wed, 2013-07-24 at 12:04 -0400, Jörn Engel wrote: On Fri, 5 July 2013 10:53:54 -0400, Steven Rostedt wrote: Can you find an easy reproducer for this? We might have found something: Jul 23 19:00:59

Re: __ftrace_hash_rec_update FTRACE_WARN_ON.

2013-07-24 Thread Jörn Engel
On Fri, 5 July 2013 10:53:54 -0400, Steven Rostedt wrote: Can you find an easy reproducer for this? We might have found something: Jul 23 19:00:59 [28253.487058,08] WARNING: at kernel/trace/ftrace.c:1529 __ftrace_hash_rec_update+0x1e3/0x230() Jul 23 19:00:59 [28253.487203,08] Pid: 20903,

Re: __ftrace_hash_rec_update FTRACE_WARN_ON.

2013-07-05 Thread Dave Jones
On Fri, Jul 05, 2013 at 10:53:54AM -0400, Steven Rostedt wrote: > On Fri, 2013-07-05 at 10:26 -0400, Dave Jones wrote: > > WARNING: at kernel/trace/ftrace.c:1605 > > __ftrace_hash_rec_update.part.37+0x20a/0x240() > > Modules linked in: sctp libcrc32c snd_seq_dummy fuse tun rfcomm bnep > >

Re: __ftrace_hash_rec_update FTRACE_WARN_ON.

2013-07-05 Thread Steven Rostedt
On Fri, 2013-07-05 at 10:26 -0400, Dave Jones wrote: > WARNING: at kernel/trace/ftrace.c:1605 > __ftrace_hash_rec_update.part.37+0x20a/0x240() > Modules linked in: sctp libcrc32c snd_seq_dummy fuse tun rfcomm bnep > scsi_transport_iscsi hidp nfnetlink can_bcm irda caif_socket nfc caif netrom >

__ftrace_hash_rec_update FTRACE_WARN_ON.

2013-07-05 Thread Dave Jones
WARNING: at kernel/trace/ftrace.c:1605 __ftrace_hash_rec_update.part.37+0x20a/0x240() Modules linked in: sctp libcrc32c snd_seq_dummy fuse tun rfcomm bnep scsi_transport_iscsi hidp nfnetlink can_bcm irda caif_socket nfc caif netrom crc_ccitt rose x25 appletalk ipt_ULOG rds bluetooth can_raw ipx

__ftrace_hash_rec_update FTRACE_WARN_ON.

2013-07-05 Thread Dave Jones
WARNING: at kernel/trace/ftrace.c:1605 __ftrace_hash_rec_update.part.37+0x20a/0x240() Modules linked in: sctp libcrc32c snd_seq_dummy fuse tun rfcomm bnep scsi_transport_iscsi hidp nfnetlink can_bcm irda caif_socket nfc caif netrom crc_ccitt rose x25 appletalk ipt_ULOG rds bluetooth can_raw ipx

Re: __ftrace_hash_rec_update FTRACE_WARN_ON.

2013-07-05 Thread Steven Rostedt
On Fri, 2013-07-05 at 10:26 -0400, Dave Jones wrote: WARNING: at kernel/trace/ftrace.c:1605 __ftrace_hash_rec_update.part.37+0x20a/0x240() Modules linked in: sctp libcrc32c snd_seq_dummy fuse tun rfcomm bnep scsi_transport_iscsi hidp nfnetlink can_bcm irda caif_socket nfc caif netrom

Re: __ftrace_hash_rec_update FTRACE_WARN_ON.

2013-07-05 Thread Dave Jones
On Fri, Jul 05, 2013 at 10:53:54AM -0400, Steven Rostedt wrote: On Fri, 2013-07-05 at 10:26 -0400, Dave Jones wrote: WARNING: at kernel/trace/ftrace.c:1605 __ftrace_hash_rec_update.part.37+0x20a/0x240() Modules linked in: sctp libcrc32c snd_seq_dummy fuse tun rfcomm bnep