Re: bpfilter logging write errors in dmesg

2020-07-30 Thread Rodrigo Madera
On Thu, Jul 30, 2020 at 08:06:54AM +0200, Christoph Hellwig wrote: > Ho Rodrigo, > > please try this patch: > > diff --git a/net/bpfilter/bpfilter_kern.c b/net/bpfilter/bpfilter_kern.c > index 1905e01c3aa9a7..4494ea6056cdb8 100644 > --- a/net/bpfilter/bpfilter_kern.c > +++

Re: bpfilter logging write errors in dmesg

2020-07-30 Thread Christian Brauner
On Mon, Jul 27, 2020 at 04:50:13PM +0200, Christoph Hellwig wrote: > Strange. Can you add this additional debugging patch: Sorry Christoph, didn't mean to leave you waiting. I got pulled into other stuff. Christian > > diff --git a/fs/read_write.c b/fs/read_write.c > index

Re: bpfilter logging write errors in dmesg

2020-07-30 Thread Christoph Hellwig
Ho Rodrigo, please try this patch: diff --git a/net/bpfilter/bpfilter_kern.c b/net/bpfilter/bpfilter_kern.c index 1905e01c3aa9a7..4494ea6056cdb8 100644 --- a/net/bpfilter/bpfilter_kern.c +++ b/net/bpfilter/bpfilter_kern.c @@ -39,7 +39,7 @@ static int __bpfilter_process_sockopt(struct sock *sk,

Re: bpfilter logging write errors in dmesg

2020-07-29 Thread Rodrigo Madera
Christoph, I see the same issue on my AMD 3990x using v5.8rc7: [ 10.229424] bpfilter: Loaded bpfilter_umh pid 1906 [ 10.229467] Started bpfilter [ 10.229538] pos invalid: -131326014643272 [ 10.229539] bpfilter: write fail -22 [ 10.229603] pos invalid: -2127991714 [ 10.229604]

Re: bpfilter logging write errors in dmesg

2020-07-27 Thread Christoph Hellwig
Strange. Can you add this additional debugging patch: diff --git a/fs/read_write.c b/fs/read_write.c index 4fb797822567a6..d0a8ada1efd954 100644 --- a/fs/read_write.c +++ b/fs/read_write.c @@ -369,8 +369,10 @@ int rw_verify_area(int read_write, struct file *file, const loff_t *ppos, size_t

Re: bpfilter logging write errors in dmesg

2020-07-27 Thread Christian Brauner
On Mon, Jul 27, 2020 at 04:13:38PM +0200, Christian Brauner wrote: > On Mon, Jul 27, 2020 at 03:28:55PM +0200, Christoph Hellwig wrote: > > On Mon, Jul 27, 2020 at 12:46:36PM +0200, Christian Brauner wrote: > > > Hey Christoph, > > > > > > Seems that commit > > > 6955a76fbcd5 ("bpfilter: switch

Re: bpfilter logging write errors in dmesg

2020-07-27 Thread Christian Brauner
On Mon, Jul 27, 2020 at 03:28:55PM +0200, Christoph Hellwig wrote: > On Mon, Jul 27, 2020 at 12:46:36PM +0200, Christian Brauner wrote: > > Hey Christoph, > > > > Seems that commit > > 6955a76fbcd5 ("bpfilter: switch to kernel_write") > > causes bpfilter to spew these useless messages in dmesg? >

Re: bpfilter logging write errors in dmesg

2020-07-27 Thread Christoph Hellwig
On Mon, Jul 27, 2020 at 12:46:36PM +0200, Christian Brauner wrote: > Hey Christoph, > > Seems that commit > 6955a76fbcd5 ("bpfilter: switch to kernel_write") > causes bpfilter to spew these useless messages in dmesg? > > [ 26.356824] Started bpfilter > [ 26.357059] bpfilter: write fail -22 >

bpfilter logging write errors in dmesg

2020-07-27 Thread Christian Brauner
Hey Christoph, Seems that commit 6955a76fbcd5 ("bpfilter: switch to kernel_write") causes bpfilter to spew these useless messages in dmesg? [ 26.356824] Started bpfilter [ 26.357059] bpfilter: write fail -22 [ 26.396244] Started bpfilter [ 26.396325] bpfilter: Loaded bpfilter_umh pid 637