Re: coding style for long conditions (WAS: Re: [PATCH 25/90] ... blinky leds!!)

2007-04-08 Thread Scott Preece
On 4/6/07, Stefan Richter <[EMAIL PROTECTED]> wrote: David Brownell wrote: [...] >>> 1 if (To control chain reactions, your odds >>> 2 Improve if you've got cadmium rods) { >>> 3 In your fission reactor >>> 4 Their lack is a factor >>> 5 } >>> 6 In

Re: coding style for long conditions (WAS: Re: [PATCH 25/90] ... blinky leds!!)

2007-04-08 Thread Dmitry Torokhov
On Friday 06 April 2007 18:57, David Brownell wrote: > On Friday 06 April 2007 3:17 pm, Thomas Gleixner wrote: > > David, > > > > http://tglx.de/private/tglx/usbnet.png > > > > /me recommends emacs-develock.el for colorful white space wreckage > > display ! > > Then I'd have to switch to EMACS

Re: coding style for long conditions (WAS: Re: [PATCH 25/90] ... blinky leds!!)

2007-04-08 Thread Dmitry Torokhov
On Friday 06 April 2007 18:57, David Brownell wrote: On Friday 06 April 2007 3:17 pm, Thomas Gleixner wrote: David, http://tglx.de/private/tglx/usbnet.png /me recommends emacs-develock.el for colorful white space wreckage display ! Then I'd have to switch to EMACS ... no thanks!  

Re: coding style for long conditions (WAS: Re: [PATCH 25/90] ... blinky leds!!)

2007-04-08 Thread Scott Preece
On 4/6/07, Stefan Richter [EMAIL PROTECTED] wrote: David Brownell wrote: [...] 1 if (To control chain reactions, your odds 2 Improve if you've got cadmium rods) { 3 In your fission reactor 4 Their lack is a factor 5 } 6 In screams of A meltdown!

Re: coding style for long conditions (WAS: Re: [PATCH 25/90] ... blinky leds!!)

2007-04-06 Thread Krzysztof Halasa
Jan Engelhardt <[EMAIL PROTECTED]> writes: > Tabs should be used for indent, not padding. People wanting to use > different-sized tabs can change settings in their editor, i.e. > to make a tab 12 instead of 8. Or 6. Or whatever. If tabs only ever > appear at the front, this works, it breaks when

Re: coding style for long conditions (WAS: Re: [PATCH 25/90] ... blinky leds!!)

2007-04-06 Thread Jan Engelhardt
On Apr 6 2007 15:40, David Brownell wrote: >> >if (...) { >> >THAT WAS ONE MORE TAB >> >} >> > >> >Come on, stop wasting everyone's time with utter nonsense. >> I was never debating these two things. >Actually, you did. If it was perceived I did, then I owe you an apology.

Re: coding style for long conditions (WAS: Re: [PATCH 25/90] ... blinky leds!!)

2007-04-06 Thread David Brownell
On Friday 06 April 2007 4:21 pm, Thomas Gleixner wrote: > David, > > On Fri, 2007-04-06 at 15:57 -0700, David Brownell wrote: > > This particular issue doesn't actually affect indentation, since the > > tab trumps that space. So it's a bit off-agenda for this particular > > flamage. > > ROTFL,

Re: coding style for long conditions (WAS: Re: [PATCH 25/90] ... blinky leds!!)

2007-04-06 Thread Thomas Gleixner
David, On Fri, 2007-04-06 at 15:57 -0700, David Brownell wrote: > This particular issue doesn't actually affect indentation, since the > tab trumps that space. So it's a bit off-agenda for this particular > flamage. ROTFL, the tab trumps the space. Is this a card game ? > > Please change your

Re: coding style for long conditions (WAS: Re: [PATCH 25/90] ... blinky leds!!)

2007-04-06 Thread David Brownell
On Friday 06 April 2007 3:17 pm, Thomas Gleixner wrote: > David, > > http://tglx.de/private/tglx/usbnet.png > > /me recommends emacs-develock.el for colorful white space wreckage > display ! Then I'd have to switch to EMACS ... no thanks! ;) At the risk of switching to a VI/EMACS flamewar

Re: coding style for long conditions (WAS: Re: [PATCH 25/90] ... blinky leds!!)

2007-04-06 Thread David Brownell
On Friday 06 April 2007 3:04 pm, Jan Engelhardt wrote: > > if (...) { > > THAT WAS ONE MORE TAB > > } > > > >and > > > > for (...) { > > THAT WAS ALSO ONE MORE TAB > > } > > > >Come on, stop wasting everyone's time with utter nonsense. > > I was never

Re: coding style for long conditions (WAS: Re: [PATCH 25/90] ... blinky leds!!)

2007-04-06 Thread Thomas Gleixner
David, On Fri, 2007-04-06 at 14:05 -0700, David Brownell wrote: > Please change your coding style to conform to Documentation/CodingStyle. > > *** Only indent with tabs!! *** > > Every one of those examples violates that simple rule. > > Why does *anyone* have even the

Re: coding style for long conditions (WAS: Re: [PATCH 25/90] ... blinky leds!!)

2007-04-06 Thread Jan Engelhardt
Hello David, On Apr 6 2007 13:57, David Brownell wrote: >> though I do not speak for >> them, seem to do it much the way I described, judging from the code they >> wrote/write. > >Your eyes are broken then ... Sorry? I could have simply told you to look into kernel/signal.c LINE 220 (that's in

Re: coding style for long conditions (WAS: Re: [PATCH 25/90] ... blinky leds!!)

2007-04-06 Thread David Brownell
On Friday 06 April 2007 2:37 pm, Jeremy Fitzhardinge wrote: > David Brownell wrote: > > Please change your coding style to conform to Documentation/CodingStyle. > > > > *** Only indent with tabs!! *** > > > > Every one of those examples violates that simple rule. > > > > Spaces

Re: coding style for long conditions (WAS: Re: [PATCH 25/90] ... blinky leds!!)

2007-04-06 Thread Jan Engelhardt
On Apr 6 2007 14:05, David Brownell wrote: > >Please change your coding style to conform to Documentation/CodingStyle. > > *** Only indent with tabs!! *** > >Every one of those examples violates that simple rule. > >Why does *anyone* have even the slightest difficulty

Re: coding style for long conditions (WAS: Re: [PATCH 25/90] ... blinky leds!!)

2007-04-06 Thread Stefan Richter
David Brownell wrote: > On Friday 06 April 2007 12:03 pm, Stefan Richter wrote: > >> I usually indent this way if expressions exceed the 80 columns limit: Or in other words: - When a new scope is opened, increase indentations by 8 characters. Use a tab for that. - When wrapping within an

Re: coding style for long conditions (WAS: Re: [PATCH 25/90] ... blinky leds!!)

2007-04-06 Thread Randy Dunlap
David Brownell wrote: On Friday 06 April 2007 12:03 pm, Stefan Richter wrote: I usually indent this way if expressions exceed the 80 columns limit: if (foo___ && bar___) { doit; } and if ((one___ ||

Re: coding style for long conditions (WAS: Re: [PATCH 25/90] ... blinky leds!!)

2007-04-06 Thread Jeremy Fitzhardinge
David Brownell wrote: > Please change your coding style to conform to Documentation/CodingStyle. > > *** Only indent with tabs!! *** > > Every one of those examples violates that simple rule. > Spaces are used to indent all over the kernel; using a few spaces to pad out some

Re: coding style for long conditions (WAS: Re: [PATCH 25/90] ... blinky leds!!)

2007-04-06 Thread David Brownell
On Friday 06 April 2007 12:16 pm, Jan Engelhardt wrote: > >> and that the inner block code > >> (lines 3 and 4) should have more indent than line 2. > > > >We disagree. The "inner" block should in all cases have one-tab indent. > > You disagree. "We", as in, the kernel coders, ... agree with

Re: coding style for long conditions (WAS: Re: [PATCH 25/90] ... blinky leds!!)

2007-04-06 Thread David Brownell
On Friday 06 April 2007 12:03 pm, Stefan Richter wrote: > > I usually indent this way if expressions exceed the 80 columns limit: > > if (foo___ && > bar___) { > doit; > } > and > if ((one___ || >one_and_a_half) && >

Re: coding style for long conditions (WAS: Re: [PATCH 25/90] ... blinky leds!!)

2007-04-06 Thread Jan Engelhardt
On Apr 6 2007 10:29, David Brownell wrote: >> Using >> /^\t+\x20{2,8}/ on continuation line(s) is perfect because it does >> not cause either the continuation line(s) or the inner block code to >> move too much to the right. > >No, that's a clear violation of CodingStyle on two separate points:

Re: coding style for long conditions (WAS: Re: [PATCH 25/90] ... blinky leds!!)

2007-04-06 Thread Stefan Richter
David Brownell wrote: [...] >>> 1 if (To control chain reactions, your odds >>> 2 Improve if you've got cadmium rods) { >>> 3 In your fission reactor >>> 4 Their lack is a factor >>> 5 } >>> 6 In screams of "A meltdown! Ye gods!" >>> >>> Now, the former

coding style for long conditions (WAS: Re: [PATCH 25/90] ... blinky leds!!)

2007-04-06 Thread David Brownell
On Thursday 05 April 2007 1:35 pm, Jan Engelhardt wrote: > > >obeys the only-ident-by-tabs rule, as does > > > >1if (To control chain reactions, your odds > >2Improve if you've got cadmium rods) { > >3In your fission reactor > >4Their lack is a

coding style for long conditions (WAS: Re: [PATCH 25/90] ... blinky leds!!)

2007-04-06 Thread David Brownell
On Thursday 05 April 2007 1:35 pm, Jan Engelhardt wrote: obeys the only-ident-by-tabs rule, as does 1if (To control chain reactions, your odds 2Improve if you've got cadmium rods) { 3In your fission reactor 4Their lack is a factor 5} 6

Re: coding style for long conditions (WAS: Re: [PATCH 25/90] ... blinky leds!!)

2007-04-06 Thread Stefan Richter
David Brownell wrote: [...] 1 if (To control chain reactions, your odds 2 Improve if you've got cadmium rods) { 3 In your fission reactor 4 Their lack is a factor 5 } 6 In screams of A meltdown! Ye gods! Now, the former makes it hard to tell

Re: coding style for long conditions (WAS: Re: [PATCH 25/90] ... blinky leds!!)

2007-04-06 Thread Jan Engelhardt
On Apr 6 2007 10:29, David Brownell wrote: Using /^\t+\x20{2,8}/ on continuation line(s) is perfect because it does not cause either the continuation line(s) or the inner block code to move too much to the right. No, that's a clear violation of CodingStyle on two separate points: (a) the

Re: coding style for long conditions (WAS: Re: [PATCH 25/90] ... blinky leds!!)

2007-04-06 Thread David Brownell
On Friday 06 April 2007 12:16 pm, Jan Engelhardt wrote: and that the inner block code (lines 3 and 4) should have more indent than line 2. We disagree. The inner block should in all cases have one-tab indent. You disagree. We, as in, the kernel coders, ... agree with what I said,

Re: coding style for long conditions (WAS: Re: [PATCH 25/90] ... blinky leds!!)

2007-04-06 Thread David Brownell
On Friday 06 April 2007 12:03 pm, Stefan Richter wrote: I usually indent this way if expressions exceed the 80 columns limit: if (foo___ bar___) { doit; } and if ((one___ || one_and_a_half)

Re: coding style for long conditions (WAS: Re: [PATCH 25/90] ... blinky leds!!)

2007-04-06 Thread Jeremy Fitzhardinge
David Brownell wrote: Please change your coding style to conform to Documentation/CodingStyle. *** Only indent with tabs!! *** Every one of those examples violates that simple rule. Spaces are used to indent all over the kernel; using a few spaces to pad out some

Re: coding style for long conditions (WAS: Re: [PATCH 25/90] ... blinky leds!!)

2007-04-06 Thread Randy Dunlap
David Brownell wrote: On Friday 06 April 2007 12:03 pm, Stefan Richter wrote: I usually indent this way if expressions exceed the 80 columns limit: if (foo___ bar___) { doit; } and if ((one___ ||

Re: coding style for long conditions (WAS: Re: [PATCH 25/90] ... blinky leds!!)

2007-04-06 Thread Stefan Richter
David Brownell wrote: On Friday 06 April 2007 12:03 pm, Stefan Richter wrote: I usually indent this way if expressions exceed the 80 columns limit: Or in other words: - When a new scope is opened, increase indentations by 8 characters. Use a tab for that. - When wrapping within an

Re: coding style for long conditions (WAS: Re: [PATCH 25/90] ... blinky leds!!)

2007-04-06 Thread David Brownell
On Friday 06 April 2007 2:37 pm, Jeremy Fitzhardinge wrote: David Brownell wrote: Please change your coding style to conform to Documentation/CodingStyle. *** Only indent with tabs!! *** Every one of those examples violates that simple rule. Spaces are used to

Re: coding style for long conditions (WAS: Re: [PATCH 25/90] ... blinky leds!!)

2007-04-06 Thread Jan Engelhardt
On Apr 6 2007 14:05, David Brownell wrote: Please change your coding style to conform to Documentation/CodingStyle. *** Only indent with tabs!! *** Every one of those examples violates that simple rule. Why does *anyone* have even the slightest difficulty understanding such

Re: coding style for long conditions (WAS: Re: [PATCH 25/90] ... blinky leds!!)

2007-04-06 Thread Jan Engelhardt
Hello David, On Apr 6 2007 13:57, David Brownell wrote: though I do not speak for them, seem to do it much the way I described, judging from the code they wrote/write. Your eyes are broken then ... Sorry? I could have simply told you to look into kernel/signal.c LINE 220 (that's in the

Re: coding style for long conditions (WAS: Re: [PATCH 25/90] ... blinky leds!!)

2007-04-06 Thread Thomas Gleixner
David, On Fri, 2007-04-06 at 14:05 -0700, David Brownell wrote: Please change your coding style to conform to Documentation/CodingStyle. *** Only indent with tabs!! *** Every one of those examples violates that simple rule. Why does *anyone* have even the slightest

Re: coding style for long conditions (WAS: Re: [PATCH 25/90] ... blinky leds!!)

2007-04-06 Thread David Brownell
On Friday 06 April 2007 3:04 pm, Jan Engelhardt wrote: if (...) { THAT WAS ONE MORE TAB } and for (...) { THAT WAS ALSO ONE MORE TAB } Come on, stop wasting everyone's time with utter nonsense. I was never debating these two things.

Re: coding style for long conditions (WAS: Re: [PATCH 25/90] ... blinky leds!!)

2007-04-06 Thread David Brownell
On Friday 06 April 2007 3:17 pm, Thomas Gleixner wrote: David, http://tglx.de/private/tglx/usbnet.png /me recommends emacs-develock.el for colorful white space wreckage display ! Then I'd have to switch to EMACS ... no thanks! ;) At the risk of switching to a VI/EMACS flamewar (could

Re: coding style for long conditions (WAS: Re: [PATCH 25/90] ... blinky leds!!)

2007-04-06 Thread Thomas Gleixner
David, On Fri, 2007-04-06 at 15:57 -0700, David Brownell wrote: This particular issue doesn't actually affect indentation, since the tab trumps that space. So it's a bit off-agenda for this particular flamage. ROTFL, the tab trumps the space. Is this a card game ? Please change your

Re: coding style for long conditions (WAS: Re: [PATCH 25/90] ... blinky leds!!)

2007-04-06 Thread David Brownell
On Friday 06 April 2007 4:21 pm, Thomas Gleixner wrote: David, On Fri, 2007-04-06 at 15:57 -0700, David Brownell wrote: This particular issue doesn't actually affect indentation, since the tab trumps that space. So it's a bit off-agenda for this particular flamage. ROTFL, the tab

Re: coding style for long conditions (WAS: Re: [PATCH 25/90] ... blinky leds!!)

2007-04-06 Thread Jan Engelhardt
On Apr 6 2007 15:40, David Brownell wrote: if (...) { THAT WAS ONE MORE TAB } Come on, stop wasting everyone's time with utter nonsense. I was never debating these two things. Actually, you did. If it was perceived I did, then I owe you an apology. Go back and see

Re: coding style for long conditions (WAS: Re: [PATCH 25/90] ... blinky leds!!)

2007-04-06 Thread Krzysztof Halasa
Jan Engelhardt [EMAIL PROTECTED] writes: Tabs should be used for indent, not padding. People wanting to use different-sized tabs can change settings in their editor, i.e. to make a tab 12 instead of 8. Or 6. Or whatever. If tabs only ever appear at the front, this works, it breaks when tabs