Re: i915 hibernation patch (was: Re: [Suspend-devel] 2.6.25-rc2 System no longer powers off aftersuspend-to-disk. Screen becomes green.)

2008-02-23 Thread Pavel Machek
> > Apart from those issues it looks fine to me. > > OK, please have a look at the modified patch below. Seems to work here after basic tests. ACK. (I discovered that -rc2 swsusp will not power down in some cases, but it was here before the patch, too...)

Re: i915 hibernation patch (was: Re: [Suspend-devel] 2.6.25-rc2 System no longer powers off aftersuspend-to-disk. Screen becomes green.)

2008-02-23 Thread Pavel Machek
Apart from those issues it looks fine to me. OK, please have a look at the modified patch below. Seems to work here after basic tests. ACK. (I discovered that -rc2 swsusp will not power down in some cases, but it was here before the patch, too...)

Re: i915 hibernation patch (was: Re: [Suspend-devel] 2.6.25-rc2 System no longer powers off aftersuspend-to-disk. Screen becomes green.)

2008-02-22 Thread Jeff Chua
On Sat, Feb 23, 2008 at 10:07 AM, Linus Torvalds <[EMAIL PROTECTED]> wrote: > On Sat, 23 Feb 2008, Rafael J. Wysocki wrote: > > OK, please have a look at the modified patch below. > > All right, I'm fine with it. Now we just need to confirm that it works for > people.. Looks good. Applied

Re: i915 hibernation patch (was: Re: [Suspend-devel] 2.6.25-rc2 System no longer powers off aftersuspend-to-disk. Screen becomes green.)

2008-02-22 Thread Linus Torvalds
On Sat, 23 Feb 2008, Rafael J. Wysocki wrote: > > In the revised patch below I redefined the PM_EVENT_* things as flags so > that I can "or" them and defined PM_EVENT_SLEEP in analogy with > CONFIG_PM_SLEEP. Ok, looks fine by me. > > Didn't you miss the apci_pci_choose_state() thing that also

Re: i915 hibernation patch (was: Re: [Suspend-devel] 2.6.25-rc2 System no longer powers off aftersuspend-to-disk. Screen becomes green.)

2008-02-22 Thread Rafael J. Wysocki
On Saturday, 23 of February 2008, Linus Torvalds wrote: > > On Sat, 23 Feb 2008, Rafael J. Wysocki wrote: > > > --- linux-2.6.orig/drivers/char/drm/i915_drv.c > > +++ linux-2.6/drivers/char/drm/i915_drv.c > > @@ -222,6 +222,7 @@ static void i915_restore_vga(struct drm_ > >

Re: i915 hibernation patch (was: Re: [Suspend-devel] 2.6.25-rc2 System no longer powers off aftersuspend-to-disk. Screen becomes green.)

2008-02-22 Thread Linus Torvalds
On Sat, 23 Feb 2008, Rafael J. Wysocki wrote: > --- linux-2.6.orig/drivers/char/drm/i915_drv.c > +++ linux-2.6/drivers/char/drm/i915_drv.c > @@ -222,6 +222,7 @@ static void i915_restore_vga(struct drm_ > dev_priv->saveGR[0x18]); > > /* Attribute controller

i915 hibernation patch (was: Re: [Suspend-devel] 2.6.25-rc2 System no longer powers off aftersuspend-to-disk. Screen becomes green.)

2008-02-22 Thread Rafael J. Wysocki
On Friday, 22 of February 2008, Jesse Barnes wrote: > On Thursday, February 21, 2008 5:13 pm Jesse Barnes wrote: > > On Thursday, February 21, 2008 4:54 pm Rafael J. Wysocki wrote: > > > On Friday, 22 of February 2008, Linus Torvalds wrote: > > > > On Fri, 22 Feb 2008, Rafael J. Wysocki wrote: > >

i915 hibernation patch (was: Re: [Suspend-devel] 2.6.25-rc2 System no longer powers off aftersuspend-to-disk. Screen becomes green.)

2008-02-22 Thread Rafael J. Wysocki
On Friday, 22 of February 2008, Jesse Barnes wrote: On Thursday, February 21, 2008 5:13 pm Jesse Barnes wrote: On Thursday, February 21, 2008 4:54 pm Rafael J. Wysocki wrote: On Friday, 22 of February 2008, Linus Torvalds wrote: On Fri, 22 Feb 2008, Rafael J. Wysocki wrote: - if

Re: i915 hibernation patch (was: Re: [Suspend-devel] 2.6.25-rc2 System no longer powers off aftersuspend-to-disk. Screen becomes green.)

2008-02-22 Thread Linus Torvalds
On Sat, 23 Feb 2008, Rafael J. Wysocki wrote: --- linux-2.6.orig/drivers/char/drm/i915_drv.c +++ linux-2.6/drivers/char/drm/i915_drv.c @@ -222,6 +222,7 @@ static void i915_restore_vga(struct drm_ dev_priv-saveGR[0x18]); /* Attribute controller registers */

Re: i915 hibernation patch (was: Re: [Suspend-devel] 2.6.25-rc2 System no longer powers off aftersuspend-to-disk. Screen becomes green.)

2008-02-22 Thread Rafael J. Wysocki
On Saturday, 23 of February 2008, Linus Torvalds wrote: On Sat, 23 Feb 2008, Rafael J. Wysocki wrote: --- linux-2.6.orig/drivers/char/drm/i915_drv.c +++ linux-2.6/drivers/char/drm/i915_drv.c @@ -222,6 +222,7 @@ static void i915_restore_vga(struct drm_

Re: i915 hibernation patch (was: Re: [Suspend-devel] 2.6.25-rc2 System no longer powers off aftersuspend-to-disk. Screen becomes green.)

2008-02-22 Thread Linus Torvalds
On Sat, 23 Feb 2008, Rafael J. Wysocki wrote: In the revised patch below I redefined the PM_EVENT_* things as flags so that I can or them and defined PM_EVENT_SLEEP in analogy with CONFIG_PM_SLEEP. Ok, looks fine by me. Didn't you miss the apci_pci_choose_state() thing that also needs

Re: i915 hibernation patch (was: Re: [Suspend-devel] 2.6.25-rc2 System no longer powers off aftersuspend-to-disk. Screen becomes green.)

2008-02-22 Thread Jeff Chua
On Sat, Feb 23, 2008 at 10:07 AM, Linus Torvalds [EMAIL PROTECTED] wrote: On Sat, 23 Feb 2008, Rafael J. Wysocki wrote: OK, please have a look at the modified patch below. All right, I'm fine with it. Now we just need to confirm that it works for people.. Looks good. Applied Rafael