Re: kvm splat in mmu_spte_clear_track_bits

On Tue 29-08-17 16:09:24, Andrea Arcangeli wrote: [...] > The other bug where you can reproduce the same corruption with OOM is > unrelated and caused by the OOM reaper. OOM reaper was even corrupting > data if a task was writing to disk and stuck in OOM in write() syscall > or async io write. >

Re: kvm splat in mmu_spte_clear_track_bits

On Tue 29-08-17 16:09:24, Andrea Arcangeli wrote: [...] > The other bug where you can reproduce the same corruption with OOM is > unrelated and caused by the OOM reaper. OOM reaper was even corrupting > data if a task was writing to disk and stuck in OOM in write() syscall > or async io write. >

Re: kvm splat in mmu_spte_clear_track_bits

On Tue, Aug 29, 2017 at 1:49 PM, Andrea Arcangeli wrote: > > mmu_notifier_invalidate_page has the advantage that it takes the > secondary MMU KVM srcu and spinlock a single time. Note that that isn't actually all that much of an advantage - it turns out that a lot of users

Re: kvm splat in mmu_spte_clear_track_bits

On Tue, Aug 29, 2017 at 1:49 PM, Andrea Arcangeli wrote: > > mmu_notifier_invalidate_page has the advantage that it takes the > secondary MMU KVM srcu and spinlock a single time. Note that that isn't actually all that much of an advantage - it turns out that a lot of users have "range_start",

Re: kvm splat in mmu_spte_clear_track_bits

Hello Linus, On Tue, Aug 29, 2017 at 12:38:43PM -0700, Linus Torvalds wrote: > On Tue, Aug 29, 2017 at 12:13 PM, Jerome Glisse wrote: > > > > Yes and i am fine with page traversal being under spinlock and not > > being able to sleep during that. I agree doing otherwise would

Re: kvm splat in mmu_spte_clear_track_bits

Hello Linus, On Tue, Aug 29, 2017 at 12:38:43PM -0700, Linus Torvalds wrote: > On Tue, Aug 29, 2017 at 12:13 PM, Jerome Glisse wrote: > > > > Yes and i am fine with page traversal being under spinlock and not > > being able to sleep during that. I agree doing otherwise would be > > insane. It is

Re: kvm splat in mmu_spte_clear_track_bits

On Tue, Aug 29, 2017 at 12:13 PM, Jerome Glisse wrote: > > Yes and i am fine with page traversal being under spinlock and not > being able to sleep during that. I agree doing otherwise would be > insane. It is just that the existing behavior of try_to_unmap_one() > and

Re: kvm splat in mmu_spte_clear_track_bits

On Tue, Aug 29, 2017 at 12:13 PM, Jerome Glisse wrote: > > Yes and i am fine with page traversal being under spinlock and not > being able to sleep during that. I agree doing otherwise would be > insane. It is just that the existing behavior of try_to_unmap_one() > and page_mkclean_one() have

Re: kvm splat in mmu_spte_clear_track_bits

On Tue, Aug 29, 2017 at 12:06:42PM -0700, Linus Torvalds wrote: > On Tue, Aug 29, 2017 at 11:34 AM, Jerome Glisse wrote: > > > > Kirill did regress invalidate_page as it use to be call outside the > > spinlock and now it is call inside the spinlock thus reverting will > >

Re: kvm splat in mmu_spte_clear_track_bits

On Tue, Aug 29, 2017 at 12:06:42PM -0700, Linus Torvalds wrote: > On Tue, Aug 29, 2017 at 11:34 AM, Jerome Glisse wrote: > > > > Kirill did regress invalidate_page as it use to be call outside the > > spinlock and now it is call inside the spinlock thus reverting will > > introduce back a

Re: kvm splat in mmu_spte_clear_track_bits

On Tue, Aug 29, 2017 at 11:34 AM, Jerome Glisse wrote: > > Kirill did regress invalidate_page as it use to be call outside the > spinlock and now it is call inside the spinlock thus reverting will > introduce back a regression. Honestly, this MMU notifier thing has been

Re: kvm splat in mmu_spte_clear_track_bits

On Tue, Aug 29, 2017 at 11:34 AM, Jerome Glisse wrote: > > Kirill did regress invalidate_page as it use to be call outside the > spinlock and now it is call inside the spinlock thus reverting will > introduce back a regression. Honestly, this MMU notifier thing has been nothing but a badly

Re: kvm splat in mmu_spte_clear_track_bits

On Tue, Aug 29, 2017 at 04:09:24PM +0200, Andrea Arcangeli wrote: > Hello, > > On Tue, Aug 29, 2017 at 02:59:23PM +0200, Adam Borowski wrote: > > On Tue, Aug 29, 2017 at 02:45:41PM +0200, Takashi Iwai wrote: > > > [Put more people to Cc, sorry for growing too much...] > > > > We're all

Re: kvm splat in mmu_spte_clear_track_bits

On Tue, Aug 29, 2017 at 04:09:24PM +0200, Andrea Arcangeli wrote: > Hello, > > On Tue, Aug 29, 2017 at 02:59:23PM +0200, Adam Borowski wrote: > > On Tue, Aug 29, 2017 at 02:45:41PM +0200, Takashi Iwai wrote: > > > [Put more people to Cc, sorry for growing too much...] > > > > We're all

Re: kvm splat in mmu_spte_clear_track_bits

On Tue, Aug 29, 2017 at 09:10:59AM -0700, Linus Torvalds wrote: > On Tue, Aug 29, 2017 at 7:09 AM, Andrea Arcangeli wrote: > > Hello, > > > > On Tue, Aug 29, 2017 at 02:59:23PM +0200, Adam Borowski wrote: > >> On Tue, Aug 29, 2017 at 02:45:41PM +0200, Takashi Iwai wrote: > >>

Re: kvm splat in mmu_spte_clear_track_bits

On Tue, Aug 29, 2017 at 09:10:59AM -0700, Linus Torvalds wrote: > On Tue, Aug 29, 2017 at 7:09 AM, Andrea Arcangeli wrote: > > Hello, > > > > On Tue, Aug 29, 2017 at 02:59:23PM +0200, Adam Borowski wrote: > >> On Tue, Aug 29, 2017 at 02:45:41PM +0200, Takashi Iwai wrote: > >> > [Put more people

Re: kvm splat in mmu_spte_clear_track_bits

On Tue, Aug 29, 2017 at 7:09 AM, Andrea Arcangeli wrote: > Hello, > > On Tue, Aug 29, 2017 at 02:59:23PM +0200, Adam Borowski wrote: >> On Tue, Aug 29, 2017 at 02:45:41PM +0200, Takashi Iwai wrote: >> > [Put more people to Cc, sorry for growing too much...] >> >> We're all

Re: kvm splat in mmu_spte_clear_track_bits

On Tue, Aug 29, 2017 at 7:09 AM, Andrea Arcangeli wrote: > Hello, > > On Tue, Aug 29, 2017 at 02:59:23PM +0200, Adam Borowski wrote: >> On Tue, Aug 29, 2017 at 02:45:41PM +0200, Takashi Iwai wrote: >> > [Put more people to Cc, sorry for growing too much...] >> >> We're all interested in 4.13.0

Re: kvm splat in mmu_spte_clear_track_bits

Bernhard Held wrote: > On 08/28/2017 at 06:56 PM, Nadav Amit wrote: >> Bernhard Held wrote: >>> On 08/27/2017 at 02:35 PM, Adam Borowski wrote: 4.13-rc5 retested fails Crashed only after two hours or so of testing. 4.13-rc4 apparently works

Re: kvm splat in mmu_spte_clear_track_bits

Bernhard Held wrote: > On 08/28/2017 at 06:56 PM, Nadav Amit wrote: >> Bernhard Held wrote: >>> On 08/27/2017 at 02:35 PM, Adam Borowski wrote: 4.13-rc5 retested fails Crashed only after two hours or so of testing. 4.13-rc4 apparently works It survived several hours of

Re: kvm splat in mmu_spte_clear_track_bits

Hello, On Tue, Aug 29, 2017 at 02:59:23PM +0200, Adam Borowski wrote: > On Tue, Aug 29, 2017 at 02:45:41PM +0200, Takashi Iwai wrote: > > [Put more people to Cc, sorry for growing too much...] > > We're all interested in 4.13.0 not crashing on us, so that's ok. > > > On Tue, 29 Aug 2017

Re: kvm splat in mmu_spte_clear_track_bits

Hello, On Tue, Aug 29, 2017 at 02:59:23PM +0200, Adam Borowski wrote: > On Tue, Aug 29, 2017 at 02:45:41PM +0200, Takashi Iwai wrote: > > [Put more people to Cc, sorry for growing too much...] > > We're all interested in 4.13.0 not crashing on us, so that's ok. > > > On Tue, 29 Aug 2017

Re: kvm splat in mmu_spte_clear_track_bits

On Tue, Aug 29, 2017 at 02:45:41PM +0200, Takashi Iwai wrote: > [Put more people to Cc, sorry for growing too much...] We're all interested in 4.13.0 not crashing on us, so that's ok. > On Tue, 29 Aug 2017 11:19:13 +0200, > Bernhard Held wrote: > > > > On 08/28/2017 at 06:56 PM, Nadav Amit

Re: kvm splat in mmu_spte_clear_track_bits

On Tue, Aug 29, 2017 at 02:45:41PM +0200, Takashi Iwai wrote: > [Put more people to Cc, sorry for growing too much...] We're all interested in 4.13.0 not crashing on us, so that's ok. > On Tue, 29 Aug 2017 11:19:13 +0200, > Bernhard Held wrote: > > > > On 08/28/2017 at 06:56 PM, Nadav Amit

Re: kvm splat in mmu_spte_clear_track_bits

On Mon, 2017-08-28 at 09:56 -0700, Nadav Amit wrote: > Bernhard Held wrote: > > > On 08/27/2017 at 02:35 PM, Adam Borowski wrote: > >> 4.13-rc5 retested fails > >> Crashed only after two hours or so of testing. > >> 4.13-rc4 apparently works > >> It survived several hours of

Re: kvm splat in mmu_spte_clear_track_bits

On Mon, 2017-08-28 at 09:56 -0700, Nadav Amit wrote: > Bernhard Held wrote: > > > On 08/27/2017 at 02:35 PM, Adam Borowski wrote: > >> 4.13-rc5 retested fails > >> Crashed only after two hours or so of testing. > >> 4.13-rc4 apparently works > >> It survived several hours of varied tests (like 5

Re: kvm splat in mmu_spte_clear_track_bits

On 08/28/2017 at 06:56 PM, Nadav Amit wrote: Bernhard Held wrote: On 08/27/2017 at 02:35 PM, Adam Borowski wrote: 4.13-rc5 retested fails Crashed only after two hours or so of testing. 4.13-rc4 apparently works It survived several hours of varied tests (like 5

Re: kvm splat in mmu_spte_clear_track_bits

On 08/28/2017 at 06:56 PM, Nadav Amit wrote: Bernhard Held wrote: On 08/27/2017 at 02:35 PM, Adam Borowski wrote: 4.13-rc5 retested fails Crashed only after two hours or so of testing. 4.13-rc4 apparently works It survived several hours of varied tests (like 5 debian-installer runs, a win10

Re: kvm splat in mmu_spte_clear_track_bits

Bernhard Held wrote: > On 08/27/2017 at 02:35 PM, Adam Borowski wrote: >> 4.13-rc5 retested fails >> Crashed only after two hours or so of testing. >> 4.13-rc4 apparently works >> It survived several hours of varied tests (like 5 debian-installer runs, a >> win10 point release

Re: kvm splat in mmu_spte_clear_track_bits

Bernhard Held wrote: > On 08/27/2017 at 02:35 PM, Adam Borowski wrote: >> 4.13-rc5 retested fails >> Crashed only after two hours or so of testing. >> 4.13-rc4 apparently works >> It survived several hours of varied tests (like 5 debian-installer runs, a >> win10 point release upgrade, some hurd

Re: kvm splat in mmu_spte_clear_track_bits

On Mon, 28 Aug 2017 18:07:37 +0200, Bernhard Held wrote: > > On 08/28/2017 at 06:01 PM, Takashi Iwai wrote: > > On Mon, 28 Aug 2017 17:26:05 +0200, > > Bernhard Held wrote: > >> I get crashes with Win10 in kvm > >> > > Did you get the crash reliably? > > I've been struggling how to trigger it

Re: kvm splat in mmu_spte_clear_track_bits

On Mon, 28 Aug 2017 18:07:37 +0200, Bernhard Held wrote: > > On 08/28/2017 at 06:01 PM, Takashi Iwai wrote: > > On Mon, 28 Aug 2017 17:26:05 +0200, > > Bernhard Held wrote: > >> I get crashes with Win10 in kvm > >> > > Did you get the crash reliably? > > I've been struggling how to trigger it

Re: kvm splat in mmu_spte_clear_track_bits

On 08/28/2017 at 06:01 PM, Takashi Iwai wrote: On Mon, 28 Aug 2017 17:26:05 +0200, Bernhard Held wrote: I get crashes with Win10 in kvm Did you get the crash reliably? I've been struggling how to trigger it efficiently, but currently in vain. The memory pressure isn't a single key to trigger

Re: kvm splat in mmu_spte_clear_track_bits

On 08/28/2017 at 06:01 PM, Takashi Iwai wrote: On Mon, 28 Aug 2017 17:26:05 +0200, Bernhard Held wrote: I get crashes with Win10 in kvm Did you get the crash reliably? I've been struggling how to trigger it efficiently, but currently in vain. The memory pressure isn't a single key to trigger

Re: kvm splat in mmu_spte_clear_track_bits

On Mon, 28 Aug 2017 17:26:05 +0200, Bernhard Held wrote: > > On 08/27/2017 at 02:35 PM, Adam Borowski wrote: > > 4.13-rc5 retested fails > > Crashed only after two hours or so of testing. > > > > 4.13-rc4 apparently works > > It survived several hours of varied tests (like 5 debian-installer

Re: kvm splat in mmu_spte_clear_track_bits

On Mon, 28 Aug 2017 17:26:05 +0200, Bernhard Held wrote: > > On 08/27/2017 at 02:35 PM, Adam Borowski wrote: > > 4.13-rc5 retested fails > > Crashed only after two hours or so of testing. > > > > 4.13-rc4 apparently works > > It survived several hours of varied tests (like 5 debian-installer

Re: kvm splat in mmu_spte_clear_track_bits

On 08/27/2017 at 02:35 PM, Adam Borowski wrote: 4.13-rc5 retested fails Crashed only after two hours or so of testing. 4.13-rc4 apparently works It survived several hours of varied tests (like 5 debian-installer runs, a win10 point release upgrade, some hurd package building, openbsd, etc), all

Re: kvm splat in mmu_spte_clear_track_bits

On 08/27/2017 at 02:35 PM, Adam Borowski wrote: 4.13-rc5 retested fails Crashed only after two hours or so of testing. 4.13-rc4 apparently works It survived several hours of varied tests (like 5 debian-installer runs, a win10 point release upgrade, some hurd package building, openbsd, etc), all

Re: kvm splat in mmu_spte_clear_track_bits

On Fri, Aug 25, 2017 at 03:40:50PM +0200, Paolo Bonzini wrote: > On 25/08/2017 15:14, Adam Borowski wrote: > >>> I would also try commit 1372324b328cd5dabaef5e345e37ad48c63df2a9 to > >>> identify whether it was caused by a KVM change in 4.13 or something > >>> else. > > I've ran different guests

Re: kvm splat in mmu_spte_clear_track_bits

On Fri, Aug 25, 2017 at 03:40:50PM +0200, Paolo Bonzini wrote: > On 25/08/2017 15:14, Adam Borowski wrote: > >>> I would also try commit 1372324b328cd5dabaef5e345e37ad48c63df2a9 to > >>> identify whether it was caused by a KVM change in 4.13 or something > >>> else. > > I've ran different guests

Re: kvm splat in mmu_spte_clear_track_bits

On 25/08/2017 15:14, Adam Borowski wrote: >>> I would also try commit 1372324b328cd5dabaef5e345e37ad48c63df2a9 to >>> identify whether it was caused by a KVM change in 4.13 or something >>> else. > I've ran different guests for a couple of hours, no explosions. Thus it > looks like updating

Re: kvm splat in mmu_spte_clear_track_bits

On 25/08/2017 15:14, Adam Borowski wrote: >>> I would also try commit 1372324b328cd5dabaef5e345e37ad48c63df2a9 to >>> identify whether it was caused by a KVM change in 4.13 or something >>> else. > I've ran different guests for a couple of hours, no explosions. Thus it > looks like updating

Re: kvm splat in mmu_spte_clear_track_bits

On Thu, Aug 24, 2017 at 03:43:55PM +0800, Wanpeng Li wrote: > 2017-08-23 20:22 GMT+08:00 Paolo Bonzini : > > On 22/08/2017 00:32, Adam Borowski wrote: > >> On Mon, Aug 21, 2017 at 09:58:34PM +0200, Radim Krčmář wrote: > >>> 2017-08-21 21:12+0200, Adam Borowski: > Also, it

Re: kvm splat in mmu_spte_clear_track_bits

On Thu, Aug 24, 2017 at 03:43:55PM +0800, Wanpeng Li wrote: > 2017-08-23 20:22 GMT+08:00 Paolo Bonzini : > > On 22/08/2017 00:32, Adam Borowski wrote: > >> On Mon, Aug 21, 2017 at 09:58:34PM +0200, Radim Krčmář wrote: > >>> 2017-08-21 21:12+0200, Adam Borowski: > Also, it doesn't reproduce

Re: kvm splat in mmu_spte_clear_track_bits

2017-08-23 20:22 GMT+08:00 Paolo Bonzini : > On 22/08/2017 00:32, Adam Borowski wrote: >> On Mon, Aug 21, 2017 at 09:58:34PM +0200, Radim Krčmář wrote: >>> 2017-08-21 21:12+0200, Adam Borowski: On Mon, Aug 21, 2017 at 09:26:57AM +0800, Wanpeng Li wrote: > 2017-08-21

Re: kvm splat in mmu_spte_clear_track_bits

2017-08-23 20:22 GMT+08:00 Paolo Bonzini : > On 22/08/2017 00:32, Adam Borowski wrote: >> On Mon, Aug 21, 2017 at 09:58:34PM +0200, Radim Krčmář wrote: >>> 2017-08-21 21:12+0200, Adam Borowski: On Mon, Aug 21, 2017 at 09:26:57AM +0800, Wanpeng Li wrote: > 2017-08-21 7:13 GMT+08:00 Adam

Re: kvm splat in mmu_spte_clear_track_bits

On 22/08/2017 00:32, Adam Borowski wrote: > On Mon, Aug 21, 2017 at 09:58:34PM +0200, Radim Krčmář wrote: >> 2017-08-21 21:12+0200, Adam Borowski: >>> On Mon, Aug 21, 2017 at 09:26:57AM +0800, Wanpeng Li wrote: 2017-08-21 7:13 GMT+08:00 Adam Borowski : > I'm afraid I

Re: kvm splat in mmu_spte_clear_track_bits

On 22/08/2017 00:32, Adam Borowski wrote: > On Mon, Aug 21, 2017 at 09:58:34PM +0200, Radim Krčmář wrote: >> 2017-08-21 21:12+0200, Adam Borowski: >>> On Mon, Aug 21, 2017 at 09:26:57AM +0800, Wanpeng Li wrote: 2017-08-21 7:13 GMT+08:00 Adam Borowski : > I'm afraid I keep getting a quite

Re: kvm splat in mmu_spte_clear_track_bits

On Mon, Aug 21, 2017 at 09:58:34PM +0200, Radim Krčmář wrote: > 2017-08-21 21:12+0200, Adam Borowski: > > On Mon, Aug 21, 2017 at 09:26:57AM +0800, Wanpeng Li wrote: > > > 2017-08-21 7:13 GMT+08:00 Adam Borowski : > > > > I'm afraid I keep getting a quite reliable, but random,

Re: kvm splat in mmu_spte_clear_track_bits

On Mon, Aug 21, 2017 at 09:58:34PM +0200, Radim Krčmář wrote: > 2017-08-21 21:12+0200, Adam Borowski: > > On Mon, Aug 21, 2017 at 09:26:57AM +0800, Wanpeng Li wrote: > > > 2017-08-21 7:13 GMT+08:00 Adam Borowski : > > > > I'm afraid I keep getting a quite reliable, but random, splat when > > > >

Re: kvm splat in mmu_spte_clear_track_bits

2017-08-21 21:12+0200, Adam Borowski: > On Mon, Aug 21, 2017 at 09:26:57AM +0800, Wanpeng Li wrote: > > 2017-08-21 7:13 GMT+08:00 Adam Borowski : > > > Hi! > > > I'm afraid I keep getting a quite reliable, but random, splat when running > > > KVM: > > > > I reported something

Re: kvm splat in mmu_spte_clear_track_bits

2017-08-21 21:12+0200, Adam Borowski: > On Mon, Aug 21, 2017 at 09:26:57AM +0800, Wanpeng Li wrote: > > 2017-08-21 7:13 GMT+08:00 Adam Borowski : > > > Hi! > > > I'm afraid I keep getting a quite reliable, but random, splat when running > > > KVM: > > > > I reported something similar before.

Re: kvm splat in mmu_spte_clear_track_bits

On Mon, Aug 21, 2017 at 09:26:57AM +0800, Wanpeng Li wrote: > 2017-08-21 7:13 GMT+08:00 Adam Borowski : > > Hi! > > I'm afraid I keep getting a quite reliable, but random, splat when running > > KVM: > > I reported something similar before. https://lkml.org/lkml/2017/6/29/64

Re: kvm splat in mmu_spte_clear_track_bits

On Mon, Aug 21, 2017 at 09:26:57AM +0800, Wanpeng Li wrote: > 2017-08-21 7:13 GMT+08:00 Adam Borowski : > > Hi! > > I'm afraid I keep getting a quite reliable, but random, splat when running > > KVM: > > I reported something similar before. https://lkml.org/lkml/2017/6/29/64 Your problem seems

Re: kvm splat in mmu_spte_clear_track_bits

2017-08-21 7:13 GMT+08:00 Adam Borowski : > Hi! > I'm afraid I keep getting a quite reliable, but random, splat when running > KVM: I reported something similar before. https://lkml.org/lkml/2017/6/29/64 Regards, Wanpeng Li > > [ cut here ] >

Re: kvm splat in mmu_spte_clear_track_bits

2017-08-21 7:13 GMT+08:00 Adam Borowski : > Hi! > I'm afraid I keep getting a quite reliable, but random, splat when running > KVM: I reported something similar before. https://lkml.org/lkml/2017/6/29/64 Regards, Wanpeng Li > > [ cut here ] > WARNING: CPU: 5 PID: 5826 at

kvm splat in mmu_spte_clear_track_bits

Hi! I'm afraid I keep getting a quite reliable, but random, splat when running KVM: [ cut here ] WARNING: CPU: 5 PID: 5826 at arch/x86/kvm/mmu.c:717 mmu_spte_clear_track_bits+0x123/0x170 Modules linked in: tun nbd arc4 rtl8xxxu mac80211 cfg80211 rfkill nouveau video ttm

kvm splat in mmu_spte_clear_track_bits

Hi! I'm afraid I keep getting a quite reliable, but random, splat when running KVM: [ cut here ] WARNING: CPU: 5 PID: 5826 at arch/x86/kvm/mmu.c:717 mmu_spte_clear_track_bits+0x123/0x170 Modules linked in: tun nbd arc4 rtl8xxxu mac80211 cfg80211 rfkill nouveau video ttm