Re: linux-next: Fixes tag needs some work in the block tree

2021-03-05 Thread Jens Axboe
On 3/5/21 12:46 AM, Christoph Hellwig wrote: > On Thu, Mar 04, 2021 at 05:26:42PM -0700, Jens Axboe wrote: >> Christoph, since there's multiple commits with issues, mind resending >> a fixed branch? Then I'll drop the one I pulled today. > > I've fixed the commit id and dropped the patch without

Re: linux-next: Fixes tag needs some work in the block tree

2021-03-04 Thread Christoph Hellwig
On Thu, Mar 04, 2021 at 05:26:42PM -0700, Jens Axboe wrote: > Christoph, since there's multiple commits with issues, mind resending > a fixed branch? Then I'll drop the one I pulled today. I've fixed the commit id and dropped the patch without the author signoff, but your branch still has the

Re: linux-next: Fixes tag needs some work in the block tree

2021-03-04 Thread Jens Axboe
On 3/4/21 4:52 PM, Stephen Rothwell wrote: > Hi all, > > In commit > > 284e4cdb0c0b ("nvme-hwmon: Return error code when registration fails") > > Fixes tag > > Fixes: ec420cdcfab4 ("nvme/hwmon: rework to avoid devm allocation") > > has these problem(s): > > - Target SHA1 does not exist

linux-next: Fixes tag needs some work in the block tree

2021-03-04 Thread Stephen Rothwell
Hi all, In commit 284e4cdb0c0b ("nvme-hwmon: Return error code when registration fails") Fixes tag Fixes: ec420cdcfab4 ("nvme/hwmon: rework to avoid devm allocation") has these problem(s): - Target SHA1 does not exist Maybe you meant Fixes: ed7770f66286 ("nvme-hwmon: rework to avoid

Re: linux-next: Fixes tag needs some work in the block tree

2021-02-22 Thread Chaitanya Kulkarni
On 2/22/21 13:01, Stephen Rothwell wrote: > Hi all, > > In commit > > 179d16007236 ("block: remove superfluous param in blk_fill_rwbs()") > > Fixes tag > > Fixes: 1b9a9ab78b0 ("blktrace: use op accessors") > > has these problem(s): > > - SHA1 should be at least 12 digits long > Can be

linux-next: Fixes tag needs some work in the block tree

2021-02-22 Thread Stephen Rothwell
Hi all, In commit 179d16007236 ("block: remove superfluous param in blk_fill_rwbs()") Fixes tag Fixes: 1b9a9ab78b0 ("blktrace: use op accessors") has these problem(s): - SHA1 should be at least 12 digits long Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11

Re: linux-next: Fixes tag needs some work in the block tree

2021-02-19 Thread Jens Axboe
On 2/19/21 9:51 PM, Stephen Rothwell wrote: > Hi all, > > In commit > > 76676c992506 ("io_uring: fix io_rsrc_ref_quiesce races") > > Fixes tag > > Fixes: 0ce4a72632317 ("io_uring: don't hold uring_lock when calling > io_run_task_work*") > > has these problem(s): > > - Target SHA1 does

linux-next: Fixes tag needs some work in the block tree

2021-02-19 Thread Stephen Rothwell
Hi all, In commit 76676c992506 ("io_uring: fix io_rsrc_ref_quiesce races") Fixes tag Fixes: 0ce4a72632317 ("io_uring: don't hold uring_lock when calling io_run_task_work*") has these problem(s): - Target SHA1 does not exist Maybe you meant Fixes: a4f2225d1cb2 ("io_uring: don't hold

linux-next: Fixes tag needs some work in the block tree

2021-02-04 Thread Stephen Rothwell
Hi all, In commit 8a0c014cd205 ("floppy: reintroduce O_NDELAY fix") Fixes tag Fixes: 09954bad4 ("floppy: refactor open() flags handling") has these problem(s): - SHA1 should be at least 12 digits long Fixes tag Fixes: f2791e7ead ("Revert "floppy: refactor open() flags handling"")

linux-next: Fixes tag needs some work in the block tree

2021-01-26 Thread Stephen Rothwell
Hi all, In commit d4fc3640ff36 ("block, bfq: set next_rq to waker_bfqq->next_rq in waker injection") Fixes tag Fixes: c5089591c3ba ("block, bfq: detect wakers and unconditionally inject their I/O") has these problem(s): - Target SHA1 does not exist Maybe you meant Fixes:

Re: linux-next: Fixes tag needs some work in the block tree

2021-01-26 Thread Jens Axboe
On 1/26/21 9:01 AM, Jan Kara wrote: > On Tue 26-01-21 08:47:55, Jens Axboe wrote: >> On 1/26/21 6:29 AM, Jan Kara wrote: >>> On Mon 25-01-21 11:39:50, Jens Axboe wrote: On 1/25/21 11:35 AM, Paolo Valente wrote: > > >> Il giorno 25 gen 2021, alle ore 10:40, Stephen Rothwell >>

Re: linux-next: Fixes tag needs some work in the block tree

2021-01-26 Thread Jan Kara
On Tue 26-01-21 08:47:55, Jens Axboe wrote: > On 1/26/21 6:29 AM, Jan Kara wrote: > > On Mon 25-01-21 11:39:50, Jens Axboe wrote: > >> On 1/25/21 11:35 AM, Paolo Valente wrote: > >>> > >>> > Il giorno 25 gen 2021, alle ore 10:40, Stephen Rothwell > ha scritto: > > Hi all, >

Re: linux-next: Fixes tag needs some work in the block tree

2021-01-26 Thread Jens Axboe
On 1/26/21 6:29 AM, Jan Kara wrote: > On Mon 25-01-21 11:39:50, Jens Axboe wrote: >> On 1/25/21 11:35 AM, Paolo Valente wrote: >>> >>> Il giorno 25 gen 2021, alle ore 10:40, Stephen Rothwell ha scritto: Hi all, In commit d4fc3640ff36 ("block, bfq: set

Re: linux-next: Fixes tag needs some work in the block tree

2021-01-26 Thread Jan Kara
On Mon 25-01-21 11:39:50, Jens Axboe wrote: > On 1/25/21 11:35 AM, Paolo Valente wrote: > > > > > >> Il giorno 25 gen 2021, alle ore 10:40, Stephen Rothwell > >> ha scritto: > >> > >> Hi all, > >> > >> In commit > >> > >> d4fc3640ff36 ("block, bfq: set next_rq to waker_bfqq->next_rq in waker

Re: linux-next: Fixes tag needs some work in the block tree

2021-01-25 Thread Jens Axboe
On 1/25/21 11:35 AM, Paolo Valente wrote: > > >> Il giorno 25 gen 2021, alle ore 10:40, Stephen Rothwell >> ha scritto: >> >> Hi all, >> >> In commit >> >> d4fc3640ff36 ("block, bfq: set next_rq to waker_bfqq->next_rq in waker >> injection") >> >> Fixes tag >> >> Fixes: c5089591c3ba

Re: linux-next: Fixes tag needs some work in the block tree

2021-01-25 Thread Paolo Valente
> Il giorno 25 gen 2021, alle ore 10:40, Stephen Rothwell > ha scritto: > > Hi all, > > In commit > > d4fc3640ff36 ("block, bfq: set next_rq to waker_bfqq->next_rq in waker > injection") > > Fixes tag > > Fixes: c5089591c3ba ("block, bfq: detect wakers and unconditionally inject >

Re: linux-next: Fixes tag needs some work in the block tree

2020-12-17 Thread Jens Axboe
On 12/17/20 1:38 PM, Stephen Rothwell wrote: > Hi all, > > In commit > > 358e7cbf87b4 ("s390/dasd: fix hanging device offline processing") > > Fixes tag > > Fixes: 47825e05d93e ("s390/dasd: fix endless loop after read unit address > configuration") > > has these problem(s): > > -

linux-next: Fixes tag needs some work in the block tree

2020-12-17 Thread Stephen Rothwell
Hi all, In commit 358e7cbf87b4 ("s390/dasd: fix hanging device offline processing") Fixes tag Fixes: 47825e05d93e ("s390/dasd: fix endless loop after read unit address configuration") has these problem(s): - Target SHA1 does not exist Maybe you meant Fixes: 41995342b40c ("s390/dasd:

Re: linux-next: Fixes tag needs some work in the block tree

2020-12-01 Thread Jens Axboe
On 12/1/20 2:44 PM, Stephen Rothwell wrote: > Hi Jens, > > On Tue, 1 Dec 2020 14:09:24 -0700 Jens Axboe wrote: >> >> On 12/1/20 2:02 PM, Stephen Rothwell wrote: >>> >>> In commit >>> >>> 573cc9d095bc ("blk-cgroup: fix a hd_struct leak in >>> blkcg_fill_root_iostats") >>> >>> Fixes tag >>> >>>

Re: linux-next: Fixes tag needs some work in the block tree

2020-12-01 Thread Stephen Rothwell
Hi Jens, On Tue, 1 Dec 2020 14:09:24 -0700 Jens Axboe wrote: > > On 12/1/20 2:02 PM, Stephen Rothwell wrote: > > > > In commit > > > > 573cc9d095bc ("blk-cgroup: fix a hd_struct leak in > > blkcg_fill_root_iostats") > > > > Fixes tag > > > > Fixes: ef45fe470e1 ("blk-cgroup: show global

Re: linux-next: Fixes tag needs some work in the block tree

2020-12-01 Thread Jens Axboe
On 12/1/20 2:02 PM, Stephen Rothwell wrote: > Hi all, > > In commit > > 573cc9d095bc ("blk-cgroup: fix a hd_struct leak in blkcg_fill_root_iostats") > > Fixes tag > > Fixes: ef45fe470e1 ("blk-cgroup: show global disk stats in root cgroup > io.stat") > > has these problem(s): > > -

linux-next: Fixes tag needs some work in the block tree

2020-12-01 Thread Stephen Rothwell
Hi all, In commit 573cc9d095bc ("blk-cgroup: fix a hd_struct leak in blkcg_fill_root_iostats") Fixes tag Fixes: ef45fe470e1 ("blk-cgroup: show global disk stats in root cgroup io.stat") has these problem(s): - SHA1 should be at least 12 digits long For the future, this can be fixed

linux-next: Fixes tag needs some work in the block tree

2020-11-30 Thread Stephen Rothwell
Hi all, In commit 107673613884 ("blk-cgroup: fix a hd_struct leak in blkcg_fill_root_iostats") Fixes tag Fixes: ef45fe470e1 ("blk-cgroup: show global disk stats in root cgroup io.stat") has these problem(s): - SHA1 should be at least 12 digits long For the future, this can be fixed

linux-next: Fixes tag needs some work in the block tree

2020-09-24 Thread Stephen Rothwell
Hi all, In commit 10988d55ae96 ("md/raid10: Change the return type of raid10_handle_discard to int") Fixes tag fixes: 8f694215ae4c (md/raid10: improve raid10 discard request) has these problem(s): - Target SHA1 does not exist Maybe you meant Fixes: 828d14fd7a6c ("md/raid10: improve

Re: linux-next: Fixes tag needs some work in the block tree

2020-07-30 Thread Jens Axboe
On 7/29/20 4:12 PM, Stephen Rothwell wrote: > Hi all, > > [Just adding cc's] > > On Thu, 30 Jul 2020 08:08:49 +1000 Stephen Rothwell > wrote: >> >> In commit >> >> 64d452b3560b ("nvme-loop: set ctrl state connecting after init") >> >> Fixes tag >> >> Fixes: aa63fa6776a7 ("nvme-fabrics:

Re: linux-next: Fixes tag needs some work in the block tree

2020-07-29 Thread Stephen Rothwell
Hi all, [Just adding cc's] On Thu, 30 Jul 2020 08:08:49 +1000 Stephen Rothwell wrote: > > In commit > > 64d452b3560b ("nvme-loop: set ctrl state connecting after init") > > Fixes tag > > Fixes: aa63fa6776a7 ("nvme-fabrics: allow to queue requests for live > queues") > > has these

linux-next: Fixes tag needs some work in the block tree

2020-07-29 Thread Stephen Rothwell
Hi all, In commit 64d452b3560b ("nvme-loop: set ctrl state connecting after init") Fixes tag Fixes: aa63fa6776a7 ("nvme-fabrics: allow to queue requests for live queues") has these problem(s): - Target SHA1 does not exist I can't easily find what commit is meant :-( -- Cheers,

Re: linux-next: Fixes tag needs some work in the block tree

2020-06-29 Thread Jens Axboe
On 6/29/20 4:36 PM, Stephen Rothwell wrote: > Hi all, > > On Mon, 29 Jun 2020 10:25:01 -0600 Jens Axboe wrote: >> >> On 6/29/20 10:21 AM, Pavel Begunkov wrote: >>> On 29/06/2020 01:05, Stephen Rothwell wrote: Hi all, In commit 8c9cb6cd9a46 ("io_uring: fix refs

Re: linux-next: Fixes tag needs some work in the block tree

2020-06-29 Thread Stephen Rothwell
Hi all, On Mon, 29 Jun 2020 10:25:01 -0600 Jens Axboe wrote: > > On 6/29/20 10:21 AM, Pavel Begunkov wrote: > > On 29/06/2020 01:05, Stephen Rothwell wrote: > >> Hi all, > >> > >> In commit > >> > >> 8c9cb6cd9a46 ("io_uring: fix refs underflow in io_iopoll_queue()") > >> > >> Fixes tag > >>

Re: linux-next: Fixes tag needs some work in the block tree

2020-06-29 Thread Pavel Begunkov
On 29/06/2020 01:05, Stephen Rothwell wrote: > Hi all, > > In commit > > 8c9cb6cd9a46 ("io_uring: fix refs underflow in io_iopoll_queue()") > > Fixes tag > > Fixes: a1d7c393c47 ("io_uring: enable READ/WRITE to use deferred > completions") Jens, could you please fix this up after me? full

Re: linux-next: Fixes tag needs some work in the block tree

2020-06-29 Thread Jens Axboe
On 6/29/20 10:21 AM, Pavel Begunkov wrote: > On 29/06/2020 01:05, Stephen Rothwell wrote: >> Hi all, >> >> In commit >> >> 8c9cb6cd9a46 ("io_uring: fix refs underflow in io_iopoll_queue()") >> >> Fixes tag >> >> Fixes: a1d7c393c47 ("io_uring: enable READ/WRITE to use deferred >> completions")

linux-next: Fixes tag needs some work in the block tree

2020-06-28 Thread Stephen Rothwell
Hi all, In commit 8c9cb6cd9a46 ("io_uring: fix refs underflow in io_iopoll_queue()") Fixes tag Fixes: a1d7c393c47 ("io_uring: enable READ/WRITE to use deferred completions") has these problem(s): - SHA1 should be at least 12 digits long Can be fixed by setting core.abbrev to 12 (or

Re: linux-next: Fixes tag needs some work in the block tree

2020-06-28 Thread Jens Axboe
On 6/26/20 11:12 PM, Stephen Rothwell wrote: > Hi Jens, > > On Fri, 26 Jun 2020 20:25:31 -0600 Jens Axboe wrote: >> >> Right, but that's what git format-patch does when the line is long. > > I just tested, and "git format-patch" (for me) does *not* split those lines. Huh, I could have sworn

Re: linux-next: Fixes tag needs some work in the block tree

2020-06-27 Thread Pavel Begunkov
On 27/06/2020 08:01, Stephen Rothwell wrote: > Hi Konstantin, > > On Fri, 26 Jun 2020 21:56:05 -0400 Konstantin Ryabitsev > wrote: >> >> On Fri, Jun 26, 2020 at 07:32:15PM -0600, Jens Axboe wrote: >>> On 6/26/20 5:07 PM, Stephen Rothwell wrote: Hi all, In commit

Re: linux-next: Fixes tag needs some work in the block tree

2020-06-26 Thread Stephen Rothwell
Hi Jens, On Fri, 26 Jun 2020 20:25:31 -0600 Jens Axboe wrote: > > Right, but that's what git format-patch does when the line is long. I just tested, and "git format-patch" (for me) does *not* split those lines. -- Cheers, Stephen Rothwell pgpMPaX2H1NdF.pgp Description: OpenPGP digital

Re: linux-next: Fixes tag needs some work in the block tree

2020-06-26 Thread Stephen Rothwell
Hi Konstantin, On Fri, 26 Jun 2020 21:56:05 -0400 Konstantin Ryabitsev wrote: > > On Fri, Jun 26, 2020 at 07:32:15PM -0600, Jens Axboe wrote: > > On 6/26/20 5:07 PM, Stephen Rothwell wrote: > > > Hi all, > > > > > > In commit > > > > > > cd664b0e35cb ("io_uring: fix hanging iopoll in case

Re: linux-next: Fixes tag needs some work in the block tree

2020-06-26 Thread Jens Axboe
On 6/26/20 7:56 PM, Konstantin Ryabitsev wrote: > On Fri, Jun 26, 2020 at 07:32:15PM -0600, Jens Axboe wrote: >> On 6/26/20 5:07 PM, Stephen Rothwell wrote: >>> Hi all, >>> >>> In commit >>> >>> cd664b0e35cb ("io_uring: fix hanging iopoll in case of -EAGAIN") >>> >>> Fixes tag >>> >>> Fixes:

Re: linux-next: Fixes tag needs some work in the block tree

2020-06-26 Thread Konstantin Ryabitsev
On Fri, Jun 26, 2020 at 07:32:15PM -0600, Jens Axboe wrote: > On 6/26/20 5:07 PM, Stephen Rothwell wrote: > > Hi all, > > > > In commit > > > > cd664b0e35cb ("io_uring: fix hanging iopoll in case of -EAGAIN") > > > > Fixes tag > > > > Fixes: bbde017a32b3 ("io_uring: add memory barrier to

Re: linux-next: Fixes tag needs some work in the block tree

2020-06-26 Thread Jens Axboe
On 6/26/20 5:07 PM, Stephen Rothwell wrote: > Hi all, > > In commit > > cd664b0e35cb ("io_uring: fix hanging iopoll in case of -EAGAIN") > > Fixes tag > > Fixes: bbde017a32b3 ("io_uring: add memory barrier to synchronize > > has these problem(s): > > - Subject has leading but no

linux-next: Fixes tag needs some work in the block tree

2020-06-26 Thread Stephen Rothwell
Hi all, In commit cd664b0e35cb ("io_uring: fix hanging iopoll in case of -EAGAIN") Fixes tag Fixes: bbde017a32b3 ("io_uring: add memory barrier to synchronize has these problem(s): - Subject has leading but no trailing parentheses - Subject has leading but no trailing quotes Please

linux-next: Fixes tag needs some work in the block tree

2020-05-28 Thread Stephen Rothwell
Hi all, In commit dc35ada4251f ("block: fix a warning when blkdev.h is included for !CONFIG_BLOCK builds") Fixes tag Fixes: 956d510ee78 ("block: add disk/bio-based accounting helpers") has these problem(s): - SHA1 should be at least 12 digits long Can be fixed by setting

Re: linux-next: Fixes tag needs some work in the block tree

2019-10-10 Thread Stephen Rothwell
Hi Bart, On Thu, 10 Oct 2019 10:36:36 -0700 Bart Van Assche wrote: > > On 10/7/19 1:16 PM, Stephen Rothwell wrote: > > > >Fixes: e34cbd307477 ("blk-wbt: add general throttling mechanism"; v4.10). > > The above fixes tag follows the recommended format except that it is > followed by a

Re: linux-next: Fixes tag needs some work in the block tree

2019-10-10 Thread Bart Van Assche
On 10/7/19 1:16 PM, Stephen Rothwell wrote: In commit 1d200e9d6f63 ("block: Fix writeback throttling W=1 compiler warnings") Fixes tag Fixes: e34cbd307477 ("blk-wbt: add general throttling mechanism"; v4.10). has these problem(s): - Subject has leading but no trailing quotes -

linux-next: Fixes tag needs some work in the block tree

2019-10-07 Thread Stephen Rothwell
Hi all, In commit 1d200e9d6f63 ("block: Fix writeback throttling W=1 compiler warnings") Fixes tag Fixes: e34cbd307477 ("blk-wbt: add general throttling mechanism"; v4.10). has these problem(s): - Subject has leading but no trailing quotes - Subject does not match target commit

linux-next: Fixes tag needs some work in the block tree

2019-09-10 Thread Stephen Rothwell
Hi all, In commit 8776f3fa15a5 ("io_uring: fix wrong sequence setting logic") Fixes tag Fixes: de0617e4671 ("io_uring: add support for marking commands as draining") has these problem(s): - SHA1 should be at least 12 digits long Can be fixed by setting core.abbrev to 12 (or more)

Re: linux-next: Fixes tag needs some work in the block tree

2019-07-12 Thread Minwoo Im
On 19-07-11 16:03:22, Jens Axboe wrote: > On 7/11/19 3:35 PM, Stephen Rothwell wrote: > > Hi all, > > > > In commit > > > >8f3858763d33 ("nvme: fix NULL deref for fabrics options") > > > > Fixes tag > > > >Fixes: 958f2a0f8 ("nvme-tcp: set the STABLE_WRITES flag when data digests > > >

Re: linux-next: Fixes tag needs some work in the block tree

2019-07-11 Thread Jens Axboe
On 7/11/19 3:35 PM, Stephen Rothwell wrote: > Hi all, > > In commit > >8f3858763d33 ("nvme: fix NULL deref for fabrics options") > > Fixes tag > >Fixes: 958f2a0f8 ("nvme-tcp: set the STABLE_WRITES flag when data digests > > has these problem(s): > >- SHA1 should be at least 12

linux-next: Fixes tag needs some work in the block tree

2019-07-11 Thread Stephen Rothwell
Hi all, In commit 8f3858763d33 ("nvme: fix NULL deref for fabrics options") Fixes tag Fixes: 958f2a0f8 ("nvme-tcp: set the STABLE_WRITES flag when data digests has these problem(s): - SHA1 should be at least 12 digits long Can be fixed by setting core.abbrev to 12 (or more) or (for

linux-next: Fixes tag needs some work in the block tree

2019-02-21 Thread Stephen Rothwell
Hi Jens, In commit 8f4e80da764e ("block: bounce: make sure that bvec table is updated") Fixes tag Fixes: 6dc4f100c ("block: allow bio_for_each_segment_all() to iterate over multi-page bvec") has these problem(s): - SHA1 should be at least 12 digits long Can be fixed by setting