Re: mfd: Core driver for Winbond chips

2013-04-29 Thread Guenter Roeck
On Wed, Apr 10, 2013 at 10:59:26PM +0200, Wim Van Sebroeck wrote: > Hi Guenter, > > > > I looked at commit 8b6d043b7ee2d1b819dc833d677ea2aead71a0c0 (which > > > implements > > > request_muxed_region). You indeed need some extra code for loading the > > > lowl-level > > > mfd driver. So I am

Re: mfd: Core driver for Winbond chips

2013-04-29 Thread Guenter Roeck
On Wed, Apr 10, 2013 at 10:59:26PM +0200, Wim Van Sebroeck wrote: Hi Guenter, I looked at commit 8b6d043b7ee2d1b819dc833d677ea2aead71a0c0 (which implements request_muxed_region). You indeed need some extra code for loading the lowl-level mfd driver. So I am also in favour of

Re: mfd: Core driver for Winbond chips

2013-04-10 Thread Wim Van Sebroeck
Hi Guenter, > > I looked at commit 8b6d043b7ee2d1b819dc833d677ea2aead71a0c0 (which > > implements > > request_muxed_region). You indeed need some extra code for loading the > > lowl-level > > mfd driver. So I am also in favour of the exported function. > > > So which way should we go ? Take

Re: mfd: Core driver for Winbond chips

2013-04-10 Thread Wim Van Sebroeck
Hi Guenter, I looked at commit 8b6d043b7ee2d1b819dc833d677ea2aead71a0c0 (which implements request_muxed_region). You indeed need some extra code for loading the lowl-level mfd driver. So I am also in favour of the exported function. So which way should we go ? Take your driver as

Re: mfd: Core driver for Winbond chips

2013-04-09 Thread Guenter Roeck
On Tue, Apr 09, 2013 at 07:31:15PM +0200, Wim Van Sebroeck wrote: > Hi Guenter, > > > > > I was waiting for feedback from Wim, who submitted a similar driver, > > > > about his > > > > thoughts. Key question is how to reserve access to the shared resource > > > > - either > > > > through an

Re: mfd: Core driver for Winbond chips

2013-04-09 Thread Wim Van Sebroeck
Hi Guenter, > > > I was waiting for feedback from Wim, who submitted a similar driver, > > > about his > > > thoughts. Key question is how to reserve access to the shared resource - > > > either > > > through an exported function in the mfd driver requesting a mutex, or > > > through > > >

Re: mfd: Core driver for Winbond chips

2013-04-09 Thread Guenter Roeck
On Tue, Apr 09, 2013 at 01:45:44PM +0200, Wim Van Sebroeck wrote: > Hi Guenter, > > > I was waiting for feedback from Wim, who submitted a similar driver, about > > his > > thoughts. Key question is how to reserve access to the shared resource - > > either > > through an exported function in

Re: mfd: Core driver for Winbond chips

2013-04-09 Thread Wim Van Sebroeck
Hi Guenter, > I was waiting for feedback from Wim, who submitted a similar driver, about his > thoughts. Key question is how to reserve access to the shared resource - > either > through an exported function in the mfd driver requesting a mutex, or through > request_muxed_region(). I am going

Re: mfd: Core driver for Winbond chips

2013-04-09 Thread Wim Van Sebroeck
Hi Samuel, > > MFD core driver for various variants of Winbond/Nuvoton SuperIO chips. > > > > Signed-off-by: Guenter Roeck > > --- > > drivers/mfd/Kconfig | 22 +++ > > drivers/mfd/Makefile |1 + > > drivers/mfd/w83627hf-core.c | 324 > >

Re: mfd: Core driver for Winbond chips

2013-04-09 Thread Guenter Roeck
On Tue, Apr 09, 2013 at 11:37:01AM +0200, Samuel Ortiz wrote: > Hi Guenter, > > On Sat, Mar 23, 2013 at 10:49:14AM -0700, Guenter Roeck wrote: > > MFD core driver for various variants of Winbond/Nuvoton SuperIO chips. > > > > Signed-off-by: Guenter Roeck > > --- > > drivers/mfd/Kconfig

Re: mfd: Core driver for Winbond chips

2013-04-09 Thread Samuel Ortiz
Hi Guenter, On Sat, Mar 23, 2013 at 10:49:14AM -0700, Guenter Roeck wrote: > MFD core driver for various variants of Winbond/Nuvoton SuperIO chips. > > Signed-off-by: Guenter Roeck > --- > drivers/mfd/Kconfig | 22 +++ > drivers/mfd/Makefile |1 + >

Re: mfd: Core driver for Winbond chips

2013-04-09 Thread Samuel Ortiz
Hi Guenter, On Sat, Mar 23, 2013 at 10:49:14AM -0700, Guenter Roeck wrote: MFD core driver for various variants of Winbond/Nuvoton SuperIO chips. Signed-off-by: Guenter Roeck li...@roeck-us.net --- drivers/mfd/Kconfig | 22 +++ drivers/mfd/Makefile |1 +

Re: mfd: Core driver for Winbond chips

2013-04-09 Thread Guenter Roeck
On Tue, Apr 09, 2013 at 11:37:01AM +0200, Samuel Ortiz wrote: Hi Guenter, On Sat, Mar 23, 2013 at 10:49:14AM -0700, Guenter Roeck wrote: MFD core driver for various variants of Winbond/Nuvoton SuperIO chips. Signed-off-by: Guenter Roeck li...@roeck-us.net --- drivers/mfd/Kconfig

Re: mfd: Core driver for Winbond chips

2013-04-09 Thread Wim Van Sebroeck
Hi Samuel, MFD core driver for various variants of Winbond/Nuvoton SuperIO chips. Signed-off-by: Guenter Roeck li...@roeck-us.net --- drivers/mfd/Kconfig | 22 +++ drivers/mfd/Makefile |1 + drivers/mfd/w83627hf-core.c | 324

Re: mfd: Core driver for Winbond chips

2013-04-09 Thread Wim Van Sebroeck
Hi Guenter, I was waiting for feedback from Wim, who submitted a similar driver, about his thoughts. Key question is how to reserve access to the shared resource - either through an exported function in the mfd driver requesting a mutex, or through request_muxed_region(). I am going back

Re: mfd: Core driver for Winbond chips

2013-04-09 Thread Guenter Roeck
On Tue, Apr 09, 2013 at 01:45:44PM +0200, Wim Van Sebroeck wrote: Hi Guenter, I was waiting for feedback from Wim, who submitted a similar driver, about his thoughts. Key question is how to reserve access to the shared resource - either through an exported function in the mfd driver

Re: mfd: Core driver for Winbond chips

2013-04-09 Thread Wim Van Sebroeck
Hi Guenter, I was waiting for feedback from Wim, who submitted a similar driver, about his thoughts. Key question is how to reserve access to the shared resource - either through an exported function in the mfd driver requesting a mutex, or through request_muxed_region().

Re: mfd: Core driver for Winbond chips

2013-04-09 Thread Guenter Roeck
On Tue, Apr 09, 2013 at 07:31:15PM +0200, Wim Van Sebroeck wrote: Hi Guenter, I was waiting for feedback from Wim, who submitted a similar driver, about his thoughts. Key question is how to reserve access to the shared resource - either through an exported function in the

Re: mfd: Core driver for Winbond chips

2013-03-24 Thread Guenter Roeck
On Sat, Mar 23, 2013 at 10:49:14AM -0700, Guenter Roeck wrote: > MFD core driver for various variants of Winbond/Nuvoton SuperIO chips. > > Signed-off-by: Guenter Roeck Sorry for sending this twice. I seem to be having trouble with outgoing e-mail being delayed for hours. The first patch didn't

Re: mfd: Core driver for Winbond chips

2013-03-24 Thread Guenter Roeck
On Sat, Mar 23, 2013 at 10:49:14AM -0700, Guenter Roeck wrote: MFD core driver for various variants of Winbond/Nuvoton SuperIO chips. Signed-off-by: Guenter Roeck li...@roeck-us.net Sorry for sending this twice. I seem to be having trouble with outgoing e-mail being delayed for hours. The

mfd: Core driver for Winbond chips

2013-03-23 Thread Guenter Roeck
MFD core driver for various variants of Winbond/Nuvoton SuperIO chips. Signed-off-by: Guenter Roeck --- drivers/mfd/Kconfig | 22 +++ drivers/mfd/Makefile |1 + drivers/mfd/w83627hf-core.c | 324 ++ include/linux/mfd/w83627hf.h |

mfd: Core driver for Winbond chips

2013-03-23 Thread Guenter Roeck
MFD core driver for various variants of Winbond/Nuvoton SuperIO chips. Signed-off-by: Guenter Roeck li...@roeck-us.net --- drivers/mfd/Kconfig | 22 +++ drivers/mfd/Makefile |1 + drivers/mfd/w83627hf-core.c | 324 ++