Re: netlink: NULL timer crash

2017-07-26 Thread ChunYu Wang
Wo, thanks! On Wed, Jul 26, 2017 at 9:13 PM, Dmitry Vyukov wrote: > On Wed, Jul 26, 2017 at 3:09 PM, wrote: >> Hi Dmitry, >> >> By trying to apply your reproducer to normal kernels, this scenery can not >> be reproduced (on fedora). Does this C

Re: netlink: NULL timer crash

2017-07-26 Thread ChunYu Wang
Wo, thanks! On Wed, Jul 26, 2017 at 9:13 PM, Dmitry Vyukov wrote: > On Wed, Jul 26, 2017 at 3:09 PM, wrote: >> Hi Dmitry, >> >> By trying to apply your reproducer to normal kernels, this scenery can not >> be reproduced (on fedora). Does this C source only for KASAN kernels? > > No, NULL

Re: netlink: NULL timer crash

2017-07-26 Thread Dmitry Vyukov
On Wed, Jul 26, 2017 at 3:09 PM, wrote: > Hi Dmitry, > > By trying to apply your reproducer to normal kernels, this scenery can not > be reproduced (on fedora). Does this C source only for KASAN kernels? No, NULL derefs are detected without KASAN. > On Thursday,

Re: netlink: NULL timer crash

2017-07-26 Thread Dmitry Vyukov
On Wed, Jul 26, 2017 at 3:09 PM, wrote: > Hi Dmitry, > > By trying to apply your reproducer to normal kernels, this scenery can not > be reproduced (on fedora). Does this C source only for KASAN kernels? No, NULL derefs are detected without KASAN. > On Thursday, March 23, 2017 at 8:55:52 PM

Re: netlink: NULL timer crash

2017-03-23 Thread Eric Dumazet
On Thu, 2017-03-23 at 12:00 -0700, David Miller wrote: > From: Eric Dumazet > Date: Thu, 23 Mar 2017 09:00:58 -0700 > > > On Thu, 2017-03-23 at 07:53 -0700, Eric Dumazet wrote: > > > >> Nice ! > >> > >> Looks like neigh->ops->solicit is NULL > > > > Apparently we allow

Re: netlink: NULL timer crash

2017-03-23 Thread Eric Dumazet
On Thu, 2017-03-23 at 12:00 -0700, David Miller wrote: > From: Eric Dumazet > Date: Thu, 23 Mar 2017 09:00:58 -0700 > > > On Thu, 2017-03-23 at 07:53 -0700, Eric Dumazet wrote: > > > >> Nice ! > >> > >> Looks like neigh->ops->solicit is NULL > > > > Apparently we allow admins to do really

Re: netlink: NULL timer crash

2017-03-23 Thread David Miller
From: Eric Dumazet Date: Thu, 23 Mar 2017 09:00:58 -0700 > On Thu, 2017-03-23 at 07:53 -0700, Eric Dumazet wrote: > >> Nice ! >> >> Looks like neigh->ops->solicit is NULL > > Apparently we allow admins to do really stupid things with neighbours > on tunnels. > >

Re: netlink: NULL timer crash

2017-03-23 Thread David Miller
From: Eric Dumazet Date: Thu, 23 Mar 2017 09:00:58 -0700 > On Thu, 2017-03-23 at 07:53 -0700, Eric Dumazet wrote: > >> Nice ! >> >> Looks like neigh->ops->solicit is NULL > > Apparently we allow admins to do really stupid things with neighbours > on tunnels. > > Following patch should avoid

Re: netlink: NULL timer crash

2017-03-23 Thread Eric Dumazet
On Thu, 2017-03-23 at 07:53 -0700, Eric Dumazet wrote: > Nice ! > > Looks like neigh->ops->solicit is NULL Apparently we allow admins to do really stupid things with neighbours on tunnels. Following patch should avoid the crash. Anyone has better ideas ? net/ipv4/arp.c |5 +

Re: netlink: NULL timer crash

2017-03-23 Thread Eric Dumazet
On Thu, 2017-03-23 at 07:53 -0700, Eric Dumazet wrote: > Nice ! > > Looks like neigh->ops->solicit is NULL Apparently we allow admins to do really stupid things with neighbours on tunnels. Following patch should avoid the crash. Anyone has better ideas ? net/ipv4/arp.c |5 +

Re: netlink: NULL timer crash

2017-03-23 Thread Eric Dumazet
On Thu, Mar 23, 2017 at 5:55 AM, Dmitry Vyukov wrote: > Hello, > > The following program triggers call of NULL timer func: > > https://gist.githubusercontent.com/dvyukov/c210d01c74b911273469a93862ea7788/raw/2a3182772a6a6e20af3e71c02c2a1c2895d803fb/gistfile1.txt > > > BUG:

Re: netlink: NULL timer crash

2017-03-23 Thread Eric Dumazet
On Thu, Mar 23, 2017 at 5:55 AM, Dmitry Vyukov wrote: > Hello, > > The following program triggers call of NULL timer func: > > https://gist.githubusercontent.com/dvyukov/c210d01c74b911273469a93862ea7788/raw/2a3182772a6a6e20af3e71c02c2a1c2895d803fb/gistfile1.txt > > > BUG: unable to handle kernel

netlink: NULL timer crash

2017-03-23 Thread Dmitry Vyukov
Hello, The following program triggers call of NULL timer func: https://gist.githubusercontent.com/dvyukov/c210d01c74b911273469a93862ea7788/raw/2a3182772a6a6e20af3e71c02c2a1c2895d803fb/gistfile1.txt BUG: unable to handle kernel NULL pointer dereference at (null) IP: (null)

netlink: NULL timer crash

2017-03-23 Thread Dmitry Vyukov
Hello, The following program triggers call of NULL timer func: https://gist.githubusercontent.com/dvyukov/c210d01c74b911273469a93862ea7788/raw/2a3182772a6a6e20af3e71c02c2a1c2895d803fb/gistfile1.txt BUG: unable to handle kernel NULL pointer dereference at (null) IP: (null)