Re: perf, x86: Add parts of the remaining haswell PMU functionality v5

2013-09-09 Thread Andi Kleen
On Mon, Sep 09, 2013 at 10:11:05AM +0200, Ingo Molnar wrote: > > * Andi Kleen wrote: > > > I hope this version is ok for everyone now. > > This version arrived in the middle of the merge window, will look after > -rc1 has been released. Ok. > > If there are any bugfixes (or erratum

Re: perf, x86: Add parts of the remaining haswell PMU functionality v5

2013-09-09 Thread Ingo Molnar
* Andi Kleen wrote: > I hope this version is ok for everyone now. This version arrived in the middle of the merge window, will look after -rc1 has been released. If there are any bugfixes (or erratum fixes/workarounds) pending then you'll need to send them separately against the current

Re: perf, x86: Add parts of the remaining haswell PMU functionality v5

2013-09-09 Thread Andi Kleen
On Mon, Sep 09, 2013 at 10:11:05AM +0200, Ingo Molnar wrote: * Andi Kleen a...@firstfloor.org wrote: I hope this version is ok for everyone now. This version arrived in the middle of the merge window, will look after -rc1 has been released. Ok. If there are any bugfixes (or erratum

Re: perf, x86: Add parts of the remaining haswell PMU functionality v5

2013-09-09 Thread Ingo Molnar
* Andi Kleen a...@firstfloor.org wrote: I hope this version is ok for everyone now. This version arrived in the middle of the merge window, will look after -rc1 has been released. If there are any bugfixes (or erratum fixes/workarounds) pending then you'll need to send them separately

perf, x86: Add parts of the remaining haswell PMU functionality v5

2013-09-05 Thread Andi Kleen
I hope this version is ok for everyone now. [v2: Added Peter's changes to the PEBS handler] [v3: Addressed Arnaldo's feedback for the perf stat -T change and avoid conflict] [v4: Remove XXX comment in checkpoint patch. Add Arnaldo's ack for tools patch] [v5: Some white space

Re: perf, x86: Add parts of the remaining haswell PMU functionality

2013-09-05 Thread Andi Kleen
> Well, at least the front-end side is still documented in the SDM as being > usable to count stalled cycles. Stalled frontend cycles does not necessarily mean frontend bound. The real bottleneck can be still somewhere later in the PipeLine. Out of Order CPUs are complex. > > AFAICS backend

Re: perf, x86: Add parts of the remaining haswell PMU functionality

2013-09-05 Thread Ingo Molnar
* Andi Kleen wrote: > On Thu, Sep 05, 2013 at 03:15:02PM +0200, Ingo Molnar wrote: > > > > * Ingo Molnar wrote: > > > > > One thing I'm not seeing in the current Haswell code is the config set > > > up for PERF_COUNT_HW_STALLED_CYCLES_FRONTEND/BACKEND. Both SB and IB has > > > them

Re: perf, x86: Add parts of the remaining haswell PMU functionality

2013-09-05 Thread Ingo Molnar
* Andi Kleen wrote: > The correct way is to implement it like TopDown level 1, but I don't > know how to put that into the kernel. Create an event group, with some callbacks to do the additions/subtractions to get at the right figures? (if it's plain linear arithmetics then that could be

Re: perf, x86: Add parts of the remaining haswell PMU functionality

2013-09-05 Thread Andi Kleen
On Thu, Sep 05, 2013 at 03:15:02PM +0200, Ingo Molnar wrote: > > * Ingo Molnar wrote: > > > One thing I'm not seeing in the current Haswell code is the config set > > up for PERF_COUNT_HW_STALLED_CYCLES_FRONTEND/BACKEND. Both SB and IB has > > them configured. > > Ping? Consider this a

Re: perf, x86: Add parts of the remaining haswell PMU functionality

2013-09-05 Thread Ingo Molnar
* Ingo Molnar wrote: > One thing I'm not seeing in the current Haswell code is the config set > up for PERF_COUNT_HW_STALLED_CYCLES_FRONTEND/BACKEND. Both SB and IB has > them configured. Ping? Consider this a regression report. Thanks, Ingo -- To unsubscribe from this list: send

Re: perf, x86: Add parts of the remaining haswell PMU functionality

2013-09-05 Thread Ingo Molnar
* Ingo Molnar mi...@kernel.org wrote: One thing I'm not seeing in the current Haswell code is the config set up for PERF_COUNT_HW_STALLED_CYCLES_FRONTEND/BACKEND. Both SB and IB has them configured. Ping? Consider this a regression report. Thanks, Ingo -- To unsubscribe from this

Re: perf, x86: Add parts of the remaining haswell PMU functionality

2013-09-05 Thread Andi Kleen
On Thu, Sep 05, 2013 at 03:15:02PM +0200, Ingo Molnar wrote: * Ingo Molnar mi...@kernel.org wrote: One thing I'm not seeing in the current Haswell code is the config set up for PERF_COUNT_HW_STALLED_CYCLES_FRONTEND/BACKEND. Both SB and IB has them configured. Ping? Consider this a

Re: perf, x86: Add parts of the remaining haswell PMU functionality

2013-09-05 Thread Ingo Molnar
* Andi Kleen a...@firstfloor.org wrote: The correct way is to implement it like TopDown level 1, but I don't know how to put that into the kernel. Create an event group, with some callbacks to do the additions/subtractions to get at the right figures? (if it's plain linear arithmetics then

Re: perf, x86: Add parts of the remaining haswell PMU functionality

2013-09-05 Thread Ingo Molnar
* Andi Kleen a...@firstfloor.org wrote: On Thu, Sep 05, 2013 at 03:15:02PM +0200, Ingo Molnar wrote: * Ingo Molnar mi...@kernel.org wrote: One thing I'm not seeing in the current Haswell code is the config set up for PERF_COUNT_HW_STALLED_CYCLES_FRONTEND/BACKEND. Both SB and IB

Re: perf, x86: Add parts of the remaining haswell PMU functionality

2013-09-05 Thread Andi Kleen
Well, at least the front-end side is still documented in the SDM as being usable to count stalled cycles. Stalled frontend cycles does not necessarily mean frontend bound. The real bottleneck can be still somewhere later in the PipeLine. Out of Order CPUs are complex. AFAICS backend stall

perf, x86: Add parts of the remaining haswell PMU functionality v5

2013-09-05 Thread Andi Kleen
I hope this version is ok for everyone now. [v2: Added Peter's changes to the PEBS handler] [v3: Addressed Arnaldo's feedback for the perf stat -T change and avoid conflict] [v4: Remove XXX comment in checkpoint patch. Add Arnaldo's ack for tools patch] [v5: Some white space

Re: perf, x86: Add parts of the remaining haswell PMU functionality

2013-09-02 Thread Ingo Molnar
One thing I'm not seeing in the current Haswell code is the config set up for PERF_COUNT_HW_STALLED_CYCLES_FRONTEND/BACKEND. Both SB and IB has them configured. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: perf, x86: Add parts of the remaining haswell PMU functionality

2013-09-02 Thread Ingo Molnar
One thing I'm not seeing in the current Haswell code is the config set up for PERF_COUNT_HW_STALLED_CYCLES_FRONTEND/BACKEND. Both SB and IB has them configured. Thanks, Ingo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to

perf, x86: Add parts of the remaining haswell PMU functionality v4

2013-08-31 Thread Andi Kleen
[v2: Added Peter's changes to the PEBS handler] [v3: Addressed Arnaldo's feedback for the perf stat -T change and avoid conflict] [v4: Remove XXX comment in checkpoint patch. Add Arnaldo's ack for tools patch] Add some more TSX functionality to the basic Haswell PMU. A lot of the

perf, x86: Add parts of the remaining haswell PMU functionality v4

2013-08-31 Thread Andi Kleen
[v2: Added Peter's changes to the PEBS handler] [v3: Addressed Arnaldo's feedback for the perf stat -T change and avoid conflict] [v4: Remove XXX comment in checkpoint patch. Add Arnaldo's ack for tools patch] Add some more TSX functionality to the basic Haswell PMU. A lot of the

perf, x86: Add parts of the remaining haswell PMU functionality v3

2013-08-21 Thread Andi Kleen
I hope this version is ok for everyone now. [v2: Added Peter's changes to the PEBS handler] [v3: Addressed Arnaldo's feedback for the perf stat -T change and avoid conflict] Add some more TSX functionality to the basic Haswell PMU. A lot of the infrastructure needed for these patches has

perf, x86: Add parts of the remaining haswell PMU functionality v3

2013-08-21 Thread Andi Kleen
I hope this version is ok for everyone now. [v2: Added Peter's changes to the PEBS handler] [v3: Addressed Arnaldo's feedback for the perf stat -T change and avoid conflict] Add some more TSX functionality to the basic Haswell PMU. A lot of the infrastructure needed for these patches has

perf, x86: Add parts of the remaining haswell PMU functionality v2

2013-08-14 Thread Andi Kleen
[v2: Added Peter's changes to the PEBS handler] Add some more TSX functionality to the basic Haswell PMU. A lot of the infrastructure needed for these patches has been merged earlier, so it is all quite straight forward now. - Add the checkpointed counter workaround. (Parts of this have been

perf, x86: Add parts of the remaining haswell PMU functionality v2

2013-08-14 Thread Andi Kleen
[v2: Added Peter's changes to the PEBS handler] Add some more TSX functionality to the basic Haswell PMU. A lot of the infrastructure needed for these patches has been merged earlier, so it is all quite straight forward now. - Add the checkpointed counter workaround. (Parts of this have been

perf, x86: Add parts of the remaining haswell PMU functionality

2013-08-08 Thread Andi Kleen
Add some more TSX functionality to the basic Haswell PMU. A lot of the infrastructure needed for these patches has been merged earlier, so it is all quite straight forward now. - Add the checkpointed counter workaround. (Parts of this have been already merged earlier) - Add support for reporting

perf, x86: Add parts of the remaining haswell PMU functionality

2013-08-08 Thread Andi Kleen
Add some more TSX functionality to the basic Haswell PMU. A lot of the infrastructure needed for these patches has been merged earlier, so it is all quite straight forward now. - Add the checkpointed counter workaround. (Parts of this have been already merged earlier) - Add support for reporting