Re: power_state: get rid of write-only variable in SATA

2008-02-23 Thread Jeff Garzik
Pavel Machek wrote: power_state is scheduled for removal, and libata uses it in write-only mode. Remove it. Signed-off-by: Pavel Machek <[EMAIL PROTECTED]> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index b4985bc..a31572d 100644 --- a/drivers/ata/libata-core.c +++

Re: power_state: get rid of write-only variable in SATA

2008-02-23 Thread Jeff Garzik
Pavel Machek wrote: power_state is scheduled for removal, and libata uses it in write-only mode. Remove it. Signed-off-by: Pavel Machek [EMAIL PROTECTED] diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index b4985bc..a31572d 100644 --- a/drivers/ata/libata-core.c +++

Re: [linux-pm] power_state: get rid of write-only variable in SATA

2008-02-21 Thread David Brownell
> libata uses it under the assumption that "other parts" of the system are > aware of this variable. > > May I assume that the API has changed such that this is no longer necessary? Yes. The original motivation for dev->power.power_state was to let the writes to /sys/devices/.../power/state

Re: power_state: get rid of write-only variable in SATA

2008-02-21 Thread Jeff Garzik
Pavel Machek wrote: power_state is scheduled for removal, and libata uses it in write-only mode. Remove it. Signed-off-by: Pavel Machek <[EMAIL PROTECTED]> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index b4985bc..a31572d 100644 --- a/drivers/ata/libata-core.c +++

power_state: get rid of write-only variable in SATA

2008-02-21 Thread Pavel Machek
power_state is scheduled for removal, and libata uses it in write-only mode. Remove it. Signed-off-by: Pavel Machek <[EMAIL PROTECTED]> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index b4985bc..a31572d 100644 --- a/drivers/ata/libata-core.c +++

power_state: get rid of write-only variable in SATA

2008-02-21 Thread Pavel Machek
power_state is scheduled for removal, and libata uses it in write-only mode. Remove it. Signed-off-by: Pavel Machek [EMAIL PROTECTED] diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index b4985bc..a31572d 100644 --- a/drivers/ata/libata-core.c +++ b/drivers/ata/libata-core.c

Re: power_state: get rid of write-only variable in SATA

2008-02-21 Thread Jeff Garzik
Pavel Machek wrote: power_state is scheduled for removal, and libata uses it in write-only mode. Remove it. Signed-off-by: Pavel Machek [EMAIL PROTECTED] diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index b4985bc..a31572d 100644 --- a/drivers/ata/libata-core.c +++

Re: [linux-pm] power_state: get rid of write-only variable in SATA

2008-02-21 Thread David Brownell
libata uses it under the assumption that other parts of the system are aware of this variable. May I assume that the API has changed such that this is no longer necessary? Yes. The original motivation for dev-power.power_state was to let the writes to /sys/devices/.../power/state support a