Re: selinux: Delete unnecessary variable assignments in policydb_index()

2017-03-27 Thread Paul Moore
On Mon, Mar 27, 2017 at 2:24 AM, SF Markus Elfring wrote: >> However, I agree with Casey that this patch is mostly just code churn >> so I'm going to drop this from your series. > > How do you think about to return only constant error codes in this function? > Would

Re: selinux: Delete unnecessary variable assignments in policydb_index()

2017-03-27 Thread Paul Moore
On Mon, Mar 27, 2017 at 2:24 AM, SF Markus Elfring wrote: >> However, I agree with Casey that this patch is mostly just code churn >> so I'm going to drop this from your series. > > How do you think about to return only constant error codes in this function? > Would it be acceptable to replace

Re: selinux: Delete unnecessary variable assignments in policydb_index()

2017-03-27 Thread SF Markus Elfring
> However, I agree with Casey that this patch is mostly just code churn > so I'm going to drop this from your series. How do you think about to return only constant error codes in this function? Would it be acceptable to replace any statements “goto out;” with “return -ENOMEM;” here instead?

Re: selinux: Delete unnecessary variable assignments in policydb_index()

2017-03-27 Thread SF Markus Elfring
> However, I agree with Casey that this patch is mostly just code churn > so I'm going to drop this from your series. How do you think about to return only constant error codes in this function? Would it be acceptable to replace any statements “goto out;” with “return -ENOMEM;” here instead?

Re: [PATCH 07/46] selinux: Delete unnecessary variable assignments in policydb_index()

2017-03-23 Thread Paul Moore
On Sun, Jan 15, 2017 at 10:04 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 14 Jan 2017 13:40:25 +0100 > > The local variable "rc" was reset with an error code up to five times > before a memory allocation failure

Re: [PATCH 07/46] selinux: Delete unnecessary variable assignments in policydb_index()

2017-03-23 Thread Paul Moore
On Sun, Jan 15, 2017 at 10:04 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 14 Jan 2017 13:40:25 +0100 > > The local variable "rc" was reset with an error code up to five times > before a memory allocation failure was detected. > > Add a jump target so that this assignment

Re: [PATCH 07/46] selinux: Delete unnecessary variable assignments in policydb_index()

2017-01-17 Thread Casey Schaufler
On 1/15/2017 7:04 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 14 Jan 2017 13:40:25 +0100 > > The local variable "rc" was reset with an error code up to five times > before a memory allocation failure was detected. > > Add a jump target so that

Re: [PATCH 07/46] selinux: Delete unnecessary variable assignments in policydb_index()

2017-01-17 Thread Casey Schaufler
On 1/15/2017 7:04 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 14 Jan 2017 13:40:25 +0100 > > The local variable "rc" was reset with an error code up to five times > before a memory allocation failure was detected. > > Add a jump target so that this assignment will only be

[PATCH 07/46] selinux: Delete unnecessary variable assignments in policydb_index()

2017-01-15 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 14 Jan 2017 13:40:25 +0100 The local variable "rc" was reset with an error code up to five times before a memory allocation failure was detected. Add a jump target so that this assignment will only be performed after a concrete

[PATCH 07/46] selinux: Delete unnecessary variable assignments in policydb_index()

2017-01-15 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 14 Jan 2017 13:40:25 +0100 The local variable "rc" was reset with an error code up to five times before a memory allocation failure was detected. Add a jump target so that this assignment will only be performed after a concrete software failure. Signed-off-by: